[urus]

Originally Posted by ShadoX Oh great, that'd be fantastic, imo atm that is really the only important bug to crunch, any of the others may be frustrating but this bug is the only one that i know that actually breaks the plugin/system oh well i'm off to do the daily Sourcemod update rounds on my servers again ><

After several tests with changed query i casually found that after mapchange string ServerIp (and may be ServerPort) don`t properly transfer to query.

I moved this code from InsertServerInfo () to onMapstart () and now all works fine:

    decl pieces[4];
    new longip = GetConVarInt(CvarHostIp);
    pieces[0] = (longip >> 24) & 0x000000FF;
    pieces[1] = (longip >> 16) & 0x000000FF;
    pieces[2] = (longip >> 8) & 0x000000FF;
    pieces[3] = longip & 0x000000FF;
    FormatEx(ServerIp, sizeof(ServerIp), "%d.%d.%d.%d", pieces[0], pieces[1], pieces[2], pieces[3]);
    GetConVarString(CvarPort, ServerPort, sizeof(ServerPort));

[ShadoX]

cool i'll give that a try until its officially fixed, cheers

[Olly]

Originally Posted by lamdacore Olly, do you think there will be still sql database changes in your svn or will you release a stable RC2 some day? We currently use the RC1 release with some bugfixed things. I know since then there was many sql database structure changes so I decided to update sourcebans not so frequently. Now the database is a little bit filled with data that we won't miss on an update. I'm afraid of updating because of losing the current data in the database or of not be able of using the main functionallity without errors. So a stable RC2 release would be better for us I think. Or at least if there will not be any database structure changes anymore I can try to convert my database to the current and don't have to deal with that in the future. What do you think?

The update scripts will not delete data, but it is always recommended to backup your data often, so that if something does go bad you always have a backup ;)

Originally Posted by urus After several tests with changed query i casually found that after mapchange string ServerIp (and may be ServerPort) don`t properly transfer to query. I moved this code from InsertServerInfo () to onMapstart () and now all works fine: decl pieces[4]; new longip = GetConVarInt(CvarHostIp); pieces[0] = (longip >> 24) & 0x000000FF; pieces[1] = (longip >> 16) & 0x000000FF; pieces[2] = (longip >> 8) & 0x000000FF; pieces[3] = longip & 0x000000FF; FormatEx(ServerIp, sizeof(ServerIp), "%d.%d.%d.%d", pieces[0], pieces[1], pieces[2], pieces[3]); GetConVarString(CvarPort, ServerPort, sizeof(ServerPort));

Thanks, ill take a look at this tonight

[Olly]

Some more small bug-fixes and some minor features

This has only been updated in the 1.0.0 RC2 Development release (From http://sourcebans.net/snaps.php)


Changes: - Rev46 -> Rev50

• Fixed LOOOTS of problems with the installer
• Removed the ADODB library folder from install dir, now uses the one in the root folder.
• Removed TinyMCE folder in install dir (no idea why this was there)
• Added installer check for /themes_c to be writable
• Added check for missing information on page 5 (setup main admin)
• Fixed players not showing up in IE (pages load slower, so IE has ruined it for all of us >:/) - http://www.getfirefox.com ;)
• Fixed small problem when getting info from the PROXY server
• The Proxy server is now back online, Users who have shit hosts can now query our server to retrieve server, and player data.
• Added new native (SBBanPlayer) for external plugins to ban through SourceBans

sourcebans.inc

#if defined _sourcebans_included
  #endinput
#endif
#define _sourcebans_included

public SharedPlugin:__pl_sourcebans = 
{
    name = "SourceBans",
    file = "sourcebans.smx",
    required = 0
};


public __pl_sourcebans_SetNTVOptional()
{
    MarkNativeAsOptional("SBBanPlayer");
}


/*********************************************************
 * Ban Player from server
 *
 * @param client    The client index of the admin who is banning the client
 * @param target    The client index of the player to ban
 * @param time        The time to ban the player for (in minutes, 0 = permanent)
 * @param reason    The reason to ban the player from the server
 * @noreturn        
 *********************************************************/
native SBBanPlayer(client, target, time, String:reason[]);

//Yarr!

sourcebans_sample.sp

/**
* sourcebans.sp
*
* This file contains all Source Server Plugin Functions
* @author SteamFriends Development Team
* @version 0.0.0.$Rev: 108 $
* @copyright SteamFriends (www.steamfriends.com)
* @package SourceBans
* @link http://www.sourcebans.net
*/

#pragma semicolon 1
#include <sourcemod>
#include <sourcebans>

#undef REQUIRE_PLUGIN
#include <adminmenu>
#include "dbi.inc"

public Plugin:myinfo =
{
    name = "SourceBans Sample Plugin",
    author = "SteamFriends Development Team",
    description = "Sample plugin to show SourceBans functionality",
    version = "1.0.0 RC2",
    url = "http://www.sourcebans.net"
};


public banSample()
{
    new client = 1;
    
    SBBanPlayer(client, client, 5, "Ohnoes i banned myself");
}

Downloads:
The snapshots have been updated, and the links for the updated version are here:

sourcebans_RC2_50-2008-01-10.zip - (6.92 MB)
sourcebans_RC2_50-2008-01-10.tar.gz - (6.30 MB)


Changed files:
M /trunk/changelog.txt
M /trunk/game_upload/addons/sourcemod/plugins/sourcebans.smx
A /trunk/game_upload/addons/sourcemod/plugins/sourcebans_sample.smx
A /trunk/game_upload/addons/sourcemod/scripting/include
A /trunk/game_upload/addons/sourcemod/scripting/include/sourcebans.inc
M /trunk/game_upload/addons/sourcemod/scripting/sourcebans.sp
A /trunk/game_upload/addons/sourcemod/scripting/sourcebans_sample.sp
M /trunk/web_upload/includes/CServerInfo.php
M /trunk/web_upload/pages/page.servers.php
M /trunk/web_upload/themes/default/page_servers.tpl
D /trunk/web_upload/install/includes/adodb
M /trunk/web_upload/install/includes/css.php
D /trunk/web_upload/install/includes/tinymce
M /trunk/web_upload/install/init.php
M /trunk/web_upload/install/scripts/sourcebans.js
M /trunk/web_upload/install/template/content.header.php
M /trunk/web_upload/install/template/footer.php
M /trunk/web_upload/install/template/header.php
M /trunk/web_upload/install/template/page.2.php
M /trunk/web_upload/install/template/page.3.php
M /trunk/web_upload/install/template/page.4.php
M /trunk/web_upload/install/template/page.5.php

[ m = Modified - D = Deleted - A = Added ]


Once again (just to bump the link) could you please post bugs, and requests here (http://sourcebans.net/bugs/index.php?project=2)

Keep Bannin`

Olly

[ShadoX]

nice one

Though does any of this fix the sid problem? Do you want me to open a bug report

[Olly]

Originally Posted by ShadoX nice one Though does any of this fix the sid problem? Do you want me to open a bug report

No this still doesnt fix the SID problem, i need to think about how the best way of fixing it will be

[ShadoX]

Ah...right, well i've found a very temp fix that doesn't need any coding changes

Just go into your database, go to sb_bans, edit the sid field and allow it to be null, easy fix

Only thing is every ban will come up as a web ban, but personally i'd rather it say web ban on all new bans then not have then actually ban at all

[W][LDF][RE]

Just wanted to say thanks Olly for your continued efforts. You could have walked away from this project and been like ohh well. You are da man!!

[Olly]

Originally Posted by ShadoX Ah...right, well i've found a very temp fix that doesn't need any coding changes Just go into your database, go to sb_bans, edit the sid field and allow it to be null, easy fix Only thing is every ban will come up as a web ban, but personally i'd rather it say web ban on all new bans then not have then actually ban at all

Yea that would work, but that wasnt the fix I had in-mind

Originally Posted by W][LDF][RE Just wanted to say thanks Olly for your continued efforts. You could have walked away from this project and been like ohh well. You are da man!!

Thanks

[Manni]

BIG THANK YOU FOR YOUR LATEST UPDATE(S)