[Exolent[jNr]]

In all the cases I could use packed strings for my large arrays such as MOTDs or menus, it wouldn't work because the functions require unpacked. So my question is this: why use packed strings if its only use is for smaller variables that wouldn't improve memory usage as much as the large arrays?

[Bugsy]

Edit: Not working. See post http://forums.alliedmods.net/showpos...7&postcount=16

I just found that format is working with packed strings. Can someone please confirm this because I just woke up and didn't have my coffee yet, maybe I'm doing something wrong.

Result:
Unpacked: This is a test string . Size=1024
Packed: This is a test string . Size=256

PHP Code:

public plugin_init() 
{
    register_plugin( "pack test" , "0.1" , "bugsy" )
    
    new szTest[1024 char];
    //new szTest[1024];
    
    format( szTest , 1023 ,"This is a test string" )
    
    server_print("%s . Size=%d" , szTest , sizeof szTest );
} 


[Spunky]

I get the same results.

Packed: Spunky (8) Unpacked: Spunky (32)

#include <amxmodx>

public plugin_init()
{
    register_plugin("Packed Strings", "1.0", "Spunky")

    register_clcmd("say /stringtest", "cmd_stringtest")
}

public cmd_stringtest(id, level, cid)
{
    new szPackedName[32 char]
    get_user_name(id, szPackedName, 31)
    console_print(id, "Packed: %s (%d)", szPackedName, sizeof szPackedName)

    new szUnpackedName[32]
    get_user_name(id, szUnpackedName, 31)
    console_print(id, "Unpacked: %s (%d)", szUnpackedName, sizeof szUnpackedName)

    return PLUGIN_HANDLED
}

[Exolent[jNr]]

I did a test myself:

static motd[2500 char], len;

// format MOTD

console_print(client, "Sizeof packed MOTD = %i", sizeof(motd));

show_motd(client, motd, title);

Compiled fine and returned 625.

[joaquimandrade]

Originally Posted by Bugsy I just found that format is working with packed strings. Can someone please confirm this because I just woke up and didn't have my coffee yet, maybe I'm doing something wrong. Result: Unpacked: This is a test string . Size=1024 Packed: This is a test string . Size=256 PHP Code: public plugin_init()  {     register_plugin( "pack test" , "0.1" , "bugsy" )          new szTest[1024 char];     //new szTest[1024];          format( szTest , 1023 ,"This is a test string" )          server_print("%s . Size=%d" , szTest , sizeof szTest ); }

That is not "working with packed string". You are declaring a variable with the "char operator" but you are using it as a normal string. Basically, what you are doing is:

PHP Code:

public plugin_init() 
 {
     register_plugin( "pack test" , "0.1" , "bugsy" )
     
     new szTest[256];
     //new szTest[1024];
     
     format( szTest , 1023 ,"This is a test string" )
     
     server_print("%s . Size=%d" , szTest , sizeof szTest );
 } 


Originally Posted by Exolent[jNr] I did a test myself: Code: static motd[2500 char], len; // format MOTD console_print(client, "Sizeof packed MOTD = %i", sizeof(motd)); show_motd(client, motd, title); Compiled fine and returned 625.

But it will not work. It will show just the 4th character from each cell.

[Bugsy]

Originally Posted by joaquimandrade That is not "working with packed string". You are declaring a variable with the "char operator" but you are using it as a normal string. Basically, what you are doing is: But it will not work. It will show just the 4th character from each cell.

Yes, I realized this literally as I pulled out of my driveway on my way to work shortly after posting; I did not have internet access until now to edit my post. The above code only appeared to work since my code example had such a large buffer so there were enough cells to properly display the string.

What is happening is the array is getting declared with char so that will trim the cell count down to [1024 / 4 = 256]. When passed to format, it is treated as a normal 256 sized buffer [unpacked] and is able to be printed\manipulated. If you trim the buffer down to the actual size and try to format, your server will error.

PHP Code:

public plugin_init() 
 {
     register_plugin( "pack test" , "0.1" , "bugsy" )
     
     //Will error the server
     /// new szTest[22 char];
     
     //Will work as normal
     // new szTest[22];
     
     //Will cause the 'g' to be cut off of the word "string"
     new szTest[84 char];

     format( szTest , sizeof szTest - 1 ,"This is a test string" )
     
     server_print("%s . Size=%d" , szTest , sizeof szTest );
 } 


[Spunky]

Aww lame. I thought I'd learned an amazing memory saving technique.

Any chance of AMXX natives using packed strings in the future?

[Bugsy]

Originally Posted by Spunky Aww lame. I thought I'd learned an amazing memory saving technique. Any chance of AMXX natives using packed strings in the future?

Why can't you use packed strings to save memory? Did you read the entire tutorial?

[Spunky]

If I understood everything up to this point correctly, it's only practical if you know the exact value you want to assign to the string. For example:

new szExample[8 char] = !"Spunky"

But if you want to find the value to assign, it won't work the same way:

new szExample[32 char]
get_user_name(id, szExample, 31)

Then it's not really a packed string. So is there a way around that?

[danielkza]

Originally Posted by Spunky If I understood everything up to this point correctly, it's only practical if you know the exact value you want to assign to the string. For example: Code: new szExample[8 char] = !"Spunky" But if you want to find the value to assign, it won't work the same way: Code: new szExample[32 char] get_user_name(id, szExample, 31) Then it's not really a packed string. So is there a way around that?

Recoding all AMXX's string natives, but that won't happen any time soon (if at all)