[naris]

I use these stock functions to maintain timers for clients.

PHP Code:

stock Handle:g_ClientTimers[MAXPLAYERS+1];

stock CreateClientTimer(client, Float:interval, Timer:func, flags=TIMER_REPEAT)
{
    if (g_ClientTimers[client] == INVALID_HANDLE)
        g_ClientTimers[client] = CreateTimer(interval,func,client,flags);
}

stock KillClientTimer(client)
{
    new Handle:timer=g_ClientTimers[client];
    if (timer != INVALID_HANDLE)
    {
        KillTimer(timer);
        g_ClientTimers[client] = INVALID_HANDLE;    
    }
}

stock KillAllClientTimers()
{
    for (new i = 1; i <= MaxClients; i++)
        KillClientTimer(i);
} 


Example usage:

PHP Code:

public Action:PlayerSpawnEvent(Handle:event,const String:name[],bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event,"userid"));
    if (client > 0)
    {
            CreateClientTimer(client, 3.0, DoSomething, TIMER_REPEAT);
    }
    return Plugin_Continue;
}

public OnPlayerDeathEvent(Handle:event,const String:name[],bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event,"userid"));
    if (client > 0)
    {
        KillClientTimer(client);
    }
} 


[naris]

Originally Posted by FeuerSturm I'm pretty sure that you can't use KillTimer or CloseHandle on a repeating timer as the handle changes everytime it's run again. Just stop the timer with "return Plugin_Stop" within the callback and you should be fine.

I never had a problem using KillTimer() on a repeating timer, as long as you don't try to kill it using KillTimer() AND stop it by returning Plugin_Stop. Use either one method OR the other, but not BOTH or one will kill the timer (probably the Plugin_Stop) and the other will error out (probably the KillTimer()) since the timer was already closed.

[naris]

Originally Posted by paegus the main timer, that repeats is doing most of the work, and firing very frequently (every 0.1 seconds). i'd like to close those timers that i don't need anymore. for dead players or trip alarms that haven't been triggered in the past however many seconds...

The main timer (tmr_DrawSprites() I presume) might not be repeating at all. THe timers are created with TIMER_REPEAT, but it doesn't return anything. To get the timer to actually repeat, you should return Plugin_Continue.

If the timer ends, that could be causing your errors.

[Fyren]

If you don't return anything in a function tagged Action, it's treated as if you returned Plugin_Continue, so his timer will repeat (though he really should return it himself for clarity).

Error 3 (from the original post) means the handle was already freed when SM went to free it. This probably means the script is calling CloseHandle on a timer during that timer's own callback (tmr_DrawSprites).

[kim_perm]

At the same time, how about plugin handle, when plugin is unloaded?