How can I restrict specific menu options? - Page 2

mlibre · 08-22-2023 , 13:02 Re: How can I restrict specific menu options?

well i guess v_m4a1 is already preloaded. no need to add to the list, and in OnSelectM4, do the preliminary checks to avoid errors, sort of like this.

Tote · *Last edited by Tote; 08-23-2023 at 04:56.*

Quote:

Originally Posted by mlibre

well i guess v_m4a1 is already preloaded. no need to add to the list, and in OnSelectM4, do the preliminary checks to avoid errors, sort of like this.

smth like this? not needed to check if item is m4a1 cause RegisterHam(Ham_Item_Deploy, "weapon_m4a1", "OnSelectM4", 1) already when item that is deployed is m4a1

PHP Code:


			
#include <amxmodx>
#include <fakemeta>
#include <engine>
#include <hamsandwich>

#define PLUGIN "Gun Skins"
#define VERSION "1.0"
#define AUTHOR "Tote"

#define ACCESS_FLAG ADMIN_LEVEL_H

new const M4Models[][] =
{
    "models/armas_m4/v_m4a11.mdl",
    "models/armas_m4/v_m4a12.mdl",
    "models/armas_m4/v_m4a13.mdl",
    "models/armas_m4/v_m4a14.mdl"
};

new SkinNames[][] = 
{
    "M4A1 [Default]",
    "M4A1 [D'CYAT]",
    "M4A1 [Golden'R]",
    "M4A1 [Hyper Beast]",
    "M4A1 [Howl]"
}

new m4[33];

public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    register_clcmd("say /m4", "M4SKINS")
    RegisterHam(Ham_Item_Deploy, "weapon_m4a1", "OnSelectM4", 1)
    
}

public plugin_precache() 
{
    
    for(new i; i < sizeof M4Models; i++) 
    {
        precache_model(M4Models[i]);
    }
}

public client_putinserver(id)
{
    m4[id] = 0
}

public M4SKINS( id )
{
    new menu = menu_create( "\rM4A1 SKINS:", "menu_handler" );
    
    menu_additem( menu, "\wM4A1 [DEFAULT]", "", 0 );
    menu_additem( menu, "\wM4A1 D'Cyan", "", 0 );
    menu_additem( menu, "\wM4A1 Golden'R", "", 0 );
    menu_additem( menu, "\wM4A1 Hyper Beast", "", 0 );
    menu_additem( menu, "\wM4A1 Howl", "", 0 );
    
    menu_setprop( menu, MPROP_EXIT, MEXIT_ALL );
    
    menu_display( id, menu, 0 );
    
}

public menu_handler( id, menu, item )
{
    switch( item )
    {
        case 0:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 0
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 1:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 1
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }    
        }
        case 2:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 2
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 3:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 3
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 4:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 4
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
    }
    menu_destroy( menu );
    return PLUGIN_HANDLED;
}

public OnSelectM4(id)
{
    if(!is_valid_ent(id) || !is_user_alive(id))
        return HAM_IGNORED;
    
    if(m4[id] >= 1) // using >= 1 to check whether the skin id is 1 or above because 0 is default skin
    {
        set_pev(id, pev_viewmodel2, M4Models[m4[id]])
    }
    return HAM_IGNORED;
}

mlibre · 08-22-2023 , 13:35 Re: How can I restrict specific menu options?

at the moment it will not compile, because it requires to include the engine, it uses EV_SZ_viewmodel, and in the end it has to return HAM_IGNORED, the compiler will prompt you with warnings.

Tote · 08-22-2023 , 15:00 Re: How can I restrict specific menu options?

Quote:

Originally Posted by mlibre

at the moment it will not compile, because it requires to include the engine, it uses EV_SZ_viewmodel, and in the end it has to return HAM_IGNORED, the compiler will prompt you with warnings.

There were no warnings. It compiled without any errors, but you're right I need to make it return ham ignored at the end, will do that when I'm back

mlibre · 08-22-2023 , 15:34 Re: How can I restrict specific menu options?

oh really? It's quite rare that it compiles since this "is_valid_ent" only exists in the engine and you use fakemeta, that's why I say it

Tote · *Last edited by Tote; 08-23-2023 at 04:56.*

Quote:

Originally Posted by mlibre

oh really? It's quite rare that it compiles since this "is_valid_ent" only exists in the engine and you use fakemeta, that's why I say it

My bad I thought i included engine, but I didnt. Updated my post, fixed the ham_ignore error & compilation include missing problem.

lexzor · *Last edited by lexzor; 08-24-2023 at 12:02.*

change

PHP Code:


			
public menu_handler( id, menu, item )
{
    switch( item )
    {
        case 0:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 0
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 1:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 1
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }    
        }
        case 2:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 2
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 3:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 3
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 4:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 4
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
    }
    menu_destroy( menu );
    return PLUGIN_HANDLED;
}

with this

Code:

public menu_handler( id, menu, item )
{
    menu_destroy( menu );

    if(~get_user_flags(id) & ACCESS_FLAG)
    {
        client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
        return
    }
    
    m4[id] = item

    client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[item])

    return
}

jesusaliso · 08-24-2023 , 12:11 Re: How can I restrict specific menu options?

Guys when I get back from work, I'm going to try the code! thank you so much!

Tote · *Last edited by Tote; 08-24-2023 at 12:41.*

Quote:

Originally Posted by lexzor

change

PHP Code:


			
public menu_handler( id, menu, item )
{
    switch( item )
    {
        case 0:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 0
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 1:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 1
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }    
        }
        case 2:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 2
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 3:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 3
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
        case 4:
        {
            if(~get_user_flags(id) & ACCESS_FLAG)
            {
                client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
                return PLUGIN_HANDLED
            }
            else
            {
                m4[id] = 4
                client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[m4[id]])
            }
        }
    }
    menu_destroy( menu );
    return PLUGIN_HANDLED;
}

with this

Code:

public menu_handler( id, menu, item )
{
    menu_destroy( menu );

    if(~get_user_flags(id) & ACCESS_FLAG)
    {
        client_print(id, print_chat, "Sorry, You do not have access to this m4 skin!");
        return
    }
    
    m4[id] = item

    client_print(id, print_chat, "You selected m4 skin: %s", SkinNames[item])

    return
}

it will restrict all menu items for all players who dont have this access.
he wants to make specific item restrict for player who dont have the required access

Quote:

Originally Posted by jesusaliso

Guys when I get back from work, I'm going to try the code! thank you so much!

welcome, you can try the code which i sent above

fysiks · 08-25-2023 , 01:42 Re: How can I restrict specific menu options?

No, using callbacks as shown in the example I linked to is the most efficient way to do this. There is no reason to waste a player's time by having him think he can select an option when he can't actually select it and then having to re-open the menu.