[Powerlord]

Originally Posted by salsav91 L 08/03/2013 - 02:44:27: [SM] Native "ShowVGUIPanel" reported: Client 2 is not in game L 08/03/2013 - 02:44:27: [SM] Displaying call stack trace for plugin "ponyradio.smx": L 08/03/2013 - 02:44:27: [SM] [0] Line 349, ponyradio.sp::PlayerOTD() L 08/03/2013 - 02:44:27: [SM] [1] Line 113, ponyradio.sp::RestartRadioTimer()

I see in the code a timer that sends client indexes, which is a no-no for timers. One should always send a more unique value, such as userids and then use GetClientOfUserId to get the client index back (or 0 if the client has since disconnected).

Originally Posted by salsav91 L 08/03/2013 - 00:22:12: [SM] Native "GetArrayCell" reported: Invalid index 0 (count: 0) L 08/03/2013 - 00:22:12: [SM] Displaying call stack trace for plugin "ponyradio.smx": L 08/03/2013 - 00:22:12: [SM] [0] Line 469, ponyradio.sp::GetStationID() L 08/03/2013 - 00:22:12: [SM] [1] Line 341, ponyradio.sp::PlayerOTD() L 08/03/2013 - 00:22:12: [SM] [2] Line 113, ponyradio.sp::RestartRadioTimer()

In addition to the previous issue, it sounds like this is being called before the station list is populated.

Originally Posted by salsav91 L 08/03/2013 - 02:42:44: [SM] Plugin encountered error 25: Call was aborted L 08/03/2013 - 02:42:44: [SM] Native "ThrowError" reported: Client 13 is not in game L 08/03/2013 - 02:42:44: [SM] Displaying call stack trace for plugin "ponyradio.smx": L 08/03/2013 - 02:42:44: [SM] [0] Line 59, C:\megaservers\compiler 1.5\include\colors.inc::CPrintToChat() L 08/03/2013 - 02:42:44: [SM] [1] Line 224, ponyradio.sp::AnnounceSong() L 08/03/2013 - 02:42:44: [SM] [2] Line 209, ponyradio.sp::DelayAnnounceSong()

Line 216 uses IsClientConnected when it should be using IsClientInGame.

Originally Posted by abrandnewday If I was ever to use this plugin, I would re-code it and remove any references to ponies or ponyville, and set it up with actual music like Led Zeppelin, Rush, Black Sabbath, Uriah Heep instead of pony music. But that's just me.

For that matter, this plugin could be written to be more generic by adding a cvar to get the station list from instead of hard-coding it.

[captaindeterprimary]

Originally Posted by Powerlord For that matter, this plugin could be written to be more generic by adding a cvar to get the station list from instead of hard-coding it.

All my yes to that. As long as it can still pull the song info from the shoutcast server which is not hard to get.

[Oshizu]

Originally Posted by abrandnewday If I was ever to use this plugin, I would re-code it and remove any references to ponies or ponyville, and set it up with actual music like Led Zeppelin, Rush, Black Sabbath, Uriah Heep instead of pony music. But that's just me.

Not just you

[WeAreBorg]

Originally Posted by Powerlord For that matter, this plugin could be written to be more generic by adding a cvar to get the station list from instead of hard-coding it.

The station list isn't hard coded. It is instead pulled and populated from the dowloaded file. The number of station is hard coded for a max of 9 atm



Also thank you very much for the bug reports. I'll fix those right away.

[WeAreBorg]

Originally Posted by abrandnewday If I was ever to use this plugin, I would re-code it and remove any references to ponies or ponyville, and set it up with actual music like Led Zeppelin, Rush, Black Sabbath, Uriah Heep instead of pony music. But that's just me.

I am working with my web guy in creating a php that you can host along with a SQL database that will let you configure your own shoutcast based stations. Sound interesting anyone?

[Powerlord]

Originally Posted by WeAreBorg The station list isn't hard coded. It is instead pulled and populated from the dowloaded file. The number of station is hard coded for a max of 9 atm Also thank you very much for the bug reports. I'll fix those right away.

I omitted the word (well, acronym really) URL in there... I knew it was being taken from a URL downloaded using SteamTools since I was looking at the source.

[WeAreBorg]

Originally Posted by Powerlord I omitted the word (well, acronym really) URL in there... I knew it was being taken from a URL downloaded using SteamTools since I was looking at the source.

Well the URL is rather worthless without a player. I would need to release a player some php with the plugin so that it could be fully customized

[WeAreBorg]

OK did some bug fixes here is the new version.

[friagram]

Too bad there are only a hand full of mlp songs that are decent :/
Oh well, remixes and chopshop songs for all.

[TheGame980]

I have the problem that the radio often just random starts playing a song.
I get a message "Radio Bla is now playing Bla - Bla" and then the radio starts playing, even if I never type !radio.