Chat Rooms 1.0 - Page 2

shine771 · 12-06-2008 , 06:09 Re: Chat Rooms 0.9

0.9:
Cleaned code.

Killer12201 · 12-10-2008 , 17:46 Re: Chat Rooms 0.9

Maybe add in a new version where you can add passwords to the chat room and maybe have a room owner? This would work well for server admins to chat and people guessing the name.

shine771 · 12-25-2008 , 15:29 Re: Chat Rooms 0.9

I don't think a password is necessary, because you can name your room like -
aassd11374a -, and no one will guess it's name. Owner thing sounds great until, everyone in the room disconnects, then someone who disconnected connects again, and he's the new owner. So..

Someone test it, and tell us if it works or not.

Halo Mod 4Ever · 01-11-2009 , 19:22 Re: Chat Rooms 0.9

i like it

shine771 · 01-12-2009 , 13:56 Re: Chat Rooms 0.9

You could test it, and confirm that it works..

shine771 · 01-27-2009 , 13:14 Re: Chat Rooms 0.9

Anyone? Test? Please... :/

**Hawk552** · 02-05-2009 , 22:27 Re: Chat Rooms 0.9

There are a few mistakes and optimizations that can be made, however it is acceptable.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approved.

**Hawk552** · 02-06-2009 , 10:52 Re: Chat Rooms 0.9

Changes have been requested via PM.

Consider tagging your global variables with g_, p_ or some variant of those (depending on whether they're pointers, globals, etc.)

Indent your code some more and add some whitespace. Also, I generally frown upon this style:

Code:

public plugin_init() {
    register_plugin("Chat Rooms","0.8","Sh!nE")

As opposed to:

Code:

public plugin_init() 
{
    register_plugin("Chat Rooms","0.8","Sh!nE")

Code:

new info[33],temp[192]

Make this static or global.

Code:

new players[32],num;get_players(players,num)

This is very bad form. Get rid of the semicolon and add a return.

Code:

format(player_chatroom[id],32,"")

Use this instead:

Code:

player_chatroom[id][0] = 0

Code:

stock get_user_chatroom(id) {

Read my article on stocks. Also, this name is not descriptive. You should consider calling it something like get_user_chatroom_index().

Code:

color_print(id,text[]) {
    message_begin(MSG_ONE,msg_say,{0,0,0},id)
    write_byte(id)
    write_string(text)
    message_end()
}

Use MSG_ONE_UNRELIABLE and consider replacing {0,0,0} with _.

Code:

    onoff = register_cvar("amx_chatrooms","1")
    dead_chat = register_cvar("amx_cr_deadchat","1")
    min_to_open = register_cvar("amx_cr_min_open","2")
    green_text = register_cvar("amx_cr_greentext","1")

Consider unifying your cvar names so they all have a certain prefix.

All in all, this plugin is not bad. It's difficult to read but for the most part it's relatively functional.

shine771 · 02-06-2009 , 11:39 Re: Chat Rooms 1.0

Thanks.
The only thing that i wont change is:

Quote:

funcion() {
}

with

Quote:

function()
{
}

**Hawk552** · 02-06-2009 , 11:44 Re: Chat Rooms 1.0

Sorry, I just realized I meant to approve this in the first place.

Approved now.