[claudiuhks]

PHP Code:

public client_disconnect( iClient )
{
  static cName[ 32 ], cSteam[ 26 ], cIP[ 26 ];
  get_user_name( iClient, cName, 32 );
  get_user_authid( iClient, cSteam, 26 );
  get_user_ip( iClient, cIP, 26, 1 );

  static cQuery[ 512 ];
  formatex( cQuery, 512, "INSERT INTO bans ( name, steam, ip ) VALUES ( '%s', '%s', '%s' )", cName, cSteam, cIP );
  SQL_ThreadQuery( g_hSQLTuple, "SQLEmptyAction", cQuery );
} 


Is it too hard?

[Bugsy]

Originally Posted by claudiuhks PHP Code: public client_disconnect( iClient ) {   static cName[ 32 ], cSteam[ 26 ], cIP[ 26 ];   get_user_name( iClient, cName, 32 );   get_user_authid( iClient, cSteam, 26 );   get_user_ip( iClient, cIP, 26, 1 );   static cQuery[ 512 ];   formatex( cQuery, 512, "INSERT INTO bans ( name, steam, ip ) VALUES ( '%s', '%s', '%s' )", cName, cSteam, cIP );   SQL_ThreadQuery( g_hSQLTuple, "SQLEmptyAction", cQuery ); }  Is it too hard?

You should not call natives on a player at client_disconnect() because there are times when it is called and the player is already gone, which could cause the plugin to error. You may not see this in testing, but there is a chance of it happening so you should avoid it. Also, use charsmax() in your natives or atleast use size-1 to give room for the null char.

PHP Code:

const MAX_PLAYERS = 32;

new g_szAuthID[ MAX_PLAYERS + 1 ][ 35 ];

public client_putinserver( id )
{
    get_user_authid( id , g_szAuthID[ id ] , charsmax( g_szAuthID[] ) );
}

public client_disconnect( id )
{
    //Add ban for g_szAuthID[ id ]
} 


[Misery]

Anyways, from what I understand, theres actually no way to send the "You have been banned" notice b/c the player is already gone right?

I know I can update the db, what I wanted was actually to *make him know*...

[Kreation]

Originally Posted by Misery Anyways, from what I understand, theres actually no way to send the "You have been banned" notice b/c the player is already gone right? I know I can update the db, what I wanted was actually to *make him know*...

If you do what everyone has suggested, if he tries to come back, you can send him a message and he will know he is banned then.

[claudiuhks]

Originally Posted by Bugsy You should not call natives on a player at client_disconnect() because there are times when it is called and the player is already gone, which could cause the plugin to error. You may not see this in testing, but there is a chance of it happening so you should avoid it. Also, use charsmax() in your natives or atleast use size-1 to give room for the null char. PHP Code: const MAX_PLAYERS = 32; new g_szAuthID[ MAX_PLAYERS + 1 ][ 35 ]; public client_putinserver( id ) {     get_user_authid( id , g_szAuthID[ id ] , charsmax( g_szAuthID[] ) ); } public client_disconnect( id ) {     //Add ban for g_szAuthID[ id ] }

I know it's not a good idea to call functions in client_disconnect, but I just gave an example. It's a bad idea just because when changelevel, this forward gets executed maximum 32 times one by one.
Forward client_disconnect is executed before AMX Mod X sets player as disconnected though.

PHP Code:

void C_ClientDisconnect(edict_t *pEntity)
{
    CPlayer *pPlayer = GET_PLAYER_POINTER(pEntity);
    if (pPlayer->initialized)
        executeForwards(FF_ClientDisconnect, static_cast<cell>(pPlayer->index));

    if (pPlayer->ingame)
    {
        --g_players_num;
    }
    pPlayer->Disconnect();

    RETURN_META(MRES_IGNORED);
} 


[^SmileY]

Use an TrieGetCell() function to use witch this

[hornet]

Originally Posted by ^SmileY Use an TrieGetCell() function to use witch this

What would you need that for?

[^SmileY]

To save an steamids and names to use witch a ban command..

[hornet]

All you need for that is a simple array.

[Bugsy]

Originally Posted by claudiuhks Forward client_disconnect is executed before AMX Mod X sets player as disconnected though. PHP Code: void C_ClientDisconnect(edict_t *pEntity) {     CPlayer *pPlayer = GET_PLAYER_POINTER(pEntity);     if (pPlayer->initialized)         executeForwards(FF_ClientDisconnect, static_cast<cell>(pPlayer->index));     if (pPlayer->ingame)     {         --g_players_num;     }     pPlayer->Disconnect();     RETURN_META(MRES_IGNORED); }

Which is why it usually works without error. But enter a game and then kill the hl.exe process (for example purposes) and about 30 seconds later your player will timeout and there will be no player to call the natives on when client_disconnect() is called.