[grimvh2]

Like the idea

[Exolent[jNr]]

1. I suggest using client_putinserver() instead of client_connect().
Sometimes, a client does not connect for a few moments later due to server downloads or slow connection between the client and the server.


2. You forgot to check if the command "amx_autoc_load_config" user has access.
If the cvar is enabled, anyone can use the command.


3. Instead of get_playersnum(), I suggest a global variable counting each client as they [dis]connect.
That way, 1 less native and same reason as #1.


4. Inside write_to_config(), you open a file.
But, if something goes wrong, such as player asks for the "guide" or some arguments are incorrect, the file is never closed.
That will cause issues with file handling later on.


5. 256 is an unnecessary length for a filename that only reaches the configs directory:

123456789012345678901234567890123456789
addons/amxmodx/configs/auto_change.ini

That's 38 characters.

new filename[39];

[DruGzOG]

Works Fine on my test server

[Exolent[jNr]]

I'll give 48 more hours after this post (5 days after my last post of fixes) for those fixes to be implemented, or this will be unapproved until fixed.

[Styles]

Approved! if fixed like exolent said!

[Exolent[jNr]]

Wasn't updated. Unapproved until fixed.

[ConnorMcLeod]

Originally Posted by Exolent[jNr] 5. 256 is an unnecessary length for a filename that only reaches the configs directory: 123456789012345678901234567890123456789 addons/amxmodx/configs/auto_change.ini That's 38 characters. new filename[39];

I would let at least 64, as the path is not hardcoded and as configs folder can be something else than addons/amxmodx/configs/

[Exolent[jNr]]

Nevertheless, 200 is unnecessary.

[Dores]

Texnux's last post at: 30-08-08.
This post at: 10-10-08.

I would guess he is no longer supporting this plugin, or he took a long vacation.


P.S: Congrats on "Excellent" karma, Exo...
Should be "Exolent" (but you've already heard this joke).

[Texnux]

Originally Posted by Exolent[jNr] 1. I suggest using client_putinserver() instead of client_connect(). Sometimes, a client does not connect for a few moments later due to server downloads or slow connection between the client and the server.

Done.

Originally Posted by Exolent[jNr] 2. You forgot to check if the command "amx_autoc_load_config" user has access. If the cvar is enabled, anyone can use the command.

Fixed.

Originally Posted by Exolent[jNr] 3. Instead of get_playersnum(), I suggest a global variable counting each client as they [dis]connect. That way, 1 less native and same reason as #1.

Done.

Originally Posted by Exolent[jNr] 4. Inside write_to_config(), you open a file. But, if something goes wrong, such as player asks for the "guide" or some arguments are incorrect, the file is never closed. That will cause issues with file handling later on.

Fixed.

Originally Posted by Exolent[jNr] 5. 256 is an unnecessary length for a filename that only reaches the configs directory: 123456789012345678901234567890123456789 addons/amxmodx/configs/auto_change.ini That's 38 characters. new filename[39];

Reduced to 64 if some one wants to change the direction, wasn't supposed to be that big anyway, c+p error

Originally Posted by Dores Texnux's last post at: 30-08-08. This post at: 10-10-08. I would guess he is no longer supporting this plugin, or he took a long vacation.

Long story short, all my steam files got wiped, including all my works or several plugins, so I took a break from steam all together, but I'm back now.


New version, 1.1.2, only bug fixed, but very important!

- Texnux