[meTaLiCroSS]

Originally Posted by Neeeeeeeeeel.- You are right Btw the output will still be 0.000000

get_gametime would not show the difference, it has nothing to do with unixtime or anything else, use Float:engfunc(EngFunc_Time)

[Arkshine]

Your code is quite horrible, unsafe and with mistakes, and talking about speed is irrelevant for such things as most includes uses new file natives too.
I would not recommend people to use this.

[Hirsw0w]

Originally Posted by Arkshine Your code is quite horrible, unsafe and with mistakes, and talking about speed is irrelevant for such things as most includes uses new file natives too. I would not recommend people to use this.

what your minining unsafe? and what the nw file natives? I change all the include for them and improve the speed and more if you can explain yourself more I be happy.

[Strick3n]

Originally Posted by Arkshine Your code is quite horrible, unsafe and with mistakes, and talking about speed is irrelevant for such things as most includes uses new file natives too. I would not recommend people to use this.

trash this shit, this inc is useless as you said, so trash it.
better to use the original file.inc natives.

[Arkshine]

• You pass a buffer size instead of buffer size - 1 -> potential overflow issue.
• There is macro charsmax to use sizeof array - 1, use it.
• Hardcoding limit sucks.
• Calling 2 replace_all with ^r/^n is not needed. Buffer should not contain that.
• Calling write_file in a loop is really bad. Did you check its source code? This native is about openinp/closing/buffering a file.
• This feels unnecessary to call file_exists when you can check with fopen below.
• new tmpres[128]: This is rather small buffer.
• You read lines with a buffer of 128 and you write line with a buffer of 150, logic?
• What about if file exists but can't be opened?
• Always trim your buffer as it can contains spaces.
• No point to use strlen when you can get length from fgets return value.
• Why this does assume format will be "something = value"?
• Checking if an array is empty with strlen is overkill, just check [0].
• Getting a file size, file_size should do the same.

You have already better API around here, which are more complete, tested, and safe.
Speed doesn't matter, you are not going to call such API 10000 times anyway, but yours is really poorly coded.

[Neeeeeeeeeel.-]

Originally Posted by meTaLiCroSS get_gametime would not show the difference, it has nothing to do with unixtime or anything else, use Float:engfunc(EngFunc_Time)

As far as I remember, get_gametime returns a float. If it does my code works. When I mentioned unixtime o.O

For example:

PHP Code:

new Float:startTime = get_gametime(); // let's say get_gametime() it's equal to 25.634
// do stuff
new Float:endTime = get_gametime(); // let's say that endTime it's equal to 28.453
new Float:doStuffTime = endTime-startTime;
//doStuffTime will be "do stuff" execute delay, in this case: 2.819 


PS: My theory will be shit if get_gametime returns an int

[Strick3n]

Originally Posted by Arkshine You pass a buffer size instead of buffer size - 1 -> potential overflow issue. There is macro charsmax to use sizeof array - 1, use it. Hardcoding limit sucks. Calling 2 replace_all with ^r/^n is not needed. Buffer should not contain that. Calling write_file in a loop is really bad. Did you check its source code? This native is about openinp/closing/buffering a file. This feels unnecessary to call file_exists when you can check with fopen below. new tmpres[128]: This is rather small buffer. You read lines with a buffer of 128 and you write line with a buffer of 150, logic? What about if file exists but can't be opened? Always trim your buffer as it can contains spaces. No point to use strlen when you can get length from fgets return value. Why this does assume format will be "something = value"? Checking if an array is empty with strlen is overkill, just check [0]. Getting a file size, file_size should do the same. You have already better API around here, which are more complete, tested, and safe. Speed doesn't matter, you are not going to call such API 10000 times anyway, but yours is really poorly coded.

Why you don't trash it yet?

[meTaLiCroSS]

Originally Posted by Neeeeeeeeeel.- As far as I remember, get_gametime returns a float. If it does my code works. When I mentioned unixtime o.O For example: PHP Code: new Float:startTime = get_gametime(); // let's say get_gametime() it's equal to 25.634 // do stuff new Float:endTime = get_gametime(); // let's say that endTime it's equal to 28.453 new Float:doStuffTime = endTime-startTime; //doStuffTime will be "do stuff" execute delay, in this case: 2.819  PS: My theory will be shit if get_gametime returns an int

Do you know what it returns get_gametime() ? It's a member of a global variable which changes on specific functions on the engine, you can cache get_gametime() value and execute billion of loops, and at the end, get_gametime() will return the same number as the cached above.

engfunc(EngFunc_Time) (Sys_FloatTime()) returns the seconds elapsed since the game started, and it's like using get_systime() but in float.

If being too easy as you said, why do you think that this guy created this?

[Black Rose]

Originally Posted by meTaLiCroSS Do you know what it returns get_gametime() ? It's a member of a global variable which changes on specific functions on the engine, you can cache get_gametime() value and execute billion of loops, and at the end, get_gametime() will return the same number as the cached above. engfunc(EngFunc_Time) (Sys_FloatTime()) returns the seconds elapsed since the game started, and it's like using get_systime() but in float. If being too easy as you said, why do you think that this guy created this?

Or use tickcount().

[meTaLiCroSS]

Originally Posted by Black Rose Or use tickcount().

I was going to edit it, but I knew that you'll post it, I saw it on your test plugin of your A* Pathfinder plugin