[Fr33m@n]

Originally Posted by hleV It should be 32. Now it can't be used like this: PHP Code: new players[MAX_PLAYERS], num; get_players(players, num);  Personally I've always used MAX_PLAYERS + 1 for player ID arrays. Anyway, regarding the topic, the easiest way to remove the warning would be to undefine MAX_PLAYERS before it is defined in the plugin source file.

It was never supposed to be used like this for this kind of array, it have been removed in amxmodx dev because it's a bad usage.

33 is fine imo.

Maybe we should do a poll...

[OvidiuS]

Originally Posted by Fr33m@n It was never supposed to be used like this for this kind of array, it have been removed in amxmodx dev because it's a bad usage. 33 is fine imo. Maybe we should do a poll...

I agree, we should have a poll

[Arkshine]

Don't think a poll is necessary. It has been always a define of 32, sometimes 33 for convenience. If we officially define the max players, it should be the technical limit as '32' can be used for others places than defining a player's array. It has been always this way, I'm not sure disturbing this habit is a smart move. Adding +1 is not necessary an issue, and it gives an explicit meaning.

Having 33 is not wrong too, that's said, but for AMXX/HL1 context probably more appropriate to keep 32.

I guess i will change that again.

[Bugsy]

I don't think MAXPLAYERS sole use is for sizing an array, it can be used for other things and having it incorrectly set to 33 is wrong. Plugins have been scripted for years now with it at 32, why change it now to 33? My opinion is to keep it at 32, if people have a problem with using '+ 1' in their arrays then maybe create a separate constant for array sizing purposes?

Something like this would be ok:

PHP Code:

const MAXPLAYERS = 32
const MAXPLAYERS_ARRAY = MAXPLAYERS + 1 


[Arkshine]

https://github.com/alliedmodders/amxmodx/pull/192

I hope people won't change mind after that.

[fysiks]

Defininig MAX_PLAYERS as 33 is 100% wrong! This is not subjective. MAX_PLAYERS should be defined based on fact which is 32. If people have a problem with adding 1 to get an over-sized array that makes it more convenient for their plugin then that is not AMX Mod X's problem. They can either learn to do it or start subtracting 1 from every player ID. We all know which one is better.

[Arkshine]

Don't be that mad, you are going to make me cry. 33 was not necessary wrong, but in the context was not the best to do.

[Bugsy]

I'm with fysiks on this, it's 100% wrong at 33. It's only correct when used to size an array, for every other purpose the value is wrong. The constant was created to hold the max number of players that the server can handle (hence the name MAXPLAYERS), it was not created for the sole purpose of sizing an array containing player ids.

[Arkshine]

Please kill Nextra then, I have proof:

[19:51:41] Nextra ツ: and sourcemod defines maxplayers as 66 [19:51:42] Nextra ツ: 65* [19:52:10] Arkshine: And? [19:52:18] Nextra ツ: it would have to be 33 for us then [19:52:19] Nextra ツ: not 32 [19:52:51] Arkshine: Sounds weird to do that [19:53:50] Nextra ツ: yo mom is weird [19:54:08] Nextra ツ: you can just do new arr[MAXPLAYERS] [19:54:13] Nextra ツ: instead of MAXPLAYERS + 1

But he confused, SM actually still does +1 ; I guess 64 -> 65 has been changed to consider 0 (sourceTV), at least something like that.

[hleV]

I may be wrong, but I believe there's an extra slot for SourceTV.