[Lebson506th]

What i see just glancing at it is that you are using ServerCommand for say still. (PrintToChatAll is a good alternative)

Also, you still have the 2 second repeating timer that goes on forever.

(As FS suggested, only start it when the game has been started and stop the timer when the game stops)


Also, if you are going to comment every line, it would be a good idea to put blank lines in between blocks of code for readability.


All-in-all a good improvement. Just a little more to go =)

[sniperkills]

hi when in menu 1 for load loaded server crashes

[FlyingMongoose]

Originally Posted by Dillxn Woohoo! Major updates! I really appreciate you guys for helping me out and encouraging me to continue working hard on my first sourcemod plugin! I will still update it (add features, fix bugs), but I think this is a great leap for version 1.2!

We, the developer community like to see quality plugins come from the newcomers, and it delights us to see new concepts and ideas coming from them as well. We don't not approve because we're sticklers and jerks, but because we wish to see the best quality in which the new developers can produce. (We know that a lot of new developers out there have great potential, they just need a little shove in the right direction ;) )

[Dillxn]

Originally Posted by FlyingMongoose We, the developer community like to see quality plugins come from the newcomers, and it delights us to see new concepts and ideas coming from them as well. We don't not approve because we're sticklers and jerks, but because we wish to see the best quality in which the new developers can produce. (We know that a lot of new developers out there have great potential, they just need a little shove in the right direction ;) )

Woah woah woah, I'm confused. Are you saying that it will be un-approved? I never accused anyone of being a stickler or a jerk. I hope I haven't come off the wrong way. Please forgive me if I've done anything to offend anyone. I guess what I'm trying to say is, I don't see where you're coming from. And yes, that sentence about the shove is certainly true for me.

Thanks.


PS:
the PrintToChatAll isn't working (it's crashing the server), so I really don't see the downside of using "say" command...

Also, sorry for my obsessive commenting.

Originally Posted by sniperkills hi when in menu 1 for load loaded server crashes

That doesn't make any sense to me. Please rephrase.

[sniperkills]

ok in game when u load it it crashes the server im running sm 1.0.4

[Dillxn]

Originally Posted by sniperkills ok in game when u load it it crashes the server im running sm 1.0.4

That's odd, I'm also running 1.0.4 and It works just fine for me. What are you doing? How can I re-create this?

[FeuerSturm]

Noone said it will be unapproved, it will just not be approved until
you fix up the points that have been stated

P.S.:
PrintToChatAll works fine, is just tried it and replaced all "say" instances
with it.

[FlyingMongoose]

Originally Posted by Dillxn Woah woah woah, I'm confused. Are you saying that it will be un-approved? I never accused anyone of being a stickler or a jerk. I hope I haven't come off the wrong way. Please forgive me if I've done anything to offend anyone. I guess what I'm trying to say is, I don't see where you're coming from. And yes, that sentence about the shove is certainly true for me. Thanks.

I apologize for anything that may have seemed inconsistent in my statement, all I meant was saying that we appreciate and respect those who attempt to further the experience by providing and supporting more plugins (and even sometimes plugins that are not their own). It helps to further the experience. Essentially it's a long way of saying thank you for taking the time to build something that you're willing to share with the community.

Plugins that go unapproved are plugins that are no longer fully supported, no longer updated, no longer managed, etc. Seeing as you're very thoroughly supporting and updating this plugin, I have a feeling it will probably not be going anywhere any time soon.

TBH I'm a bit surprised I haven't seen you on the IRC Channel much (most regular developing plugin authors usually about live on there. But there's nothing wrong with that ;) just a statement.

[sniperkills]

I DONT KNOW MAN IT LOADS UP AND EVERY THING IN THE MENU IN GAME I HIT 1 FOR LOAD & IT CRASHES THE SERVER HMM ITS OK

[Lebson506th]

Caps was not necessary.


@OP: You are saying PrintToChatAll("Hi!"); crashes the server? That shouldn't happen...