[FF2] Freak Fortress 2 1.10.14 Released - Page 121

Wliu · 10-07-2014 , 17:27 Re: Freak Fortress 2 1.10.2 Released

Just fixed bosses dying from sustained damage (eg fire).

sound_first_blood is confirmed working, but it seems like all the other sounds went poof. Will investigate.

No idea what's going on with TF2Items. That'll take some time.

Powerlord · *Last edited by Powerlord; 10-08-2014 at 10:47.*

Quote:

Originally Posted by xXDeathreusXx

And sound hit is supposed to play on DR spies pretty sure, it tries to fool the boss into thinking he killed him

That was changed way back in... 1.7 I think. It used to not play on DR spies before that. So yes, intentional change.

Quote:

Originally Posted by Wliu

No idea what's going on with TF2Items. That'll take some time.

If something's going on with TF2Items, that might explain some issues I'm hearing about in PropHunt as well.

e.g. TF2Items not always blocking items from being given to players. I need to ask the server owners who are seeing this if they see any TF2Items errors in their logs.

friagram · 10-08-2014 , 16:33 Re: Freak Fortress 2 1.10.2 Released

Quote:

Originally Posted by Powerlord

When it's in your inventory it is, but when you right-click to throw it, it does this:

Creates a new item_healthkit_medium
Sets its powerup_model to "models/items/plate.mdl", "models/items/plate_robo_sandwich.mdl", "models/items/plate_sandwich_xmas.mdl", or "models/items/plate_steak.mdl" depending on which Sandvich it is. (Note: The "models/" part may not need to be there... haven't tested it)
Sets the owner to the player who threw it (which prevents them from healing from it).
Spawns the healthkit.

Its all either tf ammo pack for weapon drops, or the standard entities. I think I released a subplugin that blocks pickup through hoocktouch. IIRC changing the team did not work for all entities (tf ammo pack)? But blocking the touch does. Dispenser rubble and the like is the same entity. Those entities should reset each round though, so if changing team works, it is better. For instance, I use arena mode between rounds.. It would be bad if one team can not pick up ammo. Likewise, some bosses need to pick up ammo or health to trigger events... Though I usually just hooktouch the item or spawn a prop.

friagram · *Last edited by friagram; 10-09-2014 at 02:55.*

There is a serious bug with download management in All versions of freak fortress that I'm aware of which causes clients previously connected to a server to fail to download new content upon map change. This is due to the fact that LoadCharacter is being called OnConfigsExecuted. Clients that disconnect from the server on map change, and reconnect, may join before this is called (I think?), which will cause all new content in character packs or newly added bosses (or whatever else) to fail to download.

In my opinion, a mod such as FF2 should not have an option to be "Disabled", since content must be there BEFORE you start the map. Server operators should instead load the plugin or unload it from the /disabled directory. But whatever... The solution is to force that the content is downloaded OnMapStart. If you chose to keep Enabled/Disabled, you should set a boolean that tests if the content was set out onmapstart, and prevent the plugin from going into the enabled state on that map if it wasn't. Regardless, here's the fix that seems to work.

First, we may have the problem of stupid long loads if we chose to precache everything onmapstart. This could drop clients if our server is slow (mabye?). Also, I think steamtools will tank the server if you try to set the game description too early. Anyhow, we can setup downloads and precaching like so (note that my code is gonna be quite a bit different in some places than whatever you are using, though it should be close):

in onpluginstart... add:

Spoiler

Move this to the end of onmapstart, so all of our crap gets added asap:

Spoiler

Modify load character to push precache information into the arrays

Spoiler

PHP Code:


			
public LoadCharacter(const String:character[])
{            
    new String:extensions[][] = {".mdl", ".dx80.vtx", ".dx90.vtx", ".sw.vtx", ".vvd", ".phy"};
    decl String:s[PLATFORM_MAX_PATH];
    BuildPath(Path_SM,s,PLATFORM_MAX_PATH,"configs/freak_fortress_2/%s.cfg",character);
    if (!FileExists(s))
    {
        LogError("Character %s does not exist!",character);
        return;
    }
    BossKV[Specials] = CreateKeyValues("character");
    FileToKeyValues(BossKV[Specials], s);
    
    decl String:s2[PLATFORM_MAX_PATH];
    decl String:s3[64];
    KvSetString(BossKV[Specials], "filename", character);
    KvGetString(BossKV[Specials], "name", s, PLATFORM_MAX_PATH);

#if defined DEBUG_DOWNLOAD
                LogToFile(logfile, "Character: %s", s);
#endif

    bBlockVoice[Specials] = bool:KvGetNum(BossKV[Specials],"sound_block_vo",0);
    BossSpeed[Specials] = KvGetFloat(BossKV[Specials],"maxspeed",340.0);
    BossRageDamage[Specials] = KvGetFloat(BossKV[Specials],"ragedamage",1900.0);
    KvGotoFirstSubKey(BossKV[Specials]);
    decl i,is;
    BuildPath(Path_SM,s,PLATFORM_MAX_PATH,"configs/freak_fortress_2/characters.cfg");
    while (KvGotoNextKey(BossKV[Specials]))
    {    
        KvGetSectionName(BossKV[Specials], s3, 64);
        if (!strcmp(s3,"download"))
        {
            for(i = 1; ; i++)
            {
                IntToString(i,s2,4);
                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                if (!s[0])
                break;
                AddFileToDownloadsTable(s);

#if defined DEBUG_DOWNLOAD
                LogToFile(logfile, "[%s] %d - %s",s3, i, s);
#endif
            }
        }
        else if (!strcmp(s3,"mod_download"))
        {    
            for(i = 1; ; i++)
            {
                IntToString(i,s2,4);
                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                if (!s[0])
                break;
                for (is = 0;  is < sizeof(extensions);  is++)
                {
                    FormatEx(s2,PLATFORM_MAX_PATH,"%s%s",s,extensions[is]);
                    AddFileToDownloadsTable(s2);

#if defined DEBUG_DOWNLOAD
                    LogToFile(logfile, "[%s] %d - %s",s3, i, s2);
#endif

                    // precache at map start
                    if(is == 0)
                    {
                        //PrecacheModel(s2, true);
                        if(FindStringInArray(gh_precache_models, s) == -1)
                        {
                            PushArrayString(gh_precache_models, s);
                        }
                    }
                }
            }
        }
        else if (!strcmp(s3,"mat_download"))
        {    
            for(i = 1; ; i++)
            {
                IntToString(i,s2,4);
                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                if (!s[0])
                break;
                FormatEx(s2,PLATFORM_MAX_PATH,"%s.vtf",s);
                AddFileToDownloadsTable(s2);

#if defined DEBUG_DOWNLOAD
                LogToFile(logfile, "[%s] %d - %s",s3, i, s2);
#endif

                FormatEx(s2,PLATFORM_MAX_PATH,"%s.vmt",s);
                AddFileToDownloadsTable(s2);

#if defined DEBUG_DOWNLOAD
                LogToFile(logfile, "[%s] %d - %s",s3, i, s2);
#endif
            }
        }
        // precache at map start..
        else if (!strcmp(s3,"mod_precache"))
        {    
            for(i = 1; ; i++)
            {
                IntToString(i,s2,4);
                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                if (!s[0])
                break;
                //PrecacheModel(s, true);
                if(FindStringInArray(gh_precache_models, s) == -1)
                {
                    PushArrayString(gh_precache_models, s);
                }
            }
        }
        else if (!StrContains(s3,"sound_"))
        {
            if(!(StrEqual(s3[7], "bgm")))       // do not precache BGMs (I don't use this anymore)
            {
                for(i = 1; ; i++)
                {
                    IntToString(i,s2,4);
                    KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                    if (!s[0])
                    break;
                    //PrecacheSound(s, true);
                    if(FindStringInArray(gh_precache_sounds, s) == -1)
                    {
                        PushArrayString(gh_precache_sounds, s);
                    }
                }
            }
        }
        else if (!strcmp(s3,"catch_phrase"))
        {    
            for(i = 1; ; i++)
            {
                IntToString(i,s2,4);
                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);
                if (!s[0])
                break;
                //PrecacheSound(s, true);
                if(FindStringInArray(gh_precache_sounds, s) == -1)
                {
                    PushArrayString(gh_precache_sounds, s);
                }
            }
        }
    }
    Specials++;
}

Edit OnConfigsExecuted to actually do the precaching:

Spoiler

PHP Code:


			
public OnConfigsExecuted()
{
    SetConVarString(FindConVar("ff2_version"), ff2versiontitles[maxversion]);
    Announce = GetConVarFloat(cvarAnnounce);
    PointType = GetConVarInt(cvarPointType);
    PointDelay = GetConVarInt(cvarPointDelay);
    if (PointDelay < 0) PointDelay *= -1;
    AliveToEnable = GetConVarInt(cvarAliveToEnable);
    circuitStun = GetConVarFloat(cvarCircuitStun);


#if defined _steamtools_included
    if (g_bSteamTools)
    {
        Steam_SetGameDescription(GAMEDESC);
    }
#endif

    tf_arena_use_queue = GetConVarInt(FindConVar("tf_arena_use_queue"));
    mp_teams_unbalance_limit = GetConVarInt(FindConVar("mp_teams_unbalance_limit"));
    tf_arena_first_blood = GetConVarInt(FindConVar("tf_arena_first_blood"));
    mp_forcecamera = GetConVarInt(FindConVar("mp_forcecamera"));
    tf_scout_hype_pep_max = GetConVarFloat(FindConVar("tf_scout_hype_pep_max"));
    
    SetConVarInt(FindConVar("tf_arena_use_queue"),0);
    SetConVarInt(FindConVar("mp_teams_unbalance_limit"),0);
    SetConVarInt(FindConVar("tf_arena_first_blood"),0);
    SetConVarInt(FindConVar("mp_forcecamera"),0);
    SetConVarFloat(FindConVar("tf_scout_hype_pep_max"), 100.0);

    Enabled = true;
    Enabled2 = true;
    
    new Float:time = Announce;
    if (time > 1.0)
    {
        CreateTimer(time, Timer_Announce,_, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
    }
    
    CheckToChangeMapDoors();

    EnableSubPlugins();
    isSubPluginsEnabled=false;
    
    bMedieval = FindEntityByClassname(-1, "tf_logic_medieval")!= -1 || bool:GetConVarInt(FindConVar("tf_medieval"));
    
    // For healthbar
    FindHealthBar();

    decl String:buffer[PLATFORM_MAX_PATH];
    for(new i = GetArraySize(gh_precache_models) - 1; i>=0; i--)
    {
        GetArrayString(gh_precache_models, i, buffer, PLATFORM_MAX_PATH);
        PrecacheModel(buffer, true);
    }
    for(new i = GetArraySize(gh_precache_sounds) - 1; i>=0; i--)
    {
        GetArrayString(gh_precache_sounds, i, buffer, PLATFORM_MAX_PATH);
        PrecacheSound(buffer, true);
    }
    ClearArray(gh_precache_models);
    ClearArray(gh_precache_sounds);
}

M76030 · 10-09-2014 , 05:55 Re: Freak Fortress 2 1.10.2 Released

so, while i was playing on my private server
i found out that both sound death and sound kspree arent working
i looked into my console but no real error was there

WildCard65 · *Last edited by WildCard65; 10-09-2014 at 06:46.*

Quote:

Originally Posted by friagram

In my opinion, a mod such as FF2 should not have an option to be "Disabled", since content must be there BEFORE you start the map. Server operators should instead load the plugin or unload it from the /disabled directory.

See: https://github.com/50DKP/FF2-Official/issues/114

Quote:

Originally Posted by 50Wliu

Do not reload FF2

Wliu · 10-09-2014 , 08:58 Re: Freak Fortress 2 1.10.2 Released

Quote:

Originally Posted by friagram

*snip*

v2. Hopefully.

Powerlord · 10-09-2014 , 09:48 Re: Freak Fortress 2 1.10.2 Released

Quote:

Originally Posted by friagram

There is a serious bug with download management in All versions of freak fortress that I'm aware of which causes clients previously connected to a server to fail to download new content upon map change. This is due to the fact that LoadCharacter is being called OnConfigsExecuted. Clients that disconnect from the server on map change, and reconnect, may join before this is called (I think?), which will cause all new content in character packs or newly added bosses (or whatever else) to fail to download.

In my opinion, a mod such as FF2 should not have an option to be "Disabled", since content must be there BEFORE you start the map. Server operators should instead load the plugin or unload it from the /disabled directory. But whatever... The solution is to force that the content is downloaded OnMapStart. If you chose to keep Enabled/Disabled, you should set a boolean that tests if the content was set out onmapstart, and prevent the plugin from going into the enabled state on that map if it wasn't. Regardless, here's the fix that seems to work.

First, we may have the problem of stupid long loads if we chose to precache everything onmapstart. This could drop clients if our server is slow (mabye?). Also, I think steamtools will tank the server if you try to set the game description too early. Anyhow, we can setup downloads and precaching like so (note that my code is gonna be quite a bit different in some places than whatever you are using, though it should be close):

in onpluginstart... add:

Spoiler

Move this to the end of onmapstart, so all of our crap gets added asap:

Spoiler

Modify load character to push precache information into the arrays

Spoiler

PHP Code:


			
public LoadCharacter(const String:character[])

{            

    new String:extensions[][] = {".mdl", ".dx80.vtx", ".dx90.vtx", ".sw.vtx", ".vvd", ".phy"};

    decl String:s[PLATFORM_MAX_PATH];

    BuildPath(Path_SM,s,PLATFORM_MAX_PATH,"configs/freak_fortress_2/%s.cfg",character);

    if (!FileExists(s))

    {

        LogError("Character %s does not exist!",character);

        return;

    }

    BossKV[Specials] = CreateKeyValues("character");

    FileToKeyValues(BossKV[Specials], s);

    

    decl String:s2[PLATFORM_MAX_PATH];

    decl String:s3[64];

    KvSetString(BossKV[Specials], "filename", character);

    KvGetString(BossKV[Specials], "name", s, PLATFORM_MAX_PATH);



#if defined DEBUG_DOWNLOAD

                LogToFile(logfile, "Character: %s", s);

#endif



    bBlockVoice[Specials] = bool:KvGetNum(BossKV[Specials],"sound_block_vo",0);

    BossSpeed[Specials] = KvGetFloat(BossKV[Specials],"maxspeed",340.0);

    BossRageDamage[Specials] = KvGetFloat(BossKV[Specials],"ragedamage",1900.0);

    KvGotoFirstSubKey(BossKV[Specials]);

    decl i,is;

    BuildPath(Path_SM,s,PLATFORM_MAX_PATH,"configs/freak_fortress_2/characters.cfg");

    while (KvGotoNextKey(BossKV[Specials]))

    {    

        KvGetSectionName(BossKV[Specials], s3, 64);

        if (!strcmp(s3,"download"))

        {

            for(i = 1; ; i++)

            {

                IntToString(i,s2,4);

                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                if (!s[0])

                break;

                AddFileToDownloadsTable(s);



#if defined DEBUG_DOWNLOAD

                LogToFile(logfile, "[%s] %d - %s",s3, i, s);

#endif

            }

        }

        else if (!strcmp(s3,"mod_download"))

        {    

            for(i = 1; ; i++)

            {

                IntToString(i,s2,4);

                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                if (!s[0])

                break;

                for (is = 0;  is < sizeof(extensions);  is++)

                {

                    FormatEx(s2,PLATFORM_MAX_PATH,"%s%s",s,extensions[is]);

                    AddFileToDownloadsTable(s2);



#if defined DEBUG_DOWNLOAD

                    LogToFile(logfile, "[%s] %d - %s",s3, i, s2);

#endif



                    // precache at map start

                    if(is == 0)

                    {

                        //PrecacheModel(s2, true);

                        if(FindStringInArray(gh_precache_models, s) == -1)

                        {

                            PushArrayString(gh_precache_models, s);

                        }

                    }

                }

            }

        }

        else if (!strcmp(s3,"mat_download"))

        {    

            for(i = 1; ; i++)

            {

                IntToString(i,s2,4);

                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                if (!s[0])

                break;

                FormatEx(s2,PLATFORM_MAX_PATH,"%s.vtf",s);

                AddFileToDownloadsTable(s2);



#if defined DEBUG_DOWNLOAD

                LogToFile(logfile, "[%s] %d - %s",s3, i, s2);

#endif



                FormatEx(s2,PLATFORM_MAX_PATH,"%s.vmt",s);

                AddFileToDownloadsTable(s2);



#if defined DEBUG_DOWNLOAD

                LogToFile(logfile, "[%s] %d - %s",s3, i, s2);

#endif

            }

        }

        // precache at map start..

        else if (!strcmp(s3,"mod_precache"))

        {    

            for(i = 1; ; i++)

            {

                IntToString(i,s2,4);

                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                if (!s[0])

                break;

                //PrecacheModel(s, true);

                if(FindStringInArray(gh_precache_models, s) == -1)

                {

                    PushArrayString(gh_precache_models, s);

                }

            }

        }

        else if (!StrContains(s3,"sound_"))

        {

            if(!(StrEqual(s3[7], "bgm")))       // do not precache BGMs (I don't use this anymore)

            {

                for(i = 1; ; i++)

                {

                    IntToString(i,s2,4);

                    KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                    if (!s[0])

                    break;

                    //PrecacheSound(s, true);

                    if(FindStringInArray(gh_precache_sounds, s) == -1)

                    {

                        PushArrayString(gh_precache_sounds, s);

                    }

                }

            }

        }

        else if (!strcmp(s3,"catch_phrase"))

        {    

            for(i = 1; ; i++)

            {

                IntToString(i,s2,4);

                KvGetString(BossKV[Specials], s2, s, PLATFORM_MAX_PATH);

                if (!s[0])

                break;

                //PrecacheSound(s, true);

                if(FindStringInArray(gh_precache_sounds, s) == -1)

                {

                    PushArrayString(gh_precache_sounds, s);

                }

            }

        }

    }

    Specials++;

}

Edit OnConfigsExecuted to actually do the precaching:

Spoiler

PHP Code:


			
public OnConfigsExecuted()

{

    SetConVarString(FindConVar("ff2_version"), ff2versiontitles[maxversion]);

    Announce = GetConVarFloat(cvarAnnounce);

    PointType = GetConVarInt(cvarPointType);

    PointDelay = GetConVarInt(cvarPointDelay);

    if (PointDelay < 0) PointDelay *= -1;

    AliveToEnable = GetConVarInt(cvarAliveToEnable);

    circuitStun = GetConVarFloat(cvarCircuitStun);





#if defined _steamtools_included

    if (g_bSteamTools)

    {

        Steam_SetGameDescription(GAMEDESC);

    }

#endif



    tf_arena_use_queue = GetConVarInt(FindConVar("tf_arena_use_queue"));

    mp_teams_unbalance_limit = GetConVarInt(FindConVar("mp_teams_unbalance_limit"));

    tf_arena_first_blood = GetConVarInt(FindConVar("tf_arena_first_blood"));

    mp_forcecamera = GetConVarInt(FindConVar("mp_forcecamera"));

    tf_scout_hype_pep_max = GetConVarFloat(FindConVar("tf_scout_hype_pep_max"));

    

    SetConVarInt(FindConVar("tf_arena_use_queue"),0);

    SetConVarInt(FindConVar("mp_teams_unbalance_limit"),0);

    SetConVarInt(FindConVar("tf_arena_first_blood"),0);

    SetConVarInt(FindConVar("mp_forcecamera"),0);

    SetConVarFloat(FindConVar("tf_scout_hype_pep_max"), 100.0);



    Enabled = true;

    Enabled2 = true;

    

    new Float:time = Announce;

    if (time > 1.0)

    {

        CreateTimer(time, Timer_Announce,_, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);

    }

    

    CheckToChangeMapDoors();



    EnableSubPlugins();

    isSubPluginsEnabled=false;

    

    bMedieval = FindEntityByClassname(-1, "tf_logic_medieval")!= -1 || bool:GetConVarInt(FindConVar("tf_medieval"));

    

    // For healthbar

    FindHealthBar();



    decl String:buffer[PLATFORM_MAX_PATH];

    for(new i = GetArraySize(gh_precache_models) - 1; i>=0; i--)

    {

        GetArrayString(gh_precache_models, i, buffer, PLATFORM_MAX_PATH);

        PrecacheModel(buffer, true);

    }

    for(new i = GetArraySize(gh_precache_sounds) - 1; i>=0; i--)

    {

        GetArrayString(gh_precache_sounds, i, buffer, PLATFORM_MAX_PATH);

        PrecacheSound(buffer, true);

    }

    ClearArray(gh_precache_models);

    ClearArray(gh_precache_sounds);

}

That strikes me as a serious bug in either the game server or SourceMod if OnConfigsExecuted is executing after clients start connecting. OnMapStart executes prior to server.cfg (let alone other configs), so all the settings are still what they were set to at the end of the previous map.

xXDeathreusXx · 10-09-2014 , 16:16 Re: Freak Fortress 2 1.10.2 Released

Quote:

Originally Posted by Powerlord

That strikes me as a serious bug in either the game server or SourceMod if OnConfigsExecuted is executing after clients start connecting. OnMapStart executes prior to server.cfg (let alone other configs), so all the settings are still what they were set to at the end of the previous map.

And it was my understanding that OnConfigsExecuted is called after OnMapStart, and is where you put things to load that normally would be overwritten or not effected if called OnMapStart

But then again, that was my understanding a year ago, and I haven't done any research since.

Wliu · *Last edited by Wliu; 10-09-2014 at 18:18.*

I mean, a simple way to check would just be to PrintToServer whenever OMS and OCE were called. I'll do that tomorrow.

Updates since the last beta (not posting a new one yet):
-Added cvar 'ff2_countdown_result'. 0 is default behavior (suicide), 1 sets a stalemate. Requested by Shadow.
-Fixed multi-life bosses dying from sustained (eg fire) damage.
-Used the better(TM) way of preventing bosses from picking up ammo/health, and added flags to override this behavior. Taken from friagram's 'pickup.sp' and Powerlord's rewrite.
-Re-formatted some configs (and also updated Gentlespy's Ambassador attributes/fixed "sound_win" not working). The default ones now all use forward slashes and no longer precache BGMs.
-'Fixed' "catch_phrase" not being called if "sound_block_vo" was set to 1. This should make SBV less misleading.

No new features are planned to be added into 1.10.3. The only bugs that I'm aware of currently are sounds not working and TF2Items errors.