[ot_207]

Originally Posted by Exolent[jNr] Why not do this: public plugin_init() {     RegisterHam(Ham_TakeDamage, "player", "FwdPlayerDamage"); } public FwdPlayerDamage(client, inflictor, attacker, Float:damage, damagebits) {     if( fm_is_ent_classname(inflictor, "grenade") && cs_get_weapon_id(inflictor) == CSW_HEGRENADE )     {         // damage from grenade     } }

I have a question related to your code.
Why do you need to do this check?

PHP Code:

cs_get_weapon_id(inflictor) == CSW_HEGRENADE 


Shouldn't this be enough?

public plugin_init()
{
    RegisterHam(Ham_TakeDamage, "player", "FwdPlayerDamage");
}

public FwdPlayerDamage(client, inflictor, attacker, Float:damage, damagebits)
{
    if( fm_is_ent_classname(inflictor, "grenade") )
    {
        // damage from grenade
    }
}

[BOYSplayCS]

I believe(but probably not right) that if you don't check it, then any damage from any grenade will be counted. You can damage someone with a flash/smoke.

He's checking that because he wants to make sure it's a HE grenade.

Although, I may be wrong.

[Dores]

BOYSplayCS wanted to specifically hook HE damage, so as I said in my last post - cs_get_weapon_id() is enough.

[Bugsy]

My above code does exactly that, try it. It requires no additional function calls.

[Arkshine]

DMG_GRENADE is enough ; what's wrong whit that ?

[ot_207]

Originally Posted by ot_207 I have a question related to your code. Why do you need to do this check? PHP Code: cs_get_weapon_id(inflictor) == CSW_HEGRENADE  Shouldn't this be enough?[/pawn]

I thought about it and I know now what was that for. No need to explain .

And one more thing.
I think that using this will not be good as a condition:

PHP Code:

damagebits & DMG_GRENADE 


Because if someone uses ExecuteHamB(Ham_TakeDamage,victim,inflictor,a ttacker,damage,DMG_GRENADE | ANOTHER_TYPE_DAMAGE)
Then we will have problems.
So this is the right way.

PHP Code:

damagebits == DMG_GRENADE 


[Arkshine]

Whatever & or ==, it's up to your need.

[BOYSplayCS]

Oh, thank you for hi-jacking my thread. Get out.

[Bugsy]

Originally Posted by ot_207 And one more thing. I think that using this will not be good as a condition: PHP Code: damagebits & DMG_GRENADE  Because if someone uses ExecuteHamB(Ham_TakeDamage,victim,inflictor,a ttacker,damage,DMG_GRENADE | ANOTHER_TYPE_DAMAGE) Then we will have problems. So this is the right way. PHP Code: damagebits == DMG_GRENADE

He made a simple request and I posted a simple solution. The bottom line is (DMG_GRENADE & damage) will return true when injured by a grenade. Of course there is a list of what-if's that can be thrown into the equation but he did not specify anything. Your statement\method can be what causes a problem since doing a (damage == DMG_GRENADE) check on ExecuteHamB(Ham_TakeDamage,victim,inflictor,a ttacker,damage,DMG_GRENADE | ANOTHER_TYPE_DAMAGE) would fail to detect grenade damage.

[ot_207]

Originally Posted by Bugsy He made a simple request and I posted a simple solution. The bottom line is (DMG_GRENADE & damage) will return true when injured by a grenade. Of course there is a list of what-if's that can be thrown into the equation but he did not specify anything. Your statement\method can be what causes a problem since doing a (damage == DMG_GRENADE) check on ExecuteHamB(Ham_TakeDamage,victim,inflictor,a ttacker,damage,DMG_GRENADE | ANOTHER_TYPE_DAMAGE) would fail to detect grenade damage.

By DMG_GRENADE | ANOTHER_TYPE_DAMAGE I meant that you could use that but not as a grenade damage. Damage of a weapon or something else...
Anyway it doesn't matter. It depends on what you want to do...