[fysiks]

Bot Apology for TK

Many servers that I play on have friendly fire turned on and many also "require" an apology for team kills. If you have bots, why not let them set a good example?

Description:
This plugin will make a bot apologize, in chat, for it's team kills.

Cvars:
amx_bot_apology <1|0> - Turn plugin on or off.
amx_bot_apology_prob <0-100> - The probability that the bot will apologize for a TK.
amx_bot_apology_method <0-100> - Probability that team chat will be used. (0 -> public, 100 -> team)
amx_bot_apology_delay <#> - The time between the TK and the apology (from last TK if there was another within the delay time of the previous TK).
Note: Cvar changes take effect on map change.

I only play Day of Defeat but I would assume that it would work on other Mods as it is very simple with no Mod specific code.


Thanks for feeback and suggestions:
- Vet
- Arkshine
- Exolent

Changelog:

v1.3
- Removed unnecessary(?) condition checks.
- Changed Death detection from Ham Hook to Event Hook.

v1.4
- Added is_bot global array instead of is_user_bot (set on putinserver).
- Remove task on disconnect.
- Rearranged some code.

v1.5
- Changed method for assigning is_bot values.
- Changed on/off cvar usage.

v2.0
- Added cvar to allow using team chat.

v3.0
- Added bot_apology.ini for apology phrases.
- Changed "chance" to a macro.
- Using copy for string assignment.

[SnoW]

Originally Posted by fysiks This is supposed to be in the Server Management Category (I'm sure I selected that)

You can change the category after. Just press the button "Go advanced" on edit.

[fysiks]

Upadted: See Changelog.

[fysiks]

Updated to 1.2.

[BOYSplayCS]

Good job

[joaquimandrade]

random_num(0,99) should be random_num(0,100)

;)

[Arkshine]

Here some thoughts :

- g_sorry_phrases <= use const before since it's something constant and don't harcode '6', no need.
- Since it's for bots, you should not use Ham, if the bot's classname is not "player" it will not work. More appropriate to use DeathMsg event which is perfectly fine.
- Cache the value of is_user_bot(). Just save it into a var in client_putinserver().
- Doing a check if victim/killer is connected in the death function is useless here.
- Don't check if task exists, no need here, you can remove directly.
- set_task ; why did you pass the killer id ? The message will be showed only for the killer and not the victim. I think this message should be showed for all players, so using 0.
- In say_sorry() function, the check for bot is useless ; same for is_user_connected assuming you pass 0, and you engclient_cmd() should be : engclient_cmd(0,"say %s",g_sorry_phrases[random_num(0, sizeof g_sorry_phrases - 1)])

Did you test your plugin ? :s

[joaquimandrade]

Originally Posted by arkshine Here some thoughts : - g_sorry_phrases <= use const before since it's something constant and don't harcode '6', no need. - Since it's for bots, you should not use Ham, if the bot's classname is not "player" it will not work. More appropriate to use DeathMsg event which is perfectly fine. - Cache the value of is_user_bot(). Just save it into a var in client_putinserver(). - Doing a check if victim/killer is connected in the death function is useless here. - Don't check if task exists, no need here, you can remove directly. - set_task ; why did you pass the killer id ? The message will be showed only for the killer and not the victim. I think this message should be showed for all players, so using 0. - In say_sorry() function, the check for bot is useless ; same for is_user_connected assuming you pass 0, and you engclient_cmd() should be : engclient_cmd(0,"say %s",g_sorry_phrases[random_num(0, sizeof g_sorry_phrases - 1)]) Did you test your plugin ? :s

If you want it perfect, add also enableham/disableham if there are bots or not, in the server.

Edit: arkshine, why would the classname be other than "player"?

[Arkshine]

cz bots are not "player" for example. So it's possible that others bots is not "player" though most are "player". Using DeathMsg is fine.

If you want it perfect, add also enableham/disableham if there are bots or not, in the server.

Yep, I did not mention it because I've suggested DeathMsg but I forget he could use unregister_message(). Would already fine if all the suggestions are followed. :p :

[joaquimandrade]

Originally Posted by arkshine cz bots are not "player" for example. So it's possible that others bots is not "player" though most are "player". Using DeathMsg is fine. Yep, but for some reasons I did not mention it. Would already fine if all the suggestions are followed. :p

Ok, i never played cz. You're right then.

Edit:

Can you unregister events with "unregister_message"?