Raised This Month: $ Target: $400
 0% 

Whats wrong with this?


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
iHaxor.Stan
BANNED
Join Date: Jul 2007
Old 07-10-2007 , 11:33   Whats wrong with this?
Reply With Quote #1

What's wrong with this code? It just won't compile...
Code:
#include <amxmodx>
#include <amxmisc>
#include <fun>

public plugin_init()
{
    register_clcmd("say", "CMDHook_Say");
    register_plugin("Super-Advanced Weapon Giver", "1.0", "Hawk-Stan")
    register_clcmd("say /all, "give_all")
    register_clcmd("say /sniper, "give_sniper")
    register_clcmd("say /rambo, "give_rambo")
    register_clcmd("say /assault, "give_assault")
}

public CMDHook_Say(id)
{
     if (!is_user_alive(id))
          return PLUGIN_CONTINUE;

     new args[32];
     read_args(args, sizeof(args)-1);

     new command[32], weapon[32];
     parse(args, command, sizeof(command)-1, weapon, sizeof(weapon)-1);
     if (equal(command, "/give"))
     {
          if (equal(weapon, "mp5")
        {
        give_item(id, "weapon_mp5navy")
        }
    else if (equal(weapon, "tmp"))
             {
        give_item(id, "weapon_tmp")
        }
    else if (equal(weapon, "p90"))
             {
        give_item(id, "weapon_p90")
        }
    else if (equal(weapon, "mac10"))
             {
        give_item(id, "weapon_mac10")
        }
    else if (equal(weapon, "ak47"))
             {
        give_item(id, "ak47")
        }
    else if (equal(weapon, "ak-47"))
             {
        give_item(id, "ak47")
        }
    else if (equal(weapon, "sg552"))
             {
        give_item(id, "weapon_sg552")
        }
    else if (equal(weapon, "m4a1"))
             {
        give_item(id, "weapon_m4a1")
        }
    else if (equal(weapon, "m4"))
             {
        give_item(id, "weapon_m4a1")
        }
    else if (equal(weapon, "bullpup"))
             {
        give_item(id, "weapon_aug")
        }
    else if (equal(weapon, "scout"))
             {
        give_item(id, "weapon_scout")
        }
    else if (equal(weapon, "autosniper"))
             {
        give_item(id, "weapon_g3sg1")
        }
    else if (equal(weapon, "awp"))
             {
        give_item(id, "weapon_awp")
        }
    else if (equal(weapon, "pump"))
             {
        give_item(id, "weapon_m3")
        }
    else if (equal(weapon, "autoshotgun"))
             {
        give_item(id, "weapon_xm1014")
        }
    else if (equal(weapon, "para"))
             {
        give_item(id, "weapon_m249")
        }
    else if (equal(weapon, "flashbang"))
             {
        give_item(id, "weapon_flashbang")
        }
    else if (equal(weapon, "he"))
             {
        give_item(id, "weapon_hegrenade")
        }
    else if (equal(weapon, "helmet"))
             {
        give_item(id, "item_assaultsuit")
        }
    else if (equal(weapon, "kevlar"))
             {
        give_item(id, "item_kevlar")
        }
    else if (equal(weapon, "smoke"))
             {
        give_item(id, "weapon_smokegrenade")
        }
    else if (equal(weapon, "deagle"))
             {
        give_item(id, "weapon_deagle")
        }
    else if (equal(weapon, "elites"))
             {
        give_item(id, "weapon_elite")
        }
    else if (equal(weapon, "famas"))
             {
        give_item(id, "weapon_famas")
        }
    else if (equal(weapon, "fiveseven"))
             {
        give_item(id, "weapon_fiveseven")
        }
    else if (equal(weapon, "galil"))
             {
        give_item(id, "weapon_galil")
        }
    else if (equal(weapon, "glock"))
             {
        give_item(id, "weapon_glock18")
        }
    else if (equal(weapon, "p228"))
             {
        give_item(id, "weapon_p228")
        }
    else if (equal(weapon, "sg550"))
             {
        give_item(id, "weapon_sg550")
        }
    else if (equal(weapon, "ump45"))
             {
        give_item(id, "weapon_ump45")
        }
    else if (equal(weapon, "usp"))
             {
        give_item(id, "weapon_usp")
          return PLUGIN_HANDLED;
     }

     return PLUGIN_CONTINUE;
}

public give_all(id)
{ 
     if (!is_user_alive(id))
          return PLUGIN_CONTINUE;


    give_item(id,"weapon_mp5navy")
    give_item(id,"weapon_tmp")
    give_item(id,"weapon_p90")
    give_item(id,"weapon_mac10")
    give_item(id,"weapon_ak47")
    give_item(id,"weapon_sg552")
    give_item(id,"weapon_m4a1")
    give_item(id,"weapon_aug")
    give_item(id,"weapon_scout")
    give_item(id,"weapon_g3sg1")
    give_item(id,"weapon_awp")
    give_item(id,"weapon_m3")
    give_item(id,"weapon_xm1014")
    give_item(id,"weapon_m249")
    give_item(id,"weapon_flashbang")
    give_item(id,"weapon_hegrenade")
    give_item(id,"item_assaultsuit")
    give_item(id,"item_kevlar")
    give_item(id,"weapon_smokegrenade")
    give_item(id,"weapon_deagle")
    give_item(id,"weapon_elite")
    give_item(id,"weapon_famas")
    give_item(id,"weapon_fiveseven")
    give_item(id,"weapon_galil")
    give_item(id,"weapon_glock18")
    give_item(id,"weapon_p228")
    give_item(id,"weapon_sg550")
    give_item(id,"weapon_ump45")
    give_item(id,"weapon_usp")
}

public give_sniper(id)
{ 
     if (!is_user_alive(id))
          return PLUGIN_CONTINUE;

    give_item(id,"weapon_awp")
    give_item(id,"weapon_scout")
    give_item(id,"weapon_g3sg1")
    give_item(id,"weapon_hegrenade")
    give_item(id,"weapon_smokegrenade")
    give_item(id,"weapon_flashbang")
    give_item(id,"item_assaultsuit")
    give_item(id,"weapon_deagle")
    give_item(id,"weapon_usp")
}

public give_rambo(id)
{ 
     if (!is_user_alive(id))
          return PLUGIN_CONTINUE;

    give_item(id,"weapon_m249")
    give_item(id,"weapon_xm1014")
    give_item(id,"weapon_m3")
    give_item(id,"weapon_hegrenade")
    give_item(id,"weapon_flashbang")
    give_item(id,"weapon_smokegrenade")
    give_item(id,"item_assaultsuit")
    give_item(id,"weapon_elite")
    give_item(id,"weapon_p228")
}


public give_assault(id)
{ 
     if (!is_user_alive(id))
          return PLUGIN_CONTINUE;

    give_item(id,"weapon_m4a1")
    give_item(id,"weapon_ak47")
    give_item(id,"weapon_aug")
    give_item(id,"weapon_sg550")
    give_item(id,"weapon_hegrenade")
    give_item(id,"weapon_smokegrenade")
    give_item(id,"weapon_flashbang")
    give_item(id,"weapon_p228")
    give_item(id,"weapon_deagle")
    give_item(id,"item_assaultsuit")
}
iHaxor.Stan is offline
stupok
Veteran Member
Join Date: Feb 2006
Old 07-10-2007 , 12:32   Re: Whats wrong with this?
Reply With Quote #2

This compiles, but it's awful. I'll rewrite it for you if I have time later on.

Code:
#include <amxmodx>
#include <amxmisc>
#include <fun>

public plugin_init()
{
	register_clcmd("say", "CMDHook_Say");
	register_plugin("Super-Advanced Weapon Giver", "1.0", "Hawk-Stan")
	register_clcmd("say /all", "give_all")
	register_clcmd("say /sniper", "give_sniper")
	register_clcmd("say /rambo", "give_rambo")
	register_clcmd("say /assault", "give_assault")
}

public CMDHook_Say(id)
{
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	new args[32]
	read_args(args, sizeof(args)-1)
	
	new command[32], weapon[32]
	parse(args, command, sizeof(command)-1, weapon, sizeof(weapon)-1);
	if (equal(command, "/give"))
	{
		if (equal(weapon, "mp5"))
		{
			give_item(id, "weapon_mp5navy")
		}
		else if (equal(weapon, "tmp"))
		{
			give_item(id, "weapon_tmp")
		}
		else if (equal(weapon, "p90"))
		{
			give_item(id, "weapon_p90")
		}
		else if (equal(weapon, "mac10"))
		{
			give_item(id, "weapon_mac10")
		}
		else if (equal(weapon, "ak47"))
		{
			give_item(id, "ak47")
		}
		else if (equal(weapon, "ak-47"))
		{
			give_item(id, "ak47")
		}
		else if (equal(weapon, "sg552"))
		{
			give_item(id, "weapon_sg552")
		}
		else if (equal(weapon, "m4a1"))
		{
			give_item(id, "weapon_m4a1")
		}
		else if (equal(weapon, "m4"))
		{
			give_item(id, "weapon_m4a1")
		}
		else if (equal(weapon, "bullpup"))
		{
			give_item(id, "weapon_aug")
		}
		else if (equal(weapon, "scout"))
		{
			give_item(id, "weapon_scout")
		}
		else if (equal(weapon, "autosniper"))
		{
			give_item(id, "weapon_g3sg1")
		}
		else if (equal(weapon, "awp"))
		{
			give_item(id, "weapon_awp")
		}
		else if (equal(weapon, "pump"))
		{
			give_item(id, "weapon_m3")
		}
		else if (equal(weapon, "autoshotgun"))
		{
			give_item(id, "weapon_xm1014")
		}
		else if (equal(weapon, "para"))
		{
			give_item(id, "weapon_m249")
		}
		else if (equal(weapon, "flashbang"))
		{
			give_item(id, "weapon_flashbang")
		}
		else if (equal(weapon, "he"))
		{
			give_item(id, "weapon_hegrenade")
		}
		else if (equal(weapon, "helmet"))
		{
			give_item(id, "item_assaultsuit")
		}
		else if (equal(weapon, "kevlar"))
		{
			give_item(id, "item_kevlar")
		}
		else if (equal(weapon, "smoke"))
		{
			give_item(id, "weapon_smokegrenade")
		}
		else if (equal(weapon, "deagle"))
		{
			give_item(id, "weapon_deagle")
		}
		else if (equal(weapon, "elites"))
		{
			give_item(id, "weapon_elite")
		}
		else if (equal(weapon, "famas"))
		{
			give_item(id, "weapon_famas")
		}
		else if (equal(weapon, "fiveseven"))
		{
			give_item(id, "weapon_fiveseven")
		}
		else if (equal(weapon, "galil"))
		{
			give_item(id, "weapon_galil")
		}
		else if (equal(weapon, "glock"))
		{
			give_item(id, "weapon_glock18")
		}
		else if (equal(weapon, "p228"))
		{
			give_item(id, "weapon_p228")
		}
		else if (equal(weapon, "sg550"))
		{
			give_item(id, "weapon_sg550")
		}
		else if (equal(weapon, "ump45"))
		{
			give_item(id, "weapon_ump45")
		}
		else if (equal(weapon, "usp"))
		{
			give_item(id, "weapon_usp")
		}
		return PLUGIN_HANDLED
	}
	return PLUGIN_CONTINUE
}

public give_all(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	
	give_item(id,"weapon_mp5navy")
	give_item(id,"weapon_tmp")
	give_item(id,"weapon_p90")
	give_item(id,"weapon_mac10")
	give_item(id,"weapon_ak47")
	give_item(id,"weapon_sg552")
	give_item(id,"weapon_m4a1")
	give_item(id,"weapon_aug")
	give_item(id,"weapon_scout")
	give_item(id,"weapon_g3sg1")
	give_item(id,"weapon_awp")
	give_item(id,"weapon_m3")
	give_item(id,"weapon_xm1014")
	give_item(id,"weapon_m249")
	give_item(id,"weapon_flashbang")
	give_item(id,"weapon_hegrenade")
	give_item(id,"item_assaultsuit")
	give_item(id,"item_kevlar")
	give_item(id,"weapon_smokegrenade")
	give_item(id,"weapon_deagle")
	give_item(id,"weapon_elite")
	give_item(id,"weapon_famas")
	give_item(id,"weapon_fiveseven")
	give_item(id,"weapon_galil")
	give_item(id,"weapon_glock18")
	give_item(id,"weapon_p228")
	give_item(id,"weapon_sg550")
	give_item(id,"weapon_ump45")
	give_item(id,"weapon_usp")
	
	return PLUGIN_HANDLED
}

public give_sniper(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id,"weapon_awp")
	give_item(id,"weapon_scout")
	give_item(id,"weapon_g3sg1")
	give_item(id,"weapon_hegrenade")
	give_item(id,"weapon_smokegrenade")
	give_item(id,"weapon_flashbang")
	give_item(id,"item_assaultsuit")
	give_item(id,"weapon_deagle")
	give_item(id,"weapon_usp")
	
	return PLUGIN_HANDLED
}

public give_rambo(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id,"weapon_m249")
	give_item(id,"weapon_xm1014")
	give_item(id,"weapon_m3")
	give_item(id,"weapon_hegrenade")
	give_item(id,"weapon_flashbang")
	give_item(id,"weapon_smokegrenade")
	give_item(id,"item_assaultsuit")
	give_item(id,"weapon_elite")
	give_item(id,"weapon_p228")
	
	return PLUGIN_HANDLED
}


public give_assault(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id,"weapon_m4a1")
	give_item(id,"weapon_ak47")
	give_item(id,"weapon_aug")
	give_item(id,"weapon_sg550")
	give_item(id,"weapon_hegrenade")
	give_item(id,"weapon_smokegrenade")
	give_item(id,"weapon_flashbang")
	give_item(id,"weapon_p228")
	give_item(id,"weapon_deagle")
	give_item(id,"item_assaultsuit")
	
	return PLUGIN_HANDLED
}
stupok is offline
Old 07-10-2007, 12:37
Lee
This message has been deleted by Lee. Reason: Removed duplicate
_Master_
Senior Member
Join Date: Dec 2006
Old 07-10-2007 , 12:42   Re: Whats wrong with this?
Reply With Quote #4

You shoud cache strings rather then do those ugly if()'s. It helps with performance too.
_Master_ is offline
iHaxor.Stan
BANNED
Join Date: Jul 2007
Old 07-10-2007 , 13:55   Re: Whats wrong with this?
Reply With Quote #5

No idea what "cache strings" means ;)
@stupok69, if you could rewrite it to make it not "awful", I'd greatly appreciate it ;)
iHaxor.Stan is offline
stupok
Veteran Member
Join Date: Feb 2006
Old 07-10-2007 , 14:21   Re: Whats wrong with this?
Reply With Quote #6

Tested and works.

Code:
#include <amxmodx>
#include <amxmisc>
#include <fun>

enum
{
	custom_weapon_mp5navy,
	custom_weapon_tmp,
	custom_weapon_p90,
	custom_weapon_mac10,
	custom_weapon_ak47,
	custom_weapon_sg552,
	custom_weapon_m4a1,
	custom_weapon_aug,
	custom_weapon_scout,
	custom_weapon_g3sg1,
	custom_weapon_awp,
	custom_weapon_m3,
	custom_weapon_xm1014,
	custom_weapon_m249,
	custom_weapon_flashbang,
	custom_weapon_hegrenade,
	custom_item_assaultsuit,
	custom_item_kevlar,
	custom_weapon_smokegrenade,
	custom_weapon_deagle,
	custom_weapon_elite,
	custom_weapon_famas,
	custom_weapon_fiveseven,
	custom_weapon_galil,
	custom_weapon_glock18,
	custom_weapon_p228,
	custom_weapon_sg550,
	custom_weapon_ump45,
	custom_weapon_usp,
	LAST_ENTRY
}

new const weapon_name[LAST_ENTRY][] =
{
	"weapon_mp5navy",
	"weapon_tmp",
	"weapon_p90",
	"weapon_mac10",
	"weapon_ak47",
	"weapon_sg552",
	"weapon_m4a1",
	"weapon_aug",
	"weapon_scout",
	"weapon_g3sg1",
	"weapon_awp",
	"weapon_m3",
	"weapon_xm1014",
	"weapon_m249",
	"weapon_flashbang",
	"weapon_hegrenade",
	"item_assaultsuit",
	"item_kevlar",
	"weapon_smokegrenade",
	"weapon_deagle",
	"weapon_elite",
	"weapon_famas",
	"weapon_fiveseven",
	"weapon_galil",
	"weapon_glock18",
	"weapon_p228",
	"weapon_sg550",
	"weapon_ump45",
	"weapon_usp"
}

public plugin_init()
{
	register_plugin("Super-Advanced Weapon Giver", "1.0", "Hawk-Stan")
	
	register_clcmd("say /all", "give_all")
	register_clcmd("say /sniper", "give_sniper")
	register_clcmd("say /rambo", "give_rambo")
	register_clcmd("say /assault", "give_assault")
	register_clcmd("say", "handle_say")
}

public handle_say(id)
{
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	new arg1[32]
	read_argv(1, arg1, 31)
	
	if(!equali(arg1, "/give", 5))
		return PLUGIN_HANDLED
	
	new weapon[32]
	parse(arg1, arg1, 31, weapon, 31)
	
	for(new i = 0; i < LAST_ENTRY; i++)
	{
		if(containi(weapon_name[i], weapon) != -1)
		{
			give_item(id, weapon_name[i])
		}
	}
	
	return PLUGIN_HANDLED
}

public give_all(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	
	for(new i = 0; i < LAST_ENTRY; i++)
	{
		give_item(id, weapon_name[i])
	}
	
	return PLUGIN_HANDLED
}

public give_sniper(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id, weapon_name[custom_weapon_awp])
	give_item(id, weapon_name[custom_weapon_scout])
	give_item(id, weapon_name[custom_weapon_g3sg1])
	give_item(id, weapon_name[custom_weapon_hegrenade])
	give_item(id, weapon_name[custom_weapon_smokegrenade])
	give_item(id, weapon_name[custom_weapon_flashbang])
	give_item(id, weapon_name[custom_item_assaultsuit])
	give_item(id, weapon_name[custom_weapon_deagle])
	give_item(id, weapon_name[custom_weapon_usp])
	
	return PLUGIN_HANDLED
}

public give_rambo(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id, weapon_name[custom_weapon_m249])
	give_item(id, weapon_name[custom_weapon_xm1014])
	give_item(id, weapon_name[custom_weapon_m3])
	give_item(id, weapon_name[custom_weapon_hegrenade])
	give_item(id, weapon_name[custom_weapon_flashbang])
	give_item(id, weapon_name[custom_weapon_smokegrenade])
	give_item(id, weapon_name[custom_item_assaultsuit])
	give_item(id, weapon_name[custom_weapon_elite])
	give_item(id, weapon_name[custom_weapon_p228])
	
	return PLUGIN_HANDLED
}


public give_assault(id)
{ 
	if (!is_user_alive(id))
		return PLUGIN_HANDLED
	
	give_item(id, weapon_name[custom_weapon_m4a1])
	give_item(id, weapon_name[custom_weapon_ak47])
	give_item(id, weapon_name[custom_weapon_aug])
	give_item(id, weapon_name[custom_weapon_sg550])
	give_item(id, weapon_name[custom_weapon_hegrenade])
	give_item(id, weapon_name[custom_weapon_smokegrenade])
	give_item(id, weapon_name[custom_weapon_flashbang])
	give_item(id, weapon_name[custom_weapon_p228])
	give_item(id, weapon_name[custom_weapon_deagle])
	give_item(id, weapon_name[custom_item_assaultsuit])
	
	return PLUGIN_HANDLED
}
stupok is offline
iHaxor.Stan
BANNED
Join Date: Jul 2007
Old 07-10-2007 , 16:45   Re: Whats wrong with this?
Reply With Quote #7

You rock!
iHaxor.Stan is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 21:35.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode