Raised This Month: $ Target: $400
 0% 

RPG Mod


  
 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
Emp`
AMX Mod X Plugin Approver
Join Date: Aug 2005
Location: Decapod 10
Old 05-04-2007 , 18:04   Re: RPG Mod
Reply With Quote #3

line 242:
Code:
server_exec();
???

line 342:
Code:
			while(task_exists(player))
				remove_task(player);
first of all no point in while loop. second, don't bother checking if it exists.

in various places:
Code:
if( function() )
	function2( function() );
better to do
Code:
new result = function();
if( result )
	function2( result );
Admin Commands:
I personally don't think the '+'/'-'/' ' method is very smart. I think there will be much confusion from people when they do rpg_givexp Emp` 500. Especially because that wouldn't even set their xp. You would have to do something like rpg_givexp Emp` dummy 500 to set xp.

line 1182:
Code:
new regenadd = gRegenLevel[id] * 1;
Why multiply by 1?

Saving Method:
Why save to multiple keys? Instead, combine them into a string and then get them from that string to reduce vault sizes.

Last of all, I don't see this being much different than Credits Mod. Explain what is different (other than skills).

Last edited by Emp`; 05-04-2007 at 18:07.
Emp` is offline
Send a message via AIM to Emp` Send a message via MSN to Emp` Send a message via Yahoo to Emp` Send a message via Skype™ to Emp`
 


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:31.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode