[GEOIP] geoip_code2 always return "err"

KCE · **Author**

With latest version of Amx Mod X, geoip_code2 always returns "err". Someone also posted a problem in the wiki.

Quote:

Use ccode[4] instead of ccode[3] for security reasons. In case of failure, this function should return "err" string, making ccode[3] too short to include /0 char.

Alien

SweatyBanana · 07-07-2006 , 09:06 Re: [GEOIP] geoip_code2 always return "err"

Well this is how Hawk showed me to fix it with name changes, but if you were wanting to display it in chat, I dont know.

PHP Code:


			
fnChangeName(id,szName[],szShortCountry[])
    if(containi(szName,szShortCountry) == -1 && containi(szShortCountry,"err") == -1)
    {
        remove_quotes(szName)
        if(get_pcvar_num(g_pShowWhere))
            client_cmd(id,"name ^"%s [%s]^"",szName,szShortCountry)
        else
            client_cmd(id,"name ^"[%s] %s^"",szShortCountry,szName)
    }

KCE · *Last edited by KCE; 07-07-2006 at 21:18.*

Ok I've done some more testing and got it to work:

Code:

// Get country on authorized
public client_authorized(id)
{
	if( !is_user_bot(id) )
	{
		new szCountryCode[5]
		new szIp[25]
		new szPort[25]
		new szAddress[25]
		get_user_ip(id,szIp,24)
		strtok(szIp, szAddress, 24, szPort, 24, ':') 		
		geoip_code2(szAddress,szCountryCode)
		strtolower(szCountryCode)	//convert all letters to lowercase
		format( g_szCountryCodeFile[id], 33, "countryflag_%s999", szCountryCode )
		server_print("Address: %s, CODE: %s", szAddress, g_szCountryCodeFile[id])
	}
}

For geoip_code2, when I removed the port number it worked. So, I believe that both the geoip_code2 and get_user_ip isn't removing the port?

teame06 · 07-07-2006 , 21:29 Re: [GEOIP] geoip_code2 always return "err"

All you need to do is use the get_user_ip(index, ip[], len, withoutport)

All you need to do is set withoutport to 1. No need to strtok.

Code:

#include <amxmodx>
#include <geoip>

new g_szCountryCodeFile[33]

// Get country on authorized
public client_authorized(id)
{
    if( !is_user_bot(id) )
    {
        new szCountryCode[3]
        new szIp[25]
        get_user_ip(id,szIp,24, 1)
        geoip_code2(szIp, szCountryCode)
        strtolower(szCountryCode)   //convert all letters to lowercase
        format( g_szCountryCodeFile[id], 33, "countryflag_%s999", szCountryCode )
        server_print("Address: %s, CODE: %s", szIp, g_szCountryCodeFile[id])
    }
}

KCE · *Last edited by KCE; 07-07-2006 at 21:38.*

Quote:

Originally Posted by teame06

All you need to do is use the get_user_ip(index, ip[], len, withoutport)

All you need to do is set withoutport to 1. No need to strtok.

Code:

#include <amxmodx>
#include <geoip>

new g_szCountryCodeFile[33]

// Get country on authorized
public client_authorized(id)
{
    if( !is_user_bot(id) )
    {
        new szCountryCode[3]
        new szIp[25]
        get_user_ip(id,szIp,24, 1)
        geoip_code2(szIp, szCountryCode)
        strtolower(szCountryCode)   //convert all letters to lowercase
        format( g_szCountryCodeFile[id], 33, "countryflag_%s999", szCountryCode )
        server_print("Address: %s, CODE: %s", szIp, g_szCountryCodeFile[id])
    }
}

LOL. I thought by setting it to 1, it INCLUDED the port number so I was setting it to 0...my bad

I think the problem with geoip_code2 is still there. In geoip.inc:

Quote:

//IP address can contain ports, the ports will be stripped out

So it should have worked either way.

I was doing this earlier:

Code:

// Get country on authorized
public client_authorized(id)
{
    if( !is_user_bot(id) )
    {
        new szCountryCode[3]
        new szIp[17]
        get_user_ip(id,szIp,16,false) //false == 0
        geoip_code2(szIp,szCountryCode)
        strtolower(szCountryCode)   //convert all letters to lowercase
        format( g_szCountryCodeFile[id], 33, "countryflag_%s999", szCountryCode )
    }
}

BAILOPAN · 07-07-2006 , 23:31 Re: [GEOIP] geoip_code2 always return "err"

So, are you currently having a problem with this using IPs without ports?

KCE · *Last edited by KCE; 07-12-2006 at 03:20.*

Quote:

Originally Posted by BAILOPAN

So, are you currently having a problem with this using IPs without ports?

geoip_code2 not being able to handle ip's with ports although it says so in the include.

BAILOPAN · 07-12-2006 , 12:57 Re: [GEOIP] geoip_code2 always return "err"

Okay, acknowledged as a valid bug. It'll be fixed for the next release.

faluco · 07-13-2006 , 05:30 Re: [GEOIP] geoip_code2 always return "err"

fixed thanks!
i'll upload the fix this night to SVN.

faluco · 07-13-2006 , 15:59 Re: [GEOIP] geoip_code2 always return "err"

hello, here is the fixed module for you if you want to test