Raised This Month: $ Target: $400
 0% 

[RE] FASTCUP Tactical Timeout (Pause Plug-in)


  
 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
deprale
Senior Member
Join Date: Oct 2018
Location: Leeds
Old 11-06-2023 , 07:37   Re: [RE] FASTCUP Tactical Timeout (Pause Plug-in)
Reply With Quote #5

Quote:
Originally Posted by IC3k1ng View Post
You can make a GitHub link that directs to the last release, like OciXCrom plugins. Also good job.
Thank you - however I don't want to do this as this code is embarrassing, I've looked through it and there's so many things I could've done better lol, I was such a newbie back then it's not even funny. But unfortunately I also lost interest into scripting as a whole, as I find C/C++ more fun to dabble with, nowadays I'm more into kernel stuff and security researching as a whole and honestly I can not bring myself to come back and fix this mess.

Just a short list of what I could've done better:
implement it as a proper API, and only then offer a ready-made solution, just in case other devs want to take the functionality of pausing but rather handle the other things themselves.

this could have been done much MUCHHHHHH cleaner and better.
too many defines. // arguable, i didn't look thoroughly what i was doing
hardcoded task ids.
using old ways of creating cvars even though I was using ReApi (???).
half using amxx default stuff half using reapi... no idea what i was doing wtf, should have just went with registerhookchain for example, but like I said, I was very much a newbie back then
useless tasks... LOL.
players who join will never see the messages of the pause (? WTF I WAS DUMB)
I love how I mangled the team ids, since they differ in the ways I was checking them, printing for a team and getting a team id was differing somehow (I don't remember exactly what I was doing) so I had to do some spaghetti LOL, the more I read through the code the more I laugh!!!
I love how I was overusing the ternary operators just for the sake of it ( cause I just learnt about it back then and I was so happy I understood how it works... or not! ). The only commendable thing I can find is the way I used it in get_players I guess?
Love the fact that I could have cached so many times before running loops with funny comparisons in the print functions...
Could have encapsulated more stuff to be honest like initializing/resetting some common variables, could have even arguably used bit shifting but maybe it's overkill for the purpose of the plugin.
I see a couple of array sizes that have no deal being this big but maybe there's a reason behind them I don't remember.

Overall I would rate this code 3/10, but to be honest... at the time to me it looked like groundbreaking code so I was very proud of myself, so I might come back and fix this mess (eventually).


Also R.I.P goldSrc.

Quote:
Originally Posted by Escap3d View Post
i suggestion all to remove under red line main mark in picture. this is a bottom side i want set this top center anyone fix this ?only timer is good for plugin sorry my bad english
remove/comment out lines 432-435 (the whole for loop) in DisplayPauseProgress().
and don't forget to remove/comment out lines 178-180 in CleanReinitialize().
__________________

Last edited by deprale; 11-06-2023 at 07:53.
deprale is offline
 



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 10:12.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode