[xerox8521]

Hi,

It seems to me you cannot pass argument types to functions with dhooks that are passed by reference unless they are virtual.
Well problem is this function CServerGameClients::GetPlayerLimits I wouldn't know how to make this one virtual as you need to pass an instance of CServerGameClients which you don't have in the normal API.
So i set this up as detour but with this commit here I cannot tell dhooks that the parameters are to be passed as reference. If I just specify them as int I obviously just get garbage.

So what would be the right approach to do this?

[Zynda]

There's a global instance g_ServerGameClients (gameinterface.cpp) if you're on linux you can simply use the symbol name.
By the way the 'garbage' value is actually the underlying int *
nothing is stopping you from simply using LoadFromAddress/StoreToAddress on it :)

[xerox8521]

Well, LoadFromAddress requires the address and param.GetAddress from dhooks only works on ptr param types.
So how would I get the address?

[Zynda]

PHP Code:

public MRESReturn GetPlayerLimits(Address pThis, DHookParam hParams)
{
    Address a1 = hParams.Get(1);
    Address a2 = hParams.Get(2);
    Address a3 = hParams.Get(3);

    // dereference
    int v1 = LoadFromAddress(a1, NumberType_Int32);
    int v2 = LoadFromAddress(a2, NumberType_Int32);
    int v3 = LoadFromAddress(a3, NumberType_Int32);
    PrintToServer("Min [%d] Max [%d] Default [%d]", v1, v2, v3);

    StoreToAddress(a1, 1, NumberType_Int32);
    StoreToAddress(a2, 4, NumberType_Int32);
    StoreToAddress(a3, 1, NumberType_Int32);

    // Make sure the original does not get called
    return MRES_Supercede;
}