[Orinuse]

Made possible with Psykotikism's Library of L4Ds Signatures!

Description
Individually control weapon reserve independent of "ammo_*" cvars. Primary intent is to let weapon modders set reserve ammo counts without fighting with ammo types (CSS Snipers, L4D1 Shotguns)

Customization
Go to the "/addons/sourcemod/data/l4d_reservecontrol.cfg" file after the plugin has been installed, and edit it.

Data File

PHP Code:

"ReserveControl"
{
    // Following weapons can have edited reserves, even with edited ammo types.
    /// (except AMMO_TYPE_PISTOL or AMMO_TYPE_PISTOL_MAGNUM, since their ammo is infinite)
    // ++ L4D1 Weapons ++
    // ------------------
    //// Standard
//    "weapon_pistol"        999
    "weapon_smg"            500
    "weapon_pumpshotgun"    72
    "weapon_rifle"        360
    "weapon_autoshotgun"    90
    "weapon_hunting_rifle"    150
    
    // ++ L4D2 Weapons ++
    // ------------------
    //// Standard
    "weapon_smg_silenced"        500
    "weapon_shotgun_chrome"    72
    "weapon_rifle_desert"        360
    "weapon_rifle_ak47"        200
    "weapon_shotgun_spas"        90
    "weapon_sniper_military"    150

    //// CS:S Weapons
    "weapon_smg_mp5"        500
    "weapon_rifle_sg552"    360
    "weapon_sniper_scout"    120
    "weapon_sniper_awp"    120
    
    //// Special Tier
//    "weapon_grenade_launcher"    30
//    "weapon_pistol_magnum"        999
//    "weapon_rifle_m60"            0
} 


Commands

Spoiler

PHP Code:

// Resets the reserve ammo data, then reload the config.
sm_rc_reload

// Alias of 'sm_rc_reload'
sm_reversecontrol_reload 


Changelog

Spoiler

1.1 (20-Jan-2021)
- Fixed a bug where SM is misled into thinking DHook is a plugin dependancy, rather than an extension. 
- Updated the config file:
- - Revised a comment about ammo types. (The phrasing was awful)
- - MP5's reserve ammo count matches the other SMGs (650 --> 500)
- - Fixed the SG552's forgotten inclusion, its now present in the config file by default.
- Likely the final update for this plugin; its already finished to me now, and aged fine.

1.0a (12-Sep-2021)
- Released on AlliedModders.

Requirements

1. DHooks (Dynamic Detours) extension.

WARNING

• Weapons via the give command won't spawn with the correct reserve counts till an ammo pile is used. Not sure why this happens, but its really minor practically.
• If other plugins that edit reserve ammo are also present, their functionalities may conflict and fight with this plugin!
  • Unfortunately preventing this is simply not possible, every plugin is vastly different from each other in implementation.

Installing
Extract the .zip file's folders into /addons/sourcemod.

[Silvers]

I don't think a detour is required. SDKHook clients SDKHook_WeaponEquip and SDKHook_WeaponDrop and modify the reserve ammo with the following code.

You could track the entity each time someone equips or drops a weapon and set the ammo value accordingly. For example have g_iAmmo[2048][2] where g_iAmmo[weapon][0] is the EntIndexToEntRef() of the weapon to verify itself is the same weapon, and [1] would be the ammo you read/set when picked up/dropped. That would work for all weapons without issue from what I can think.

PHP Code:

// Plugin start:
g_iOffsetAmmo = FindSendPropInfo("CTerrorPlayer", "m_iAmmo");
g_iPrimaryAmmoType = FindSendPropInfo("CBaseCombatWeapon", "m_iPrimaryAmmoType");

// The function
int GetOrSetPlayerAmmo(int client, int iWeapon, int iAmmo = -1)
{
    int offset = GetEntData(iWeapon, g_iPrimaryAmmoType) * 4; // Thanks to "Root" or whoever for this method of not hard-coding offsets: https://github.com/zadroot/AmmoManager/blob/master/scripting/ammo_manager.sp

    // Get/Set
    if( offset )
    {
        if( iAmmo != -1 ) SetEntData(client, g_iOffsetAmmo + offset, iAmmo);
        else return GetEntData(client, g_iOffsetAmmo + offset);
    }

    return 0;
} 


[Orinuse]

Originally Posted by Silvers I don't think a detour is required. SDKHook clients SDKHook_WeaponEquip and SDKHook_WeaponDrop and modify the reserve ammo with the following code. -snip-

I did tried an approach without detours (or gamedata), but these issues arise:

1. Ammo piles. I used to hijack the ammo refilling an SDKHook_Use, but that leaded to more issues:
   
   • Hijacking means I need to now manually give ammo to everyone, so I need to iterate through their inventory's items.
   • There are special ammo refilling gamerules, like how L4D2 ammo piles give extra ammo to compensate for empty clips (used a SDKCall to resolve), or that M60 / GL ammo can't be refilled. I'd need to account for it all.
   • No HUD notification, or ammo refill sound. (Need to replicate, or make my own)
   • Bots hog these ammo piles for eternity with the ammo pile forcing their ammo counts, since they don't think their weapon is refilled. (and subsequently, they "idle")
2. Weapon equips with SDKHook_WeaponEquipPost (a SDKHook_WeaponEquip is too slow)
   
   • A player equipping a weapon doesn't necessarily mean its from a source that refills ammo, so now I have more complexity to deal with on top of the hijacked ammo pile. (last thing I want)
   • I made a system that clamps reserve ammo to the desired max reserve counts incase the player picked up a dropped weapon ("item_pickup" game event), but that also means these:
     
     • Manually account for all places a player can get a weapon before I edit their "m_iExtraPrimaryAmmo" (and also determining if said event should clamp reserve ammo, not refill it), which is hooking all the relevant game events manually. ("spawner_give_item", "player_first_spawn", "item_pickup", "map_transition"... there could be more too)
     • Some game events only give strings and not entity index, so I needed to compare the string to the player's inventory. (I made a function called BestWeaponStringIndex() for this)

It just ain't pretty and a big mess, and I don't even know if that's the full list of the issues, there could be more but I rather not find out. Its currently more maintainable than its state with no use of detours, and I find it uneasy to be going back now.

[Silvers]

Ahh that makes sense. Good job

[mikaelangelis]

It only works when I pick up weapon, but not when I refill from Ammo stash
E.g: AK 200 reserve when picked up, but goes back to 360 when refill from ammo stash

[Orinuse]

Originally Posted by mikaelangelis It only works when I pick up weapon, but not when I refill from Ammo stash E.g: AK 200 reserve when picked up, but goes back to 360 when refill from ammo stash

Mind showing me the list of plugins you have installed? (sm plugins list)

Additionally, is this on a dedicated or local server?

[mikaelangelis]

Originally Posted by Orinuse Mind showing me the list of plugins you have installed? (sm plugins list) Additionally, is this on a dedicated or local server?

I am on local host myself
here is the list of plugin I use

[mikaelangelis]

Nevermind I found my problem. It is the l4d2_upgradesreloaded.smx which caused the issue. Inside that plugin there is upgrade that enables extended ammo reserve for primary weapon. It is sad that If I love both your plugin and this one. Guess I have to choose. Just a reminder: Any reserve ammo related plugin like l4d2_guncontrol also conflicts with your plugin.

P.S: I wish you could update the feature of looting residual ammo of the same gun like guncontrol plugin. Anyway, nice plugin

[Silvers]

Suggestion: Change title to "Reserve Ammo Control" to make it clearer, when I opened the thread I didn't know what it meant.

[Orinuse]

Originally Posted by mikaelangelis Nevermind I found my problem. It is the l4d2_upgradesreloaded.smx which caused the issue. Inside that plugin there is upgrade that enables extended ammo reserve for primary weapon. It is sad that If I love both your plugin and this on.

Oh that's good to know. Conflicts were something I couldn't tell myself on how to worry about them, so I didn't bothered. At the very least for now, what I can do is probably setting up natives.

Originally Posted by mikaelangelis P.S: I wish you could update the feature of looting residual ammo of the same gun like guncontrol plugin. Anyway, nice plugin

Its this?

Spoiler

Allows you to scavenge dropped guns for contained ammo. Say you all had lasered AKs, youre all nearly dry on ammo, you come across new guns, your mates grab some. They dropped their AKs which still contain 30-50 rounds each. But you refuse!! to let go of your favourite pwnage utility. You can now pick them up to get the contained ammo reserves.

Gotta first make it clear that no promises its made within reasonable time expectations (Valve Time), but when it happens, the suggestion could be a separate plugin that uses this plugin's if-scenario natives. Would be in the same thread as this to let others post their plugins.

Originally Posted by Silvers Suggestion: Change title to "Reserve Ammo Control" to make it clearer, when I opened the thread I didn't know what it meant.

Done.