Raised This Month: $ Target: $400
 0% 

[ANY] Input Hooks - DevTools (1.9) [15-Jun-2022]


  
 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
Silvers
SourceMod Plugin Approver
Join Date: Aug 2010
Location: SpaceX
Old 08-26-2020 , 19:01   Re: [ANY] Input Hooks - DevTools (1.4) [10-May-2020]
Reply With Quote #10

Quote:
Originally Posted by Ilusion9 View Post
Which game? Which plugin version? You modified that (and removed stuff?) why?

It has a specific check for reading "InValue" commands which would crash when reading with any other method, there maybe other commands which need to be read as objects instead, you can debug where its crashing by printing/logging the "command" variable value and seeing the last one printed before crash, and let me know what it is so I can fix the plugin.



Quote:
Originally Posted by Ilusion9 View Post
He does the same thing here:
PHP Code:
    if( pThis )
        
pThis EntRefToEntIndex(pThis); 
And I've seen entities with negative values or higher than 4096, I thought entities can only have indexes between 0 and 4096..,
Because negative entity indexes are more than likely going to be entity references which is used by non-networked entities (their index is > 2048 or > 4096 depending on the game and their max entity limits). See the [TUT] SourcePawn Scripting - Tips, Basics to Advanced for more details.

The plugin should probably be checking EntRefToEntIndex != INVALID_ENT_REFERENCE after converting but I don't see why an input triggered at this stage would ever be an invalid entity (probably the reason I left out the check to see if anyone reports an invalid entity error - I specifically do this for various plugins where I think a check would not have to be required and wait for any error reports, rarely some trigger errors and sometimes only very rarely).
__________________
Silvers is offline
 



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 22:27.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode