Raised This Month: $ Target: $400
 0% 

COD: HitMarkers v1.7 [Updated April 29th 2021]


  
 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 02-09-2020 , 12:52   Re: COD: HitMarkers [Last Update: 24/01/2020]
Reply With Quote #22

Quote:
1) Should the check that georgik57 gave me get added?
It's your plugin, you should decide if it should be added or not. Try to reason about things, don't just take someone else's word about it. Everything in programming should make sense, if it doesn't then it's time to ask yourself some questions(and others if you can't figure it out).

Here the question is really simple: should you show the hitmaker if no damage is done? The hit still occurred, it just did 0 damage. So what is the hit marker really tracking? Hits or damage? That's up to you to decide.

Quote:
2) I've been suggested to change the hitmarker to be red when the victim is killed. Allthough, if i add this, a lot of cvars should be added too. (Honestly i think that would be too much for a simple plugin like this, but the modifications will be endless imo.)

Cvars that should get added when i do this:
amx_hmdead "1" - Will set the red hitmarker enabled/disabled.
amx_hmdeadrcolor "255" // Sets the red RGB code for the dead hitmarker.
amx_hmdeadgcolor "0" // Sets the green RGB code for the dead hitmarker.
amx_hmdeadbcolor "0" // Sets the blue RGB code for the dead hitmarker.
There is nothing wrong in adding more features, as long as they make sense. There's also no reason to be worried about a rich configuration(e.g many cvars). They just give more power to the user without any downside.
I'm also not against refactoring cvars, but you need to think if it will make the plugin easier to use/harder. Because if the price you have to pay to get less cvars is to make the plugin harder to configure then it's pointless.

Quote:
PS: You should also cache the string cvars in this case(either per round or once every X seconds), as TakeDamage can be spammed very much.
I disagree, TakeDamage is not called nearly enough to justify caching cvars.

Quote:
2) Can u explain again what you're trying to do with read_flags() right there? I don't really get it
He's trying to create a cvar to decide which weapon will show a hit marker and he's using letters for it. You could use the weapon name instead of letters, like "scout awp ...". Basically this will replace amx_hmsnipers and extend it to every weapon(right now it's either all weapon or snipers, you can't choose for each individual weapon if it will show the hitmarker or not).

He also has a valid point about hegrenades. If amx_hmsnipers is 1 and you do damage with a hegrenade and switch to a sniper before the grenade explodes it will show a hitmarker, even if the damage is done with a hegrenade, not an awp.
__________________

Last edited by HamletEagle; 02-09-2020 at 12:55.
HamletEagle is offline
 



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 09:07.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode