[ddhoward]

[Any] Delay Command
v. 18.0725.0

This plugin allows admins to schedule commands to be run in the future. It takes heavy inspiration from this this plugin: https://forums.alliedmods.net/showthread.php?t=134288


Commands:

• sm_delaycmd [time in seconds] [command to run], deafult access ADMFLAG_GENERIC. This command allows those with access to schedule command usage for a later time. For example, running the command sm_delaycmd 300 sm_kick @all "time's up!" would kick all players after 5 minutes with the reason "time's up!" If a player disconnects while he has pending commands, those commands will be cancelled.
  
  
• sm_delaycmd_list [target], default access ADMFLAG_GENERIC. This command allows the user to view a list of all pending commands queued by the target player(s), printed to the console. Players who do not have access to sm_delaycmd_viewothers (defaults to ADMFLAG_GENERIC) will be unable to specify a target; the target is assumed to be themselves. Players with access to sm_delaycmd_rcon will be able to view the server console's pending commands via either the @all targeting filter, or by using sm_delaycmd_rcon with no arguments, and selecting CONSOLE from the menu that should appear.
  
  
• sm_delaycmd_cancel [handle], default access ADMFLAG_GENERIC. Players can use this command, in conjunction with a handle code given to them by sm_delaycmd_list, to cancel a pending command. Players with access to sm_delaycmd_cancelothers (defaults to ADMFLAG_GENERIC) can specify command handles queued by other players. Players without access to this override can only cancel their own pending commands. Further, players with access to sm_delaycmd_rcon can specify commands pending to be run by the server console.
  
  
• sm_delaycmd_rcon [time in seconds] [command to run], default access ADMFLAG_RCON. This command is similar to sm_delaycmd, except the command will be run by the server console. These commands will not be cancelled if the player leaves the server.
  
  

CVARS, shown with default values:

• sm_delaycmd_update 2 - Controls Updater compatibility
  • 0 : Completely disables Updater integration
  • 1 : Updater will notify you in Updater.log if an update becomes available.
  • 2 : Updater will automatically download any updates. They will be installed on the next server start or map change.
  • 3 : Updater will automatically download and immediately install any updates.

Changelog:

Spoiler

• 18.0714 - Initial release.
• 18.0714.1 - Hopefully fixed an error regarding passing client 0 through FakeClientCommandEx, fixed a bug regarding invalid handles, and fixed a bug with ShowActivity2 + sm_delaycmdrcon
• 18.0725.0 - Removed sm_delaycmdrcon_list and sm_delaycmdrcon_cancel, touched up logging

Future plans:

Spoiler

• Enable real menu support for _list and _cancel commands
• Talk with DarthNinja about enabling the sending of commands into the past huehuehuehuehue
• Enable a more convenient method of specifying times, allowing users to specify minutes/hours, or even exact times.

DOWNLOADS:

• Plugin
• Source
• Required custom includes:
  • ddhoward_updater.inc
  • updater.inc (source)

If you like what you see here, please consider donating~

[Facksy]

md 5 seconds ago to execute "sm_slap @all" (Handle: 72417886)
[DelayCmd] Running "sm_slap @all", queued 5 seconds ago.
L 07/14/2018 - 11:17:28: [SM] Exception reported: Client index 0 is invalid
L 07/14/2018 - 11:17:28: [SM] Blaming: delaycmd.smx
L 07/14/2018 - 11:17:28: [SM] Call stack trace:
L 07/14/2018 - 11:17:28: [SM]   [0] FakeClientCommandEx
L 07/14/2018 - 11:17:28: [SM]   [1] Line 104, E:\Steam\sourcemod\delayCmd.sp::Ti
mer_DelayCmd

when i run sm_delaycmd 5 sm_slap @all
You should add there IsValidClient()
Otherwise it works well :p

EDIT: also this error when someone disconnect, it crash the server

L 07/14/2018 - 11:29:54: [SM] Exception reported: Invalid Handle 0 (error: 4)
L 07/14/2018 - 11:30:00: [SM] Blaming: delaycmd.smx
L 07/14/2018 - 11:30:16: [SM] Call stack trace:
L 07/14/2018 - 11:30:17: [SM]   [0] ArrayList.Length.get
L 07/14/2018 - 11:30:17: [SM]   [1] Line 41, E:\Steam\sourcemod\delayCmd.sp::OnC
lientDisconnect
L 07/14/2018 - 11:30:17: [SM] Exception reported: Script execution timed out

[eyal282]

Originally Posted by Facksy md 5 seconds ago to execute "sm_slap @all" (Handle: 72417886) [DelayCmd] Running "sm_slap @all", queued 5 seconds ago. L 07/14/2018 - 11:17:28: [SM] Exception reported: Client index 0 is invalid L 07/14/2018 - 11:17:28: [SM] Blaming: delaycmd.smx L 07/14/2018 - 11:17:28: [SM] Call stack trace: L 07/14/2018 - 11:17:28: [SM] [0] FakeClientCommandEx L 07/14/2018 - 11:17:28: [SM] [1] Line 104, E:\Steam\sourcemod\delayCmd.sp::Ti mer_DelayCmd when i run sm_delaycmd 5 sm_slap @all You should add there IsValidClient() Otherwise it works well :p

Do you happen to be client number 0, a.k.a ( I think! ) in a listen server? Because listen servers are known to have trouble.

[Facksy]

No no, im supposed to be the client 1

[ddhoward]

[QUOTE=Facksy;2603459]

md 5 seconds ago to execute "sm_slap @all" (Handle: 72417886)
[DelayCmd] Running "sm_slap @all", queued 5 seconds ago.
L 07/14/2018 - 11:17:28: [SM] Exception reported: Client index 0 is invalid
L 07/14/2018 - 11:17:28: [SM] Blaming: delaycmd.smx
L 07/14/2018 - 11:17:28: [SM] Call stack trace:
L 07/14/2018 - 11:17:28: [SM]   [0] FakeClientCommandEx
L 07/14/2018 - 11:17:28: [SM]   [1] Line 104, E:\Steam\sourcemod\delayCmd.sp::Ti
mer_DelayCmd

I'm honestly at a loss as to how this could happen. In any case, I've put in a little check to prevent this, but it shouldn't be happening at all.

You should add there IsValidClient()

error 017: undefined symbol "IsValidClient"

EDIT: also this error when someone disconnect, it crash the server L 07/14/2018 - 11:29:54: [SM] Exception reported: Invalid Handle 0 (error: 4) L 07/14/2018 - 11:30:00: [SM] Blaming: delaycmd.smx L 07/14/2018 - 11:30:16: [SM] Call stack trace: L 07/14/2018 - 11:30:17: [SM] [0] ArrayList.Length.get L 07/14/2018 - 11:30:17: [SM] [1] Line 41, E:\Steam\sourcemod\delayCmd.sp::OnC lientDisconnect L 07/14/2018 - 11:30:17: [SM] Exception reported: Script execution timed out

Fixed, thanks! Although, the last line is part of a different error which would have been printed on the lines AFTER it. Are you sure that last line has to do with my plugin?

Plugin updated to version 18.0714.1.

[Facksy]

No, this error was not due to your plugin ^^, also this is my IsValidClient:

stock bool:IsValidClient(client)
{ 
	if (client <= 0 || client > MaxClients || !IsClientConnected(client) || IsFakeClient(client) || !IsClientInGame(client))
	{
		return false; 
	}
	return true; 
}

[Papero]

I've made a thing like this too, I've never published it on am though.
https://github.com/Hexer10/HexFuture...g/HexFuture.sp

[Mitchell]

[QUOTE=ddhoward;2603711]

Originally Posted by Facksy md 5 seconds ago to execute "sm_slap @all" (Handle: 72417886) [DelayCmd] Running "sm_slap @all", queued 5 seconds ago. L 07/14/2018 - 11:17:28: [SM] Exception reported: Client index 0 is invalid L 07/14/2018 - 11:17:28: [SM] Blaming: delaycmd.smx L 07/14/2018 - 11:17:28: [SM] Call stack trace: L 07/14/2018 - 11:17:28: [SM] [0] FakeClientCommandEx L 07/14/2018 - 11:17:28: [SM] [1] Line 104, E:\Steam\sourcemod\delayCmd.sp::Ti mer_DelayCmd I'm honestly at a loss as to how this could happen. In any case, I've put in a little check to prevent this, but it shouldn't be happening at all.

Same reason we say to either send client serial or userId when passing to a timer, because a client can disconnect.
GetClientOfUserId returns 0 it there is no client under that userid. ( https://sm.alliedmods.net/new-api/cl...ClientOfUserId )
So if the delay is long enough a player could do the command as they are disconnecting.

[ddhoward]

Originally Posted by Mitchell Same reason we say to either send client serial or userId when passing to a timer, because a client can disconnect. GetClientOfUserId returns 0 it there is no client under that userid. ( https://sm.alliedmods.net/new-api/cl...ClientOfUserId ) So if the delay is long enough a player could do the command as they are disconnecting.

But how would this cause the problem in this particular plugin? A client disconnecting causes all his pending commands to be cancelled, by passing the handles of all his timers through CloseHandle().

You're telling me things I already know. :/

[Mitchell]

Originally Posted by ddhoward But how would this cause the problem in this particular plugin? A client disconnecting causes all his pending commands to be cancelled, by passing the handles of all his timers through CloseHandle(). You're telling me things I already know. :/

then why are you using CloseHandle() (old syntax) instead of delete and also I think you need to use KillTimer() not just close the handle.
https://sm.alliedmods.net/new-api/timers/KillTimer
It also has an auto close for the data handle, just briefly looking it may close those datapacks you're also not closing but storing in the ArrayList (this is just how it appears, i'm not familiar with looping through the indices of an ArrayList).