[Mr. Man]

What file am I missing here exactly:

L 07/06/2018 - 03:57:43: [L4D2_missionmanager.smx] An error occured while parsing maps.phrases.txt(English), code:1
L 07/06/2018 - 03:57:43: [L4D2_missionmanager.smx] Map name localization file addons/sourcemod/translations/maps.phrases.txt does not exist!

Was I supposed to have created one myself or?

Also would be good if you added the auto reset to defined map/change maps when server is empty for x amount of time.

[rikka0w0]

Originally Posted by Crasher_3637 Congrats. I haven't had the time to convert the source code to the new syntax yet. I could probably shorten the code by 50-100 lines once I convert it. And maybe we can work together to add L4D1 support.

The latest version completely abandon the old syntax.
The problem is that I didn't buy L4D1, there no way for me to test it. However in theory this plugin should be compatible with L4D, as long as the campaign/map list can be correctly generated.

[rikka0w0]

Originally Posted by Mr. Man What file am I missing here exactly: L 07/06/2018 - 03:57:43: [L4D2_missionmanager.smx] An error occured while parsing maps.phrases.txt(English), code:1 L 07/06/2018 - 03:57:43: [L4D2_missionmanager.smx] Map name localization file addons/sourcemod/translations/maps.phrases.txt does not exist! Was I supposed to have created one myself or? Also would be good if you added the auto reset to defined map/change maps when server is empty for x amount of time.

"maps.phrases.txt" is used for localizing individual maps, e.g. c1m1_hotel to some human-readable name. If you don't want to localize them, it's completely fine. Create a file with the following content as the "maps.phrases.txt":

PHP Code:

"Phrases"
{

} 


As a result, the maps will be shown as names like "c1m1_hotel".
To localize map names, your "maps.phrases.txt" should be something like:

PHP Code:

"Phrases"
{
    "c1m1_hotel"
    {
        "en"        "Hotel"
    }
} 


Sorry I forgot to mention this in the intro

Also would be good if you added the auto reset to defined map/change maps when server is empty for x amount of time.

I had another plugin which does something similar, it switches to c1m1_hotel when the empty server is running 3-rd party maps. Some people doesn't have 3-rd maps, they cannot log on to the server and change the map if the server is already running a 3-rd map. I think it might be good to include this function into the ACS.

[Psyk0tik]

Both .sp files failed to compile. The reason is that you didn't parenthesize the values that you were using the view_as operator for.

Before: view_as<something>something2
After: view_as<something>(something2)

I also replaced all the "FCVAR_PLUGIN" plugin stuff with an underscore since they're deprecated.

Another thing I did was add #pragma newdecls required to both plugins. For acs.sp, you didn't add "void" for the ConVar.AddChangeHook callbacks and other things like OnMapStart and OnPluginStart. You also didn't add "int" for the MenuHandler.

Before: public VoteMenuHandler
After: public int VoteMenuHandler

Aside from that, everything checks out so far, though I do see a lot of hard-coded stuff that could easily be shortened/fixed by Silvers' suggestion. I second his suggestion since it really will reduce all those mutations to like around 25-30 lines of code and will support all mutations including custom ones.

This is the one that Silvers is suggesting.

PHP Code:

int g_iCurrentMode;
bool IsAllowedGameMode()
{
    if( g_hCvarMPGameMode == null )
        return false;

    int iCvarModesTog = g_hCvarModesTog.IntValue;
    if( iCvarModesTog != 0 )
    {
        g_iCurrentMode = 0;

        int entity = CreateEntityByName("info_gamemode");
        DispatchSpawn(entity);
        HookSingleEntityOutput(entity, "OnCoop", OnGamemode, true);
        HookSingleEntityOutput(entity, "OnSurvival", OnGamemode, true);
        HookSingleEntityOutput(entity, "OnVersus", OnGamemode, true);
        HookSingleEntityOutput(entity, "OnScavenge", OnGamemode, true);
        ActivateEntity(entity);
        AcceptEntityInput(entity, "PostSpawnActivate");
        AcceptEntityInput(entity, "Kill");

        if( g_iCurrentMode == 0 )
            return false;

        if( !(iCvarModesTog & g_iCurrentMode) )
            return false;
    }

    char sGameModes[64], sGameMode[64];
    g_hCvarMPGameMode.GetString(sGameMode, sizeof(sGameMode));
    Format(sGameMode, sizeof(sGameMode), ",%s,", sGameMode);

    g_hCvarModes.GetString(sGameModes, sizeof(sGameModes));
    if( strcmp(sGameModes, "") )
    {
        Format(sGameModes, sizeof(sGameModes), ",%s,", sGameModes);
        if( StrContains(sGameModes, sGameMode, false) == -1 )
            return false;
    }

    g_hCvarModesOff.GetString(sGameModes, sizeof(sGameModes));
    if( strcmp(sGameModes, "") )
    {
        Format(sGameModes, sizeof(sGameModes), ",%s,", sGameModes);
        if( StrContains(sGameModes, sGameMode, false) != -1 )
            return false;
    }

    return true;
}

public void OnGamemode(const char[] output, int caller, int activator, float delay)
{
    if( strcmp(output, "OnCoop") == 0 )
        g_iCurrentMode = 1;
    else if( strcmp(output, "OnSurvival") == 0 )
        g_iCurrentMode = 2;
    else if( strcmp(output, "OnVersus") == 0 )
        g_iCurrentMode = 4;
    else if( strcmp(output, "OnScavenge") == 0 )
        g_iCurrentMode = 8;
} 


Make sure to call it anytime after the round starts since it creates the info_gamemode entity and you'll get errors if you try to create it on OnMapStart or anything before configs are executed. I highly recommend checking out his plugins, like Mutant Zombies and Gun Cabinet since he calls the check on OnConfigsExecuted. A lot of his plugins contain code that not many users know about or tried before so maybe they can help you optimize your plugins.

[rikka0w0]

Both .sp files failed to compile. The reason is that you didn't parenthesize the values that you were using the view_as operator for.

Which version of sourcemod are you using? I use 1.7 and it compiles without any warning or error. I probably should fix them.

For transforming the syntax, the thing I did is to remove things like : and decl, and change const Stringxx[] to const char[] xxx. I forget to add return/parameter types as required by the new syntax.

I'm really appreciate that you point out these problems

[Psyk0tik]

I use SM 1.8.0.6048 (latest stable build). I don't use the unstable builds.

[Lux]

Originally Posted by rikka0w0 Which version of sourcemod are you using? I use 1.7 and it compiles without any warning or error. I probably should fix them. For transforming the syntax, the thing I did is to remove things like : and decl, and change const Stringxx[] to const char[] xxx. I forget to add return/parameter types as required by the new syntax. I'm really appreciate that you point out these problems

Use 1.8 compiler 1.7 you can use View_as<> without the brackets which was not ment to be

[Mr. Man]

Originally Posted by rikka0w0 "maps.phrases.txt" is used for localizing individual maps, e.g. c1m1_hotel to some human-readable name. If you don't want to localize them, it's completely fine. Create a file with the following content as the "maps.phrases.txt": PHP Code: "Phrases" { }  As a result, the maps will be shown as names like "c1m1_hotel". To localize map names, your "maps.phrases.txt" should be something like: PHP Code: "Phrases" {     "c1m1_hotel"     {         "en"        "Hotel"     } }  Sorry I forgot to mention this in the intro.

I have done that but the ingame still isn't parsing the menu correctly. Is it something on my end?

[rikka0w0]

Originally Posted by Mr. Man I have done that but the ingame still isn't parsing the menu correctly. Is it something on my end?

1. Check: is there a "mission.cache" folder in "left4dead2" directory? ("left4dead2" also contains "addons" and "cfg" folder)
2. If you are using Linux, permission can cause trouble, so make sure that "mission.cache" is writable by the current user (the one you used to launch srcds). Try "chmod -R 777 mission.cache"
3. A screen shot might be helpful

[Mr. Man]

Originally Posted by rikka0w0 1. Check: is there a "mission.cache" folder in "left4dead2" directory? ("left4dead2" also contains "addons" and "cfg" folder) 2. If you are using Linux, permission can cause trouble, so make sure that "mission.cache" is writable by the current user (the one you used to launch srcds). Try "chmod -R 777 mission.cache" 3. A screen shot might be helpful

No mission.cache file in the main directory. I'll get you a screenshot in a second. Here's what I see: