[asherkin]

This plugin fixes a rather silly bug in L4D2 where for some Steam Groups, setting sv_steamgroup correctly will link to a different Steam Group on the MOTD.

This is required for anyone with a Steam Group ID higher than 16777216 (and only for those people) for the Join Group button to work correctly.

Technical description:

Spoiler

ConVars in the L4D2 engine are represented by 3 internal values, a string value, a float value, and an int value. When you set and query a convar using the console or a config file it is the string value that is written and read. Setting one of these values sets the other two to appropriate values if applicable - so if the string value is set to "foo", the string value is "foo" and the int and float values are 0, if the value is "4.5" the string value is "4.5", the float value 4.5, and the int value 4. However, when setting the string value, the integer value is set from the float value, not directly.

The bug here is that floating point numbers have a range where they have integer precision that is much smaller than integer numbers. Single-precision floats (as used here) can represent accurate integers between -16,777,216 and 16,777,216 whereas a signed integer can represent between -2,147,483,648 and 2,147,483,647 - a significant difference! (a Steam Group ID is actually an unsigned integer, which is 0 to 4,294,967,295, but these are not currently supported in SourcePawn or in cvars in L4D2.)

This means that if your Steam Group ID is higher than 16777216, the integer value for sv_steamgroup is incorrect (it'll be either 2 or 4 numbers off in either direction depending on how much higher your group's ID is than the limit), and this is what the game uses to build the group URL on the MOTD.

This plugin parses the string value whenever sv_steamgroup is changed and sets the integer value to the correct number directly.

Enjoy!

[Tehcookeh]

Thanks again for your help solving the issue earlier in the previous thread. I'm sure there are other servers out there effected by Valve's goof. And now an easy fix!

[Sahrechiiz]

I put it in and restart the server.

sm plugins list shows it's fail to load.

59 <Failed> "sv_steamgroup fixer" (1.1.0) by asherkin

So i try to compile it on my server.

SourcePawn Compiler 1.6.3
Copyright (c) 1997-2006, ITB CompuPhase, (C)2004-2008 AlliedModders, LLC

sv_steamgroup_fixer.sp(4) : warning 207: unknown #pragma
sv_steamgroup_fixer.sp(4) : error 038: extra characters on line
sv_steamgroup_fixer.sp( : error 001: expected token: ";", but found "-identifier-"
sv_steamgroup_fixer.sp(14) : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(16) : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(1 : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(22) : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(25) : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(27) : error 010: invalid function or declaration
sv_steamgroup_fixer.sp(33) : error 001: expected token: ";", but found "-identifier-"
sv_steamgroup_fixer.sp(49) : error 021: symbol already defined: "void"
sv_steamgroup_fixer.sp(49) : error 017: undefined symbol "convar"
sv_steamgroup_fixer.sp(49) : error 029: invalid expression, assumed zero
sv_steamgroup_fixer.sp(49) : fatal error 127: too many error messages on one line

Compilation aborted.
13 Errors.

[asherkin]

Originally Posted by Sahrechiiz SourcePawn Compiler 1.6.3

Your SourceMod version is ancient and unsupported.

[Dwolff22]

MAte the plugin work only at the 1 campaing.if i change to another the group changes again to the wrong one =/

[PatriotGames]

Originally Posted by Dwolff22 MAte the plugin work only at the 1 campaign.if i change to another the group changes again to the wrong one =/

This is my experience too. Even on map change the "Join this servers steam group" link reverts back to the incorrect steam group. Hope you can address this issue because the plugin would be very helpful.

Cheers,

PG

[Sahrechiiz]

Finally got sometime to deal with my old server... I now use the latest stable release of sm.
After some testing. It's not working.(sm1.8.0.6035 mm1.10.7-dev)

[Visual77]

Originally Posted by PatriotGames This is my experience too. Even on map change the "Join this servers steam group" link reverts back to the incorrect steam group. Hope you can address this issue because the plugin would be very helpful. Cheers, PG

This might be a shot in the dark, but it could work. Add this to source file and recompile.

public void OnMapStart()
{
	FixSteamGroupId();
}

[DarkDeviL]

Originally Posted by Visual77 This might be a shot in the dark, but it could work. Add this to source file and recompile. public void OnMapStart() { FixSteamGroupId(); }

A call to "FixSteamGroupId();" from any kind of events where you find it "breaking it's functionality" may re-fix it again. ;)

If you believe you can afford the calculations on your system without eventually compromising the quality of your game server, you could even add it to be run more often using things like round start, player spawn, etc.

[peptobismal]

Originally Posted by Visual77 public void OnMapStart() { FixSteamGroupId(); }

I have found that the above does not seem to work... and it sometimes actually changes the Steam Group that I used to see to a completely different Steam Group.

So... I think reloading the FixSteamGroupId() on map start probably isn't a great idea if it's already "fixed"? Maybe? So I tried compiling it with OnMapStart() being closely resembling of OnPluginStart() and placing it above the OnSteamGroupChanged() or whatever function... this as well fails to compile and seems to be a bit more of a headache than necessary for such a simple plugin.

I think since I found that server.cfg is loaded every map start that a simple addition of "sm plugins reload sv_steamgroup_fixer" may be a better solution or might run into the same issue? I dunno, it's not exactly outputting or actually changing the sv_steamgroup in the config file... so, I guess I will try it out? Or maybe add an "exec <config file>" with this command (and other quick little sm commands that seem to be not changing permanently) in place so that I don't have to mess with it?