Quote:
Originally Posted by YamiKaitou
IMO, I find it easier to read the numbers than the letters in this case, ...
|
This is that kind of situation where each one should decide for himself. I prefer the enum because i prefer:
PHP Code:
for(new COORDINATES:j=X;j<COORDINATES;j++)
g_LastPositionData[id][i][j] = positionData[i][j]
or
PHP Code:
for(new COORDINATES:j=X;j<=Z;j++)
g_LastPositionData[id][i][j] = positionData[i][j]
to
PHP Code:
for(new j=0;j<3;j++)
g_LastPositionData[id][i][j] = positionData[i][j]
and
PHP Code:
g_LastPositionData[id][ANGLES][Y] = positionData[ANGLES][Y]
to
PHP Code:
g_LastPositionData[id][ANGLES][1] = positionData[ANGLES][1]
Quote:
Originally Posted by YamiKaitou
Using the enum is not required and will not have any effect on approval status (just mentioning this in case others believe otherwise)
|
I believe that in fact this plugin would be promptly approved even if Teddy didn't change a line to it since it seems to me that the idea is very original, and its well coded.
__
Teddy, other thing:
avoid to
return in the middle of the code.
Example:
Instead of:
PHP Code:
if(ago < RECLIMITER) return FMRES_IGNORED
rate = floatdiv(1.0,ago)
rate = floatmul(rate,48.0)
g_Rate[id] = floatround(rate);
pev(id,pev_origin,origin)
pev(id,pev_velocity,veloc)
...
make it:
PHP Code:
if(ago >= RECLIMITER)
{
rate = floatdiv(1.0,ago)
rate = floatmul(rate,48.0)
g_Rate[id] = floatround(rate);
pev(id,pev_origin,origin)
pev(id,pev_velocity,veloc)
pev(id,pev_angles,angles)
sequence = pev(id,pev_sequence)
gaitsequence = pev(id,pev_gaitsequence)
...
Its easier to see how the code flux.
__________________