[Adel]

Hello,

First, i searched on the forum and google for an answer but didn't get a solution.

My problem is the following:

I'm translating a plugin from old syntax to new syntax but i can't fix an error:

error 159: brackets after variable name indicate a fixed-size array, but size could not be determined - either specify sizes, an array initializer, or use dynamic syntax (such as 'char[] x')

I saw that i could this for instructions:

new String:temp[32]  become char[] temp = new char[32]

BUT nothing for functions, so how this could be fixed? (the 2nd parameter is the problem):

SomeFunc(int client, char buffer[][16], int target, char[] param1, char[] param2 = "")
{
    // Some stuffs
}

i tried these:

char[] buffer[16]
char[][16] buffer

but i have more errors:

/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/string.inc(97) : error 181: function argument named 'caseSensitive' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/string.inc(111) : error 181: function argument named 'caseSensitive' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/dbi.inc(442) : error 181: function argument named 'persistent' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/helpers.inc(155) : error 181: function argument named 'immunity' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/sdktools_sound.inc(425) : error 181: function argument named 'updatePos' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/sdktools_sound.inc(464) : error 181: function argument named 'updatePos' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/sdktools_sound.inc(563) : error 181: function argument named 'updatePos' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/sdktools_sound.inc(648) : error 181: function argument named 'updatePos' differs from prototype
/home/adel/srv_css/cstrike/addons/sourcemod/scripting/include/sdktools_sound.inc(684) : error 181: function argument named 'updatePos' differs from prototype

Anyone has a solution please?

(PS: it's the first time i use html tags, so if there is a pb, i'm sorry ;) )

[Mitchell]

new String:tempString[32];
became
char tempString[32];

String:anotherString[];
became
char[] anotherString;

Why do you define the length on the second dimension?
char[][] buffer

I'm more curious on the include errors that you posted, do you have everything up-to-date?

[Adel]

Hi mitchell, thx for your reply,

In fact i have a sp file and all its includes, the 2D array size is a choice of the plugin's author, i just try to translate.

With sm 1.6 branch, it compiled fine, but i had to update my server and then lot of errors appeared and as i wanted to modify a part of code, i decided to translate it all :/

[Powerlord]

Building on what Mitchell said, you can't specify just a single dimension in new style syntax. You have to either specify both or neither.

I may regret posting this part, but...

There are two types of arrays in Pawn: static (size is fixed during compile time) and dynamic (size is set at runtime).

In old style SourcePawn, they have identical syntax:

new Float:myFixedArray[MAXPLAYERS+1];
// Inside a method...
new Float:myDynamicArray[MaxClients+1];

However, they're different in new style syntax.

float myFixedArray[MAXPLAYERS+1];
// Inside a method...
float[] myDynamicArray = new float[MaxClients+1];

[Adel]

By removing the size, all is fine (i hope there will be no pb during tests ^^).

The function is now:

SomeFunc(int client, char[][] buffer, int target, char[] param1, char[] param2 = "") {     // Some stuffs }

But after read mitchell's and powerlord's replies, i don't understand when a size could be given in 2D arrays, unless there is no need to fix a size in a function prototype? :/
It existed in old syntax but doesn't exist on new syntax?

Thank you guys for your help, the error doesn't appear in the console while compiling, i just need an answer to the questions just above .

[Powerlord]

Originally Posted by Adel By removing the size, all is fine (i hope there will be no pb during tests ^^). The function is now: SomeFunc(int client, char[][] buffer, int target, char[] param1, char[] param2 = "") { // Some stuffs } But after read mitchell's and powerlord's replies, i don't understand when a size could be given in 2D arrays, unless there is no need to fix a size in a function prototype? :/ It existed in old syntax but doesn't exist on new syntax? Thank you guys for your help, the error doesn't appear in the console while compiling, i just need an answer to the questions just above .

Function prototypes usually use dynamic arrays. When new style syntax came out it actually caused problems with the VoteHandler callback, which you can see now has two signatures instead of just one. The reason being that it had 2D arrays where one dimension was static and one was dynamic, but new-style syntax doesn't support that.

Side note: If you want to see a callback that takes fixed-size arrays, see sdktools_sound's NormalSHook although the new-api site seems to strip that from the documentation.

[Adel]

Oh ok, THANK YOU very much for these explanations, i close the thread as my problem is solved ;)

[fakuivan]

Update your compiler, you need to search a little bit more ;u. char[][12] s_somevar works perfectly on 1.8.

[Adel]

Fakuivan, i use sourcemod 1.8 dev 5916, so my compiler is not the pb (even if there is a dev 5919, i don't think that a lot of things changed).
But thank you anyway .