[vitorrossi]

No, I had my configurations all messed up.
On a related note, would it be possible to add CVAR control to the number of the options on the menu, i.e. instead of always 1,2,3... if that could be changed to 5,6,7.. or any other combination.
The reason I ask is because players tend to press slots 1-4 often trying to change weapons, and a lot of the time people vote without meaning to.
I'm looking through the code and it seems that it might be tricky, but you are a lot more familiar with this code than me.
Thank you

[addons_zz]

Originally Posted by vitorrossi No, I had my configurations all messed up. On a related note, would it be possible to add CVAR control to the number of the options on the menu, i.e. instead of always 1,2,3... if that could be changed to 5,6,7.. or any other combination. The reason I ask is because players tend to press slots 1-4 often trying to change weapons, and a lot of the time people vote without meaning to. I'm looking through the code and it seems that it might be tricky, but you are a lot more familiar with this code than me. Thank you

Yes, i could do this more easily but I already implemented another features which I like most than shift the voting number from 1, 2, 3 to 6, 7, 8.

They are the cvars:

// Indicates whether there should be asked to the players if they want to
// participate the map vote to decide what the next map will be.
// 0 - disabled this feature
// 1 - enable this feature
gal_endofmapvote_ask 1

When using that feature, the players will be asked if they want to vote. They need to press 6 for yes and 0 for no. So they cannot press the wrong key.

Also, there is a new option:

// How the 'None' option should behavior when it is active.
// 0 - Hide after the user voted on some option.
// 1 - Always keep showing
// 2 - Convert it to 'Cancel Last Vote' option, to allow only 'one time cancel' vote opportunity.
gal_vote_show_none_type 2

Then, when you vote on the wrong option because you pressed the wrong key, you just need to press 0 and your vote will be undone, hence you can vote again. (You can undo your vote only one time).

Even with all that, you still thinking it is necessary to shift the voting numbers from 1, 2, 3 to 6, 7, 8? Can I add that, into the to do list?


But if you want to do it yourself, I suggest to clone the github repository and to work and the develop branch pulling updates, because they received more code fix and has the reading more improved than the last stable release. I think that to implement it on the code, you need to change the keys registration and its interpretation. Look into 'vote_handleChoice(2)' and 'vote_display(1)'. [the number 2 and 1 means a function which receive 2 and 1 parameters].

[vitorrossi]

Configuring as you mentioned seems to have kind of the same effect, I guess it's just preference after that. I will likely use these configurations instead of attempting to change the code. Thank you.

[addons_zz]

Originally Posted by vitorrossi Configuring as you mentioned seems to have kind of the same effect, I guess it's just preference after that. I will likely use these configurations instead of attempting to change the code. Thank you.

You are welcome. And about these settings, I think they advantage against shifting the number, is that you can keep a vote within more maps as you still have all the keys available.

[gabuch2]

Hello addons_zz

I have some suggestions for the "recent maps" feature.

Is it possible to increase the recent maps limit? Currently the limit is 16 maps.
Also, there's no check when adding maps to the recent map list, if a map is played twice, it will be added two times in the list. And if a map doesn't belong in the mapcycle, it will be added to the recent map list anyway.

Thanks in advance.

[addons_zz]

Originally Posted by Shattered Heart Lynx Hello addons_zz I have some suggestions for the "recent maps" feature. Is it possible to increase the recent maps limit? Currently the limit is 16 maps. Also, there's no check when adding maps to the recent map list, if a map is played twice, it will be added two times in the list. And if a map doesn't belong in the mapcycle, it will be added to the recent map list anyway. Thanks in advance.

Hi Shattered Heart Lynx,

Sure, I added it to the TODO list. On the next version this will be fixed and that will be unlimited. For now, I think you can change the constant:

#define MAX_RECENT_MAP_COUNT 16 

Without any problems.

******************************** TODO Go to top *********************************

Spoiler

1. [SUG]
   The Maintenance Mode
   If the owner of the server is fixing something or updating the server and doesn't wanna the map
   to be changed he will enable the cvar maintenance so the map will can't be changed by any method
   like gal_startvote/rtv/timeleft or maxrounds ended... and he will display print chat some thing
   like that: you cannot change the map when the server is in mode maintenance
   
2. [SUG]
   first you need enable cvar to this feature...
   if the half of the timeleft/roundsleft passed and the server crashed
   if the enable cvar is 1 the server will not change to the last map
   if the enable cvar is 2 the server will start a vote without changing the map
   if the enable cvar is 3 the server will start a vote after the half of the timeleft/roundsleft passed
   
3. [SUG]
   Maps are commonly repeated on the vote and there is no chance for all of them I've got on server
   to get to play on. Which is why I'm using gal_banrecent to ban these 1000+ maps. Because of this,
   players can't nominate maps for few days . My proposition is adding a file to the plug in, in which
   will be saved map history and a bunch of recent maps won't be able to get voted (but still be able
   to get nominated).
   
   

4. Originally Posted by waynesmith15 Hi, A few problems I have had in the last few weeks of running this is below. 1. The Map Vote Functions fail to run when the Player Kill count mp_fraglimit is reached. - My suggestion to fix this would be to have the Vote start at the start a few mins after the start of a new map. Or for the Mod to read mp_fraglimit and when it gets within say a set number of kills auto start the voting system. 2. When extending the map time it fails to do another vote. When the time limit expires it will then changes to the default next map. May have a bad setting here. 3. I would like to be able to disable the "Time Limit Expired" and just end the map when the timer is up. ( Really not an important thing and can cope with it TBH ) May be again I have a setting wrong for this. Thanks for your time with this. Way.

   1) The 'mp_fraglimit' was not supported (half-life), but I will provide support to it on the next version.
   Done: Implemented the 'mp_fraglimit' core functionning.
   TODO: Eliminate the variables g_isMaxfragsExtend, g_isMaxroundsExtend, and others like and to replace it by an enum.
   TODO: Add credits from each report.
   
   2) Bad settings must not block the second voting after an map extension. I will look into the code and
   see what is happening.
   3) You are using Half-Life and the setting "gal_endonround" is set to 1 or 2 and is it ending the map
   when the time runs out, instead of waiting to finish the map after the current round end?
   
   
   

5. Originally Posted by vase070 i thing i noticed something so when using "gal_vote_minplayers_mapfile" when vote comes and no one chooses any map the plugin will choose a completely random map that is not on the "gal_vote_minplayers_mapfile" is this supposed to be like this ? is the plugin not supposed to choose a random map from the vote itself and set it as next when no one votes or am i wrong ? pictures : when vote comes : http://i.imgur.com/a4U950P.jpg when vote ended and no one choose any map : http://i.imgur.com/XbFwXl4.jpg as you can see de_train was not on the vote the same thing is with "gal_emptyserver_mapfile" when no one is on the server and vote prob comes plugin still chooses random map that is not on the "gal_emptyserver_mapfile"

   1) When there is anyone in the server, the voting do not comes up.
   2) It just says "will choose a completely random map", when you have this setting below "amx_extendmap_allow_order"
   set to 1, it is actually following the map cycle. It shows "will choose a completely random map", for
   the setting set to 1 because I did not to write a new LANG (language) for this. But, to end this confusion,
   I will to add a new language constant saying that it is following the map cycle, when it is following the
   map cycle, instead of just saying "will choose a completely random map":
   

   // If 0, choose a random map as next map, when anyone vote for next map.
   // If 1, follow the map cycle map order, when anyone vote for next map.
   amx_extendmap_allow_order 1

   3) When your server is on the empty cycle mode, it does not start a map vote, and it does not follow you map
   cycle, despite the setting "amx_extendmap_allow_order " above. It starts following your empty cycle map file list.
   
   
6. Replace:
   enum (+= 100000) // task ids are 100000 apart
   {
   TASK_ID_1 = 100000, // start with 100000
   TASK_ID_2,
   TASK_ID_3
   }
   
   
   

7. Originally Posted by chaves I found another bug, can just be with my server but I am coming to pass, sometimes the server does not obey "gal_emptyserver_wait 5" keeping empty server random maps

   Thanks for sharing. I think it is not possible this bug happens just with you. So, I will add it up to the
   TODO list to be verified and fixed until the next version release.
   
   
8. Quote:
   Originally Posted by addons_zz
   If you want to, I can add a configuration to the whitelist feature, to also block all maps that are not
   included on the 'gal_vote_minplayers_mapfile' map file list hourly rule, at the next plugin version.
   Yes.
   
   
9. Also distribute the original v1.1.290 configuration file as optional for download.
   
   

10. Originally Posted by emoto2 Hello, i use 2.6 version of plugin.. but i know whats is the my problem.. this cvar gal_srv_start when 1 the plugin not working correctly and change timeleft to: no time limit... I tested .. server start and work normally when stopped or server crash next time timeleft is changet to: no time limit permanently! Now i use gal_srv_start 0 and no have problems. +++ Tested new bug ... when change cvar options in .sma and remove this code lines: PHP Code:     server_cmd( "exec %s/galileo.cfg", DIR_CONFIGS_PATH );     server_exec();  plugins have no time limit bug above. +++2 Fixed small code lines for show messages for admin voting: PHP Code: color_print( player_id, "^1L", player_id, "GAL_VOTE_WEIGHTED", voteWeight );  ---> PHP Code: color_print( player_id, "^1%L", player_id, "GAL_VOTE_WEIGHTED", voteWeight );

    Note: His credits are already added.
    
    Thank you for you efforts and sharing your work. The LANG misspelling is fixed on the dev version.
    
    When I can, I will take a close look on this 'gal_srv_start' and when change cvar options in .sma and remove this code lines:
    
    PHP Code:

        server_cmd( "exec %s/galileo.cfg", DIR_CONFIGS_PATH );
    server_exec(); 

    plugins have no time limit bug above.
    
    
    
11. a) Insert the new debug level 128 for function entrances: "I AM ENTERING ON 'function_name(0)' | parameter1: %s",
    And add it to all plugin functions.
    
    b) Also add to its proper levels, where the plugin is changing the game cvars, i.e.,
    track all cvars changes by this plugins and print out to its debugging level
    "( function_name ) | IS CHANGING THE CVAR 'cvars_name' to 'value'".
    
    c) Replace all server_cmd's by set_pcvar's. Example:
    >server_cmd( "mp_timelimit %f", g_originalTimelimit );
    >>set_pcvar_float( cvar_mp_timelimit, g_originalTimelimit );
    
    d) Added also, debuggin information to all return statements inside functions. Example:
    ...
    else
    {
    mapIndex = getSurMapNameIndex( firstWord );
    
    if( mapIndex >= 0 )
    {
    nomination_toggle( player_id, mapIndex );
    
    DEBUG_LOGGER( 1, " Returning PLUGIN_HANDLED on 'mapIndex >= 0'." );
    return PLUGIN_HANDLED;
    }
    else if( strlen( firstWord ) > 5
    ...
    
    
    
12. Fix the code formatter 'format_code.bat' not formatting properly anymore.
    
    
    

13. Originally Posted by Shattered Heart Lynx Hello addons_zz I have some suggestions for the "recent maps" feature. Is it possible to increase the recent maps limit? Currently the limit is 16 maps. Also, there's no check when adding maps to the recent map list, if a map is played twice, it will be added two times in the list. And if a map doesn't belong in the mapcycle, it will be added to the recent map list anyway. Thanks in advance.

    Sure, I added it to the TODO list. On the next version this will be fixed and that will be unlimited. For now, I think you can change the constant:
    

    #define MAX_RECENT_MAP_COUNT 16 

    Without any problems.
    
    
    

[Godofwar]

can anyone pls tell me where and which thing i can change the Nominate of players needed... i want that Plugin need 15 players to start the mapvote... This file is so big :S

other problem is that the plugin give me maps for votemap what is not addded in my maps.ini file -- how and why??? Plugin crashed my SV when Map is not in the maps.ini :S

[addons_zz]

Originally Posted by Godofwar can anyone pls tell me where and which thing i can change the Nominate of players needed... i want that Plugin need 15 players to start the mapvote... This file is so big :S

See the cvars 'gal_rtv_ratio' on the config file.

Originally Posted by Godofwar other problem is that the plugin give me maps for votemap what is not addded in my maps.ini file -- how and why??? Plugin crashed my SV when Map is not in the maps.ini :S

This plugin ignores the 'AMXX' maps.ini, it reads your 'mapcyclefile' cvar by default, so, change your server cvar 'mapcyclefile' to your 'maps.ini'. It is usually:

mapcyclefile "addons/amxmodx/configs/maps.ini"

See also these cvars on the galileo config file, for control the nominations map list, etc:

gal_vote_mapfile
gal_vote_minplayers_mapfile
gal_nom_mapfile
gal_emptyserver_mapfile

If this config file is too big, you can replace yours with this default one.

Originally Posted by Godofwar other problem is that the plugin give me maps for votemap what is not addded in my maps.ini file -- how and why??? Plugin crashed my SV when Map is not in the maps.ini :S

It crashed you server?
Install this version (only needed the new galileo.amxx compiled file): https://github.com/addonszz/Galileo/archive/develop.zip

And send me by PM, or post here the file '_galileo.log' at the folder 'addons/amxmodx/logs'.
The file '_galileo.log' will be created after you run the version I am sending here.
The file '_galileo.log' will be very helpful to find out why it is not working.
You current version is not creating the file '_galileo.log', only the version I am sending here on the above link has it.

[Agression Terrpr]

How to change Client's Commands ?

[addons_zz]

Originally Posted by Agression Terrpr How to change Client's Commands ?

Such thing depends on what command do you want to change and how/what you want to change.

Look into these lines for the cmd_say handler:
https://github.com/addonszz/Galileo/blob/713b7ee9702482c815d0ea96b2d1c0fde78bb438/scripting/galileo.sma#L2449-L2574

Also search for 'register_clcmd' for other commands.