[superaconi]

How to install it I put everything for linux on its place and its not enabled?

[Dr!fter]

If nothing uses the extension it won't load

[Alienmario]

Running without SDKHooks crashes the server; only running simplest plugin "#include <dhooks>"

L 02/15/2016 - 18:20:40: -------- Mapchange to dm_overwatch -------- L 02/15/2016 - 18:20:40: [SM] Unable to load extension "sdkhooks.ext": The specified module could not be found. ..\tier1\fileio.cpp (4022) : Assertion Failed: CFileWriterThread: pending file writer connection_log_27015.txt Assert( Assertion Failed: CFileWriterThread: pending file writer connection_log_27015.txt ):..\tier1\fileio.cpp:4022 threadtools.cpp (3643) : Assertion Failed: Illegal termination of worker thread 'CFileWriterThread'

Event viewer:

Exception code: 0xc0000005 Fault offset: 0x00002767 Faulting process ID: 0xac8 Faulting application start time: 0x01d1681590babac0 Faulting application path: C:\server\hl2dm\srcds.exe Faulting module path: c:\server\hl2dm\bin\datacache.dll

I thought fixing that could help some other weird crashes that I'm having while hooking functions that SDKHooks already hook, like
CHL2MP_Player::FireBullets ( const FireBulletsInfo_t &info ) which crashes on first call after the plugin has been reloaded while passing by value (wrong, but works until reload) or first call when passing by reference (correct way but always crashes).
Event log of that looks weird

Faulting application name: srcds.exe, version: 0.0.0.0, time stamp: 0x56130401 Faulting module name: dbi.sqlite.ext.dll, version: 1.7.3.0, time stamp: 0x56a6ce68 Faulting module path: C:\server\hl2dm\hl2mp\addons\sourcemod\extens ions\dbi.sqlite.ext.dll

Anyway, the hook works and I can access the data, the only thing is that my plugin can't be hot-reloaded when updating
Thanks again for this extension
One thing I can think of that would make this extension better is a bool indicating whether or not it is a post hook in the callbacks.

[asherkin]

DHooks requires SDKHooks, SDKTools, and BinTools to function.
It should probably fail to load rather than crash, but it will not work without them.

Your hook is probably incorrect, and thus other consumers are ending up with bad data.
JIT error handling (as used for the event logs) always fails with SRCDS due to the built-in crash handlers, use Accelerator if you want reliable crash information.

[Powerlord]

Originally Posted by asherkin DHooks requires SDKHooks, SDKTools, and BinTools to function. It should probably fail to load rather than crash, but it will not work without them.

I haven't worked on DHooks in a while, but I thought one of the changes I made for DHooks 2 was to make it fail to load instead of crash when its dependencies weren't present.

I mean, looking at the code, you can see

bool DHooks::QueryRunning(char *error, size_t maxlength)
{
	SM_CHECK_IFACE(SDKTOOLS, g_pSDKTools);
	SM_CHECK_IFACE(BINTOOLS, g_pBinTools);
	SM_CHECK_IFACE(SDKHOOKS, g_pSDKHooks);
	return true;
}

Maybe some null checks needs to happen in DHooks::SDK_OnAllLoaded after the SM_GET_LATE_IFACE calls?

[Smoke123]

Loading up the new nuke and it's crashing with this plugin and im getting a server restart. Unsure if this is the proper place to post this

L 02/17/2016 - 00:26:02: SourceMod log file session started (file "L20160217.log") (Version "1.7.3-dev+5280")
L 02/17/2016 - 00:26:02: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 00:26:03: [deathmatch.smx] Dynamic Hooks not found! Resuming without Dhooks features
L 02/17/2016 - 14:00:22: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 14:043: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 16:46:11: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 201:11: SourceMod log file session started (file "L20160217.log") (Version "1.7.3-dev+5280")
L 02/17/2016 - 201:11: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 201:17: [deathmatch.smx] Dynamic Hooks not found! Resuming without Dhooks features
L 02/17/2016 - 20:56:18: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 21:40:46: -------- Mapchange to de_dust2 --------
L 02/17/2016 - 22:14:25: -------- Mapchange to de_dust2 --------

[asherkin]

Considering the only thing in your error log is about not using DHooks, no, the DHooks thread is not a remotely sane place to post that.

[Mitchell]

Dhooks works fine with the new update. Can confirm. (windows)
heres a line out of the log

L 02/18/2016 - 02:24:54: [DHooks] working great. thanks.

[Crowii]

One thing that's always scared me about this plugin;

How exactly do I install this?
I can work through the sourcemod folder area, but I have no clue about the other folders and files.
Never heard of .cpp, .h, m.py, .rc, etc. ;-;

[asherkin]

Originally Posted by Crowii One thing that's always scared me about this plugin; How exactly do I install this? I can work through the sourcemod folder area, but I have no clue about the other folders and files. Never heard of .cpp, .h, m.py, .rc, etc. ;-;

I suggest downloading the builds rather than the source code.