[Tirant]

It's a lot cleaner now that I've re-written the printf-like-logic. I decided to go with a different method which parses the string and then uses the same log based on the printf flags. This should be a lot easier to maintain or add new specifiers.

I added more detailed parser error reporting and validation of the format in the params. If an invalid format is used (e.g., when creating a Logger), then the error message will look something like:

L 09/17/2015 - 01:37:15: [LOGGER] Invalid logger name format provided: "[%5s] [%-6.4e] %n::%f %l" (position 8 = "%-6.4e")
L 09/17/2015 - 01:37:15: [AMXX] Displaying debug trace (plugin "test.amxx", version "unknown")
L 09/17/2015 - 01:37:15: [AMXX] Run time error 10: native error (native "LoggerCreate")
L 09/17/2015 - 01:37:15: [AMXX]    [0] test.sma::plugin_init (line 5)

I could/might take it a step further and enumerate the errors a bit, e.g., "Invalid specifier 'e' used" in the above case, however I believe this might be unnecessary. I'll create an FR for it though.

Let me know what you guys think, do you think LoggerModule will be of any use to you?

[klippy]

It's funny how this thread almost evolved into Tirant's personal blog.

I love the idea, it could be useful. Anything that makes debugging easier is great.

[Tirant]

Just like to keep people updated

I'm really looking for ideas or what other people want too. I'm trying not to base this completely around just my own needs and create something that is customizable.

Minus stack traces, it's pretty much ready to use. I just want to integrate a couple of calls into AMXX (e.g., so ERROR severity will also propagate to AMXX and be reported in the AMXX logs)

[klippy]

Do you know how to implement the stack trace within AMXX? Yes, it would be a very useful feature.

[Tirant]

Not yet. I should be able to create one from a pointer somewhere though. This mod should be compatible with the current amxx build, so I might create a pull request if people want it added. If it was directly integrated, it world be a lot easier, because then I'd have access to the amxx functions

[Tirant]

I think that I will merge this module with the core AMXX in order to get the visibility I need to those functions. I think that's just a better change overall, because I've already had to copy over some of the API.

[klippy]

What exactly do you need from AMXX core in your project? Because some of its core functions are already exported.

[Tirant]

I know. I require most if not all of the debugging classes, which don't seem to be exported. I can cut out the classes, similar to what I have done for CPlugin, but there seem to be significantly more dependencies for the debugger, so I think it's tightly coupled (which makes sense since it's the debugger).

[Tirant]

I just finished integrating it. I really wasn't that bad. I'm going to work on adding the stack traces tomorrow.

[Tirant]

I added stack traces. I'm going to look at it a bit more to see if there any obvious improvements, but I think it's ready for a pull request.

I am also working on adding a cvar manager to manage the logger verbosities. Right now it only manages the global verbosity setting, however I'm going to add a forward to make it manage individual loggers as well, e.g., logger_%s_verbosity, where %s is the logger name. This is just to make it more convenient for servers running a plugin which uses this, as they may want to disable logging altogether.

Additionally, the default severities (verbosities) are:
[They are intended to be extensible, however numbers within the range belong to that verbosity, e.g., [301, INF) = ERROR, [201, 301) = WARN, etc.). In other words, you can specify your own severities in addition to the default ones]

enum Severity {
    Severity_Invalid = -1,
    Severity_None    = 0,
    Severity_Debug   = 1,
    Severity_Lowest  = Severity_Debug,
    Severity_Info    = 101,
    Severity_Warn    = 201,
    Severity_Error   = 301,
    Severity_Highest = Severity_Error
};

Current specifiers:

d date
f function
i counter (increments when the map changes, resets after midnight)
l line #
m map
n script name (e.g., plugin.sma)
p plugin name (e.g., plugin) [i.e., plugin.amxx without *.amxx]
s message
t time
v verbosity (or severity) [e.g., INFO, DEBUG, WARN, ERROR]
% %

Here is the native decl to create a logger

native Logger:LoggerCreate(
        const Severity:verbosity = Severity_Warn,
        const nameFormat[]  = "%p_%d",
        const msgFormat[]   = "[%5v] [%t] %n::%f - %s",
        const dateFormat[]  = "%Y-%m-%d",
        const timeFormat[]  = "%H:%M:%S",
        const pathFormat[]  = "",
        const traceFormat[] = "    at %n::%f : %l");

Please let me know if you have any suggestions or ideas.