[DarkDeviL]

If you made a mistake, you can just edit your post instead of deleting and posting again..

I think the way you handle your variable is incorrect and could eventually cause trouble if two people are being banned at (almost) the same time.

If two bans occurs at the exact same time (which ... they probably don't, but still), then there would be a chance that your timers only use the IP of the last ban.

Timers > Passing Data

[Sdg]

How would you do it correctly?
Is there another way?

I can shorten the timers to "0.3" to decrease the margin of error if another ban ocurred at the same time...

Sorry if my english is bad!

[DarkDeviL]

You can see a full explanation on passing parameters through timers at the link I gave you above.

Also, if you are doing it that way, you do not need to have multiple timer callbacks, you can pass the time towards the callback.

public Action:OnBanClient(client, time, flags, const String:reason[], const String:kick_message[], const String:command[], any:admin)
{
    new String:ip[46];
    GetClientIP(client, ip, sizeof(ip));
    new Handle:timerPack;

    CreateDataTimer(1.0, Timer_OnBanClient, timerPack);
    WritePackString(timerPack, ip);
    WritePackCell(timerPack, time);

    if (StrEqual(command, "SMAC"))
    {
        PrintToChatAll("[SMAC] %N Banned. (%s) ", client, reason);
    }
}

public Action:Timer_OnBanClient(Handle:timer, Handle:timerPack)
{
    new String:ip[46];
    new time;
    ResetPack(timerPack);
    ReadPackString(timerPack, ip, sizeof(ip));
    time = ReadPackCell(timerPack);

    if (time == 0)
    {
        ServerCommand("sm_banip %s 8000", ip);
    }
    else
    {
        ServerCommand("sm_banip %s 5", ip);
    }
}

NOTE: The time in OnBanClient will not be accurate together with SourceBans, as SourceBans only bans the client for 5 minutes, and then re-checks its database if a client returns after that (while his/her ban is still valid).

[WildCard65]

y not use BanIdentity?

PHP Code:

public Action OnBanClient(int client, int time, int flags, const char[] reason, const char[] kick_message, const char[] command, any admin)
{
    char ip[46];
    GetClientIP(client, ip, sizeof(ip));
    BanIdentity(ip, time == 0 ? 8000 : 5, BANFLAG_IP, reason);
    if (StrEqual(command, "SMAC"))
        PrintToChatAll("[SMAC] %N Banned. (%s) ", client, reason);
    return Plugin_Continue;
} 


[DarkDeviL]

Originally Posted by WildCard65 y not use BanIdentity? PHP Code: public Action OnBanClient(int client, int time, int flags, const char[] reason, const char[] kick_message, const char[] command, any admin) {     char[] ip[46];     GetClientIP(client, ip, sizeof(ip));     BanIdentity(ip, time == 0 ? 8000 : 5, BANFLAG_IP, reason);     if (StrEqual(command, "SMAC"))         PrintToChatAll("[SMAC] %N Banned. (%s) ", client, reason);     return Plugin_Continue; }

I just re-built his original code.

But you're right, BanIdentity is more simple, and requires less code than the other.

[Sdg]

Thanks guys!

If i take code from WildCard65, I'm having the same problem as before unable to change the message (Added to banned list.), Right?
On the other hand, when I compile this, shoot me some errors.

Arne1288, I testing your code, seems to work fine!

[Sdg]

Wild:

I get the following errors when trying to compile this.

Originally Posted by WildCard65 y not use BanIdentity? PHP Code: public Action OnBanClient(int client, int time, int flags, const char[] reason, const char[] kick_message, const char[] command, any admin) {     char[] ip[46];     GetClientIP(client, ip, sizeof(ip));     BanIdentity(ip, time == 0 ? 8000 : 5, BANFLAG_IP, reason);     if (StrEqual(command, "SMAC"))         PrintToChatAll("[SMAC] %N Banned. (%s) ", client, reason);     return Plugin_Continue; }

symbol already defined: "Action"
symbol already defined: "PrintToChatAll"
symbol is never used "OnBanClient"

[WildCard65]

I wrote it in 1.7 syntax.

[Sdg]

Originally Posted by WildCard65 I wrote it in 1.7 syntax.

SourcePawn Compiler 1.7.0-manual
plugin.sp(17) : error 140: new-style array types cannot specify dimension sizes as part of their type
plugin.sp(17) : warning 215: expression has no effect
plugin.sp(17) : error 001: expected token: ";", but found "]"
plugin.sp(17) : error 029: invalid expression, assumed zero
plugin.sp(17) : fatal error 187: too many error messages on one line

[Sdg]

You know why this line not appear?

PHP Code:

PrintToConsole(client, "========== Test ============\nNombre:  %N\n SteamID: %s \n IP: %s /n========== Test ============\n", client,  sAuthID, ip);