This may require extensive recoding to get into a workable state. Someone pointed out some errors in the original thread that I'm not sure are still applicable, but if you are recoding, look out for these:
Quote:
- The keysadded variable is incremented when a key is added (L:119) but it is not decremented when a key is removed (It just impacts the message that is sent to the bot owner)
- When the trade is finished, and items other than keys are added, the bot attemts to inform the trade partner, that the bot only accepts keys (L:211)
- The bot runs the create table query on every successful trade (L:209 ) instead of only once when the bot is initialized. (L:26)
- A new mysql connection is created everytime a trade is successful (L:179 ) but the connections are never closed
- Only keys are recorded in the donation table, all other traded items are not recorded
|
As well, email trade confirmations may be a problem when using this bot. There is a high potential for someone to not confirm the trade if they know the bot will still go through with the donation handling.
I'm not sure if Jessecar's SteamBOT has been updated yet to handle this.