[D.Moder]

I'm trying to make my mod a bit lighter by using variables instead of natives

I need to make sure they are very accurate.

PHP Code:


// turn these

IsClientInGame(client)
IsPlayerAlive(client)
GetClientTeam(client)

// to

g_ingame[]
g_isalive[]
g_team[] 


[Darkness_]

...Why?

How is doing this lighter on the mod?

PHP Code:

new bool:g_ingame[MAXPLAYERS + 1];
new bool:g_isalive[MAXPLAYERS + 1];
new g_team[MAXPLAYERS + 1];

for (new i = 1; i <= MaxClients; i++) {
    if (!IsClientInGame(i))
        continue;
    g_ingame[i] = IsClientInGame(i);
    g_isalive[i] = IsPlayerAlive(i);
    g_team[i] = GetClientTeam(i);
} 


[Powerlord]

To add to what Darkness_ said....

• IsClientInGame is likely just a check if an entity exists
• IsPlayerAlive is likely just a netprop check
• GetClientTeam is likely just fetching the value of a netprop.

None of these are operations are that expensive.

(Note: These say likely because I'd have to look through the SDK to verify it and I haven't)

[TnTSCS]

IsPlayerAlive: https://mxr.alliedmods.net/sourcemod...nager.cpp#2507 - netprop check

The others, I'm too lazy to check exact links, but powerlord is correct... very cheap calls

[KissLick]

But mainly, you would have to cache these values on every event, that might change them (a lot of space to miss something) and it would make your code less readable.

Just use functions, this is not something you should try to optimize.

[TnTSCS]

If you wanted to bunch up all three of those checks into one, here's a very simplified way:

PHP Code:

public MyFunction(client)
{
    if (PlayerInGameAliveOnTeam(client, 2))
    {
        // Act on player
    }
    else
    {
        // Player either isn't in game, not on team specified, or not alive
    }
}

bool:PlayerInGameAliveOnTeam(client, team)
{
    if (IsClientInGame(client) && GetClientTeam(client) == team)
    {
        return IsPlayerAlive(client);
    }
    
    return false;
} 


[D.Moder]

Originally Posted by TnTSCS If you wanted to bunch up all three of those checks into one, here's a very simplified way:

that's not what I meant, I'm going to use each of those vars in different areas of code, but now as most of you guys say, those functions aren't that expensive, so I think I'll just use the natives then.

[WildCard65]

IsClientInGame: https://github.com/alliedmodders/sou...ayers.cpp#L456
GetClientTeam: https://github.com/alliedmodders/sou...ayers.cpp#L768