 |
|
AMX Mod X Plugin Approver
|

10-22-2014
, 13:58
Re: Weapons Resources Replacement[ OKAPI ]
|
#11
|
Quote:
Originally Posted by HamletEagle
I'm sure you still have a lot of suggestions.
|
Of course, like:
- You did not care to test properly your code before releasing it. Like the first okapi_mod_replace_string which is out of loop...
(EDIT: looking at your previous post, you probably fixed that)
- You use 2 copy... but why not using directly arrayData in parse?
- I'm not sure why you check for .mdl / .spr ; this doesn't seem useful.
- Well, about sound/, I told you have 2 ways, but honestly this makes more sense and is more consistent that user has to add sound/ in config file, like he has to add models/ and /sprites. This also simplify your code.
- You should rewrite your description in first post. This is kind of incomplete, not really clear, with some pointless sentences. You should also clearly list the pros and cons of your plugin (for example pros: you have probably work for all mods, the most efficient method, can replace any entity resources ; and cons: probably the limit about length which could be a pain, global (can't be done per-player, etc.), possible incompatibility with plugins which check the original model name, etc.). This is important to an admin to understand at first glance whether this plugin is suitable for their needs. So please take time to properly elaborate your plugin description.
__________________
Last edited by Arkshine; 10-22-2014 at 14:00.
|
|
|
|