Raised This Month: $ Target: $400
 0% 

[TF2] Unused High-Five Responses


Post New Thread Reply   
 
Thread Tools Display Modes
Author
Pelipoika
Veteran Member
Join Date: May 2012
Location: Inside
Plugin ID:
4246
Plugin Version:
Plugin Category:
General Purpose
Plugin Game:
Team Fortress 2
Plugin Dependencies:
    Servers with this Plugin:
     
    Plugin Description:
    Old 06-15-2014 , 11:59   [TF2] Unused High-Five Responses
    Reply With Quote #1

    Simply enables these

    Just plonk it in your servers plugins folders and restart the server/whatnot and the plugin should work.

    Changelog:
    - 1.0 : Initial release
    - 1.1 : Fixed errors.. Maybe?
    Attached Files
    File Type: sp Get Plugin or Get Source (slapmyhand.sp - 1398 views - 2.4 KB)
    __________________

    Last edited by Pelipoika; 06-20-2014 at 10:11. Reason: Updates
    Pelipoika is offline
    Darkborn
    Junior Member
    Join Date: Jul 2011
    Old 06-16-2014 , 00:34   Re: [TF2] Unused High-Five Responses
    Reply With Quote #2

    I can dig it. It's nice to see unused content being used. My only issue is that the sound doesn't move the mouth. Is it possible to be able to fix that at any point?
    Darkborn is offline
    Drixevel
    AlliedModders Donor
    Join Date: Sep 2009
    Location: Somewhere headbangin'
    Old 06-20-2014 , 08:33   Re: [TF2] Unused High-Five Responses
    Reply With Quote #3

    Code:
    L 06/20/2014 - 07:20:22: [SM] Native "GetEntProp" reported: Entity 4 (4) is invalid
    L 06/20/2014 - 07:20:22: [SM] Displaying call stack trace for plugin "slapmyhand.smx":
    L 06/20/2014 - 07:20:22: [SM]   [0]  Line 328, /groups/sourcemod/compiler-1.5/include/tf2_stocks.inc::TF2_GetPlayerClass()
    L 06/20/2014 - 07:20:22: [SM]   [1]  Line 49, /home/forums/content/files/1/8/1/7/3/0/134540.attach::Sound()
    Drixevel is offline
    Powerlord
    AlliedModders Donor
    Join Date: Jun 2008
    Location: Seduce Me!
    Old 06-20-2014 , 09:55   Re: [TF2] Unused High-Five Responses
    Reply With Quote #4

    Quote:
    Originally Posted by r3dw3r3w0lf View Post
    Code:
    L 06/20/2014 - 07:20:22: [SM] Native "GetEntProp" reported: Entity 4 (4) is invalid
    L 06/20/2014 - 07:20:22: [SM] Displaying call stack trace for plugin "slapmyhand.smx":
    L 06/20/2014 - 07:20:22: [SM]   [0]  Line 328, /groups/sourcemod/compiler-1.5/include/tf2_stocks.inc::TF2_GetPlayerClass()
    L 06/20/2014 - 07:20:22: [SM]   [1]  Line 49, /home/forums/content/files/1/8/1/7/3/0/134540.attach::Sound()
    Took a quick glance... looks like this line:

    Code:
    if (IsValidEntity(ent) && ent < 1 || ent > MaxClients || channel < 1)
    needs to be rewritten... my first attempt to rewrite it was wrong... thinking about it now.

    Code:
    if (!IsValidEntity(ent) || ent < 1 || ent > MaxClients || channel < 1)
    This way, if the entity isn't valid, it doesn't try to fetch said entity's player class.

    A IsClientInGame check might not hurt too, since any EmitSound calls pass through this with afaik no guarantee that the ent argument is correct.
    __________________
    Not currently working on SourceMod plugin development.

    Last edited by Powerlord; 06-20-2014 at 10:01.
    Powerlord is offline
    Drixevel
    AlliedModders Donor
    Join Date: Sep 2009
    Location: Somewhere headbangin'
    Old 06-20-2014 , 18:51   Re: [TF2] Unused High-Five Responses
    Reply With Quote #5

    Quote:
    Originally Posted by Powerlord View Post
    Took a quick glance... looks like this line:

    Code:
    if (IsValidEntity(ent) && ent < 1 || ent > MaxClients || channel < 1)
    needs to be rewritten... my first attempt to rewrite it was wrong... thinking about it now.

    Code:
    if (!IsValidEntity(ent) || ent < 1 || ent > MaxClients || channel < 1)
    This way, if the entity isn't valid, it doesn't try to fetch said entity's player class.

    A IsClientInGame check might not hurt too, since any EmitSound calls pass through this with afaik no guarantee that the ent argument is correct.
    I fixed it on my server, I was just posting it here so he can fix it for others. I just did a client is in-game/alive check, lot simpler.

    Last edited by Drixevel; 06-20-2014 at 18:52.
    Drixevel is offline
    Reply



    Posting Rules
    You may not post new threads
    You may not post replies
    You may not post attachments
    You may not edit your posts

    BB code is On
    Smilies are On
    [IMG] code is On
    HTML code is Off

    Forum Jump


    All times are GMT -4. The time now is 21:27.


    Powered by vBulletin®
    Copyright ©2000 - 2024, vBulletin Solutions, Inc.
    Theme made by Freecode