[blaacky]

PHP Code:

#include <sourcemod>

new    Handle:g_Array;

public OnPluginStart()
{
    g_Array = CreateArray();
    
    for(new i=0; i < 10000; i++)
    {
        PushArrayCell(g_Array, i);
    }
    
    g_Array = CreateArray();
} 


Would this cause memory leaks? If so, what is a good way to avoid it?

[Powerlord]

Yes. Because you haven't closed the first array handle, that Handle (and its contents) have been leaked.

Either use ClearArray instead of CreateArray for the second one or CloseHandle g_Array first.

[friagram]

You could copies the handle lf the first array flr safe keeping, and close it later :/
Handle2 = Createarray()
Handle1 = Handle2
Handle2 = Createarray()
?

[Marcus_Brown001]

Originally Posted by friagram Handle1 = Handle2

Shouldn't you use CloneHandle for something like that?

[Mitchell]

Originally Posted by Marcus_Brown001 Shouldn't you use CloneHandle for something like that?

Because it's exactly that. you would be cloning the handle. Which would assign a new handle to that variable. Although i cant seem to think of a senario where you would create an array, and then assign it to another variable then create another with the old variable.. If you make anything with handles just close it when you're done with it. or if it's a keyvalue then cache it in variables. No need in keeping a handle open. (Sometimes menus will be a handle you don't want to close.) Sometimes closing menu handles while the menu is still open on a client it can lead to a server crash.

[Powerlord]

Originally Posted by Mitchell Sometimes closing menu handles while the menu is still open on a client it can lead to a server crash.

Which is why you don't close Menu handles anywhere but a MenuAction_End callback (which is why it exists...).

[GsiX]

Originally Posted by Powerlord Which is why you don't close Menu handles anywhere but a MenuAction_End callback (which is why it exists...).

I think my Ross was correct..
It depend on what the "handel" store callback..
If it as simple as timer, it just give you the two active function which is double the callback like double the timer function..

but if the handle store harm function.. it does crash the server on the second frame..

[friagram]

Originally Posted by Mitchell Because it's exactly that. you would be cloning the handle. Which would assign a new handle to that variable. Although i cant seem to think of a senario where you would create an array, and then assign it to another variable then create another with the old variable.. If you make anything with handles just close it when you're done with it. or if it's a keyvalue then cache it in variables. No need in keeping a handle open. (Sometimes menus will be a handle you don't want to close.) Sometimes closing menu handles while the menu is still open on a client it can lead to a server crash.

You might use something like this if you are using an array of arrays, and you have to pass an array through some function,

Dunno, mabye the func could close the handle, at which point you could like... If findvalueinarray return value, removefromarray (because it was closed). Normally youd must pass the array, but if you had multiples, i suppose this could work. Dunno, haven't had this happen.