Raised This Month: $ Target: $400
 0% 

get_user_weapon or native?


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
^SmileY
Veteran Member
Join Date: Jan 2010
Location: Brazil [<o>]
Old 11-06-2013 , 17:32   Re: get_user_weapon or native?
Reply With Quote #1

For forwards, you need to make it to use with other plugins, i recommend to use using CurWeapon event, because it is only called when player really change bettwen weapons.

__________________
Projects:

- See my Git Hub: https://github.com/SmileYzn
PHP Code:
set_pcvar_num(pCvar, !get_pcvar_num(pCvar)); 
^SmileY is offline
Send a message via MSN to ^SmileY Send a message via Skype™ to ^SmileY
hornet
AMX Mod X Plugin Approver
Join Date: Mar 2010
Location: Australia
Old 11-07-2013 , 00:20   Re: get_user_weapon or native?
Reply With Quote #2

Quote:
Originally Posted by ^SmileY View Post
For forwards, you need to make it to use with other plugins, i recommend to use using CurWeapon event, because it is only called when player really change bettwen weapons.

No not really. CurWeapon is called every time the clip ammo is updated, which means every time you fire a shot or when you change weapons.

@Baneado its hard to say unless you show your code or explain what your trying to do otherwise its really going to be XY problem. However, I can't imagine why you would need to use get_user_weapon() inside client_PreThink.
hornet is offline
ConnorMcLeod
Veteran Member
Join Date: Jul 2006
Location: France (95)
Old 11-07-2013 , 00:47   Re: get_user_weapon or native?
Reply With Quote #3

I second that.

Anyway, your question is abstract, we need to know exactly what you are doing in plugins with PreThink so we can tell you if there are alternatives or not.
For sure, PreThink is a bad function to hook in many situations.
__________________
- tired and retired -

- my plugins -
ConnorMcLeod is offline
baneado
Veteran Member
Join Date: Dec 2012
Location: amxmodx-es.com
Old 11-08-2013 , 08:55   Re: get_user_weapon or native?
Reply With Quote #4

Quote:
Originally Posted by hornet View Post
@Baneado its hard to say unless you show your code or explain what your trying to do otherwise its really going to be XY problem. However, I can't imagine why you would need to use get_user_weapon() inside client_PreThink.
Quote:
Originally Posted by ConnorMcLeod View Post
I second that.

Anyway, your question is abstract, we need to know exactly what you are doing in plugins with PreThink so we can tell you if there are alternatives or not.
For sure, PreThink is a bad function to hook in many situations.
It's simple, I have got a variable in the main plugin, this variable saves the currentweapon of a player. (of course this variable it's used in the plugin, I don't use get_user_weapon)

I asked about what is more efficient method for a subplugin, make a native or use get_user_weapon.

Native would be something like this:
PHP Code:
public native_weapon(id)
{
       if (!
is_user_valid_connected(id))
       {
               
//log error in a file...
               
return;
       }

        return 
g_wpn_current[id];

Then, in the subplugin what it's better, use the new native
PHP Code:
public client_PreThink(id)
{
       if (!
g_alive[id] || my_new_native_getweapon(id) != CSW_KNIFE)
               return;

or get_user_weapon??
PHP Code:
public client_PreThink(id)
{
       if (!
g_alive[id] || get_user_weapon(id) != CSW_KNIFE)
               return;


Last edited by baneado; 11-08-2013 at 08:58.
baneado is offline
ConnorMcLeod
Veteran Member
Join Date: Jul 2006
Location: France (95)
Old 11-08-2013 , 12:31   Re: get_user_weapon or native?
Reply With Quote #5

Quote:
Originally Posted by baneado View Post
It's simple, I have got a variable in the main plugin, this variable saves the currentweapon of a player. (of course this variable it's used in the plugin, I don't use get_user_weapon)

I asked about what is more efficient method for a subplugin, make a native or use get_user_weapon.

Native would be something like this:
PHP Code:
public native_weapon(id)
{
       if (!
is_user_valid_connected(id))
       {
               
//log error in a file...
               
return;
       }

        return 
g_wpn_current[id];

Then, in the subplugin what it's better, use the new native
PHP Code:
public client_PreThink(id)
{
       if (!
g_alive[id] || my_new_native_getweapon(id) != CSW_KNIFE)
               return;

or get_user_weapon??
PHP Code:
public client_PreThink(id)
{
       if (!
g_alive[id] || get_user_weapon(id) != CSW_KNIFE)
               return;

There is no problem with get_user_weapon.
But don't hook PreThink.
__________________
- tired and retired -

- my plugins -
ConnorMcLeod is offline
^SmileY
Veteran Member
Join Date: Jan 2010
Location: Brazil [<o>]
Old 11-07-2013 , 06:00   Re: get_user_weapon or native?
Reply With Quote #6

Quote:
Originally Posted by hornet View Post
No not really. CurWeapon is called every time the clip ammo is updated, which means every time you fire a shot or when you change weapons.

@Baneado its hard to say unless you show your code or explain what your trying to do otherwise its really going to be XY problem. However, I can't imagine why you would need to use get_user_weapon() inside client_PreThink.
Using a flag to detect if is active in CurWeapon? LOL
__________________
Projects:

- See my Git Hub: https://github.com/SmileYzn
PHP Code:
set_pcvar_num(pCvar, !get_pcvar_num(pCvar)); 
^SmileY is offline
Send a message via MSN to ^SmileY Send a message via Skype™ to ^SmileY
hornet
AMX Mod X Plugin Approver
Join Date: Mar 2010
Location: Australia
Old 11-07-2013 , 17:19   Re: get_user_weapon or native?
Reply With Quote #7

Quote:
Originally Posted by ^SmileY View Post
Using a flag to detect if is active in CurWeapon? LOL
You seem to find this quite amusing but sadly your still wrong. There is no reason why you would use CurWeapon over Ham_Item_Deploy, whether your using a flag or not ( under the given circumstances ).
hornet is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 23:13.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode