[Help] What's wrong with this code?

Inject · **Author**

Code:

// Include files
#include <sourcemod>
#include <sdktools>
#include <cstrike>
#define PLUGIN_VERSION "0.1"

// end includes

public Plugin:myinfo =
{
   name = "GiveLR", //name of the plugin, for coding refrence
   author = "Inject", //who made the plugin or coding
   description = "Giving LR", //self explanitory
   version = PLUGIN_VERSION, //look at the previouse code
   url = "http://www.playmakers-il.net"
};

public OnPluginStart()
{
    RegConsoleCmd("sm_givelr", Command_GiveLR, "Giving LR by name.");
}

public Action:Command_GiveLR(client, args)
{
if(args < 1)
{

    if(client != 0 && GetClientTeam(client) > 1)
    {
        
        decl String:TeamNum[5];
        GetCmdArgString(TeamNum, sizeof(TeamNum));
        new team = StringToInt(TeamNum);
        new TCount = GetTeamClientCount(CS_TEAM_T);
        
        if(team == CS_TEAM_T && TCount >= 1)
        {
PrintToChat(client, "[SM] Usage: sm_givelr <Player_Name>");
else
PrintToChat(client, "[SM] LR is not in progress.")
return Plugin_Handled;
}

    new String:name[32], target = -1;
    GetCmdArg(1, name, sizeof(name));
 
    for (new i=1; i<=MaxClients; i++)
    {
        if (!IsClientConnected(i))
        {
            continue;
        }
        decl String:other[32];
        GetClientName(i, other, sizeof(other));
        if (StrEqual(name, other))
        {
            target = i;
        }
    }
 
    if (target == -1)
    {
        PrintToConsole(client, "Could not find any player with the name: \"%s\"", name);
        return Plugin_Handled;
    }
    
            decl String:cname[64]
    GetClientName(target, cname, sizeof(cname));
    ServerCommand("sm_respawn \"%s\" ", cname)
 
    return Plugin_Handled;
}

I want to make mod that you can give your LR(Last-Request) to another player, I am coding only 1 week, and I don't know what I did wrong.

SM9 · 09-15-2013 , 12:42 Re: [Help] What's wrong with this code?

So you want to kill the player that has an LR and respawn the chosen player?

Inject · 09-15-2013 , 13:00 Re: [Help] What's wrong with this code?

Quote:

Originally Posted by xCoderx

So you want to kill the player that has an LR and respawn the chosen player?

Yeah, exactly

SM9 · *Last edited by SM9; 09-15-2013 at 14:28.*

Sorry about long response.

Try this: (Untested)

PHP Code:


			
// Include files
#include <sourcemod>
#include <sdktools>
#include <cstrike>
#define PLUGIN_VERSION "0.1"

// end includes

public Plugin:myinfo =
{
    name = "GiveLR", //name of the plugin, for coding refrence
    author = "Inject", //who made the plugin or coding
    description = "Giving LR", //self explanitory
    version = PLUGIN_VERSION, //look at the previouse code
    url = "http://www.playmakers-il.net"
};

new bool:isLastPlayer[MAXPLAYERS+1]    = { false, ... };

public OnPluginStart()
{
    RegConsoleCmd("sm_givelr", Command_GiveLR, "Giving LR by name.");
}

public Action:Command_GiveLR(client, args)
{
    if (args < 1)
        ReplyToCommand(client, "[SM] Usage: sm_givelr <name>");
    
    else
    {
        new team = GetClientTeam(client);
        new CountT = TCount();
        if(client != 0)
        {
            if(team == CS_TEAM_T)
            {
                if(IsPlayerAlive(client))
                {
                    if(CountT > 1)
                    {
                        PrintToChat(client, "LR is not in progress!")
                        PrintToConsole(client, "LR is not in progress!");
                    }
                    
                    else
                    {
                        new String:input[32], target = -1;
                        GetCmdArg(1, input, sizeof(input));
                        decl String:targetname[32];
                        
                        for (new i=1; i<=MaxClients; i++)
                        {
                            if (!IsClientConnected(i))
                            {
                                continue;
                            }
                            
                            decl String:other[32];
                            GetClientName(i, other, sizeof(other));
                            if (StrContains(input, other))
                            {
                                target = i;
                                GetClientName(target, targetname, sizeof(targetname));
                            }
                        }
                        
                        if(IsClientInGame(target))
                        {
                            if(GetClientTeam(target) == CS_TEAM_CT)
                            {
                                PrintToChat(client, "You can only give your LR to Terrorists!");
                                PrintToConsole(client, "You can only give your LR to Terrorists!");
                            }
                            else
                            {
                                CS_RespawnPlayer(target);
                                ForcePlayerSuicide(client);
                            }
                        }
                        else
                        {
                            PrintToChat(client, "Could not find any player with the name: \"%s\"", targetname);
                            PrintToConsole(client, "Could not find any player with the name: \"%s\"", targetname);
                        }
                    }
                }
                else
                {
                    PrintToChat(client, "You must alive!");
                    PrintToConsole(client, "You must alive!");
                }
                
            }
            else
            {
                PrintToChat(client, "You must be a Terrorist!");
                PrintToConsole(client, "You must be a Terrorist!");
            }
        }
    }
    return Plugin_Continue;
}


TCount(){
    new iTotalRed;
    
    for(new client = 1; client <= MaxClients; client++)
    {
        if(!IsClientInGame(client) || !IsPlayerAlive(client))
            continue;
        switch(GetClientTeam(client))
        {
            case CS_TEAM_T:
            iTotalRed++;
            
            case CS_TEAM_CT:{}
        }
        if(iTotalRed == 1){
            isLastPlayer[client] = true;
        }
        else{
            isLastPlayer[client] = false;
        }
    }
    return iTotalRed;
}

Inject · 09-15-2013 , 15:51 Re: [Help] What's wrong with this code?

Quote:

Originally Posted by xCoderx

Sorry about long response.

Try this: (Untested)

PHP Code:


			
// Include files
#include <sourcemod>
#include <sdktools>
#include <cstrike>
#define PLUGIN_VERSION "0.1"

// end includes

public Plugin:myinfo =
{
    name = "GiveLR", //name of the plugin, for coding refrence
    author = "Inject", //who made the plugin or coding
    description = "Giving LR", //self explanitory
    version = PLUGIN_VERSION, //look at the previouse code
    url = "http://www.playmakers-il.net"
};

new bool:isLastPlayer[MAXPLAYERS+1]    = { false, ... };

public OnPluginStart()
{
    RegConsoleCmd("sm_givelr", Command_GiveLR, "Giving LR by name.");
}

public Action:Command_GiveLR(client, args)
{
    if (args < 1)
        ReplyToCommand(client, "[SM] Usage: sm_givelr <name>");
    
    else
    {
        new team = GetClientTeam(client);
        new CountT = TCount();
        if(client != 0)
        {
            if(team == CS_TEAM_T)
            {
                if(IsPlayerAlive(client))
                {
                    if(CountT > 1)
                    {
                        PrintToChat(client, "LR is not in progress!")
                        PrintToConsole(client, "LR is not in progress!");
                    }
                    
                    else
                    {
                        new String:input[32], target = -1;
                        GetCmdArg(1, input, sizeof(input));
                        decl String:targetname[32];
                        
                        for (new i=1; i<=MaxClients; i++)
                        {
                            if (!IsClientConnected(i))
                            {
                                continue;
                            }
                            
                            decl String:other[32];
                            GetClientName(i, other, sizeof(other));
                            if (StrContains(input, other))
                            {
                                target = i;
                                GetClientName(target, targetname, sizeof(targetname));
                            }
                        }
                        
                        if(IsClientInGame(target))
                        {
                            if(GetClientTeam(target) == CS_TEAM_CT)
                            {
                                PrintToChat(client, "You can only give your LR to Terrorists!");
                                PrintToConsole(client, "You can only give your LR to Terrorists!");
                            }
                            else
                            {
                                CS_RespawnPlayer(target);
                                ForcePlayerSuicide(client);
                            }
                        }
                        else
                        {
                            PrintToChat(client, "Could not find any player with the name: \"%s\"", targetname);
                            PrintToConsole(client, "Could not find any player with the name: \"%s\"", targetname);
                        }
                    }
                }
                else
                {
                    PrintToChat(client, "You must alive!");
                    PrintToConsole(client, "You must alive!");
                }
                
            }
            else
            {
                PrintToChat(client, "You must be a Terrorist!");
                PrintToConsole(client, "You must be a Terrorist!");
            }
        }
    }
    return Plugin_Continue;
}


TCount(){
    new iTotalRed;
    
    for(new client = 1; client <= MaxClients; client++)
    {
        if(!IsClientInGame(client) || !IsPlayerAlive(client))
            continue;
        switch(GetClientTeam(client))
        {
            case CS_TEAM_T:
            iTotalRed++;
            
            case CS_TEAM_CT:{}
        }
        if(iTotalRed == 1){
            isLastPlayer[client] = true;
        }
        else{
            isLastPlayer[client] = false;
        }
    }
    return iTotalRed;
}

Working but it's not respawning the target, It's giving respawn to you, and not to the target...

SM9 · 09-15-2013 , 16:06 Re: [Help] What's wrong with this code?

Try this:

PHP Code:


			
// Include files
#include <sourcemod>
#include <sdktools>
#include <cstrike>
#define PLUGIN_VERSION "0.1"

// end includes

public Plugin:myinfo =
{
    name = "GiveLR", //name of the plugin, for coding refrence
    author = "Inject", //who made the plugin or coding
    description = "Giving LR", //self explanitory
    version = PLUGIN_VERSION, //look at the previouse code
    url = "http://www.playmakers-il.net"
};

public OnPluginStart()
{
    RegConsoleCmd("sm_givelr", Command_GiveLR, "Giving LR by name.");
}

public Action:Command_GiveLR(client, args)
{
    if (args < 1)
        ReplyToCommand(client, "[SM] Usage: sm_givelr <name>");
    
    else
    {
        new team = GetClientTeam(client);
        new CountT = TCount();
        if(client != 0)
        {
            if(team == CS_TEAM_T)
            {
                if(IsPlayerAlive(client))
                {
                    if(CountT > 1)
                    {
                        PrintToChat(client, "LR is not in progress!")
                        PrintToConsole(client, "LR is not in progress!");
                    }
                    
                    else
                    {
                        new String:input[32], target = -1;
                        GetCmdArg(1, input, sizeof(input));
                        decl String:targetname[32];
                        decl String:other[32];
                        
                        for (new i=1; i<=MaxClients; i++)
                        {
                            if (!IsClientConnected(i) || GetClientTeam(i) == CS_TEAM_CT || client == i)
                            {
                                continue;
                            }
                            
                            GetClientName(i, other, sizeof(other));
                            if (StrEqual(input, other))
                            {
                                target = i;
                                GetClientName(target, targetname, sizeof(targetname));
                            }
                        }
                        
                        if(IsClientInGame(target))
                        {
                            if(GetClientTeam(target) == CS_TEAM_CT)
                            {
                                PrintToChat(client, "You can only give your LR to Terrorists!");
                                PrintToConsole(client, "You can only give your LR to Terrorists!");
                            }
                            else
                            {
                                if(target == client){ // Don't go any further if target is the client.
                                    PrintToChat(client, "Error Target is Client executing cmd!")
                                    PrintToConsole(client, "Error Target is Client executing cmd!");
                                    return Plugin_Handled;
                                }
                                
                                else
                                {
                                    CS_RespawnPlayer(target); // 
                                    ForcePlayerSuicide(client);
                                }
                            }
                        }
                        else
                        {
                            PrintToChat(client, "Could not find any player with the name: \"%s\"", targetname);
                            PrintToConsole(client, "Could not find any player with the name: \"%s\"", targetname);
                        }
                    }
                }
                else
                {
                    PrintToChat(client, "You must alive!");
                    PrintToConsole(client, "You must alive!");
                }
                
            }
            else
            {
                PrintToChat(client, "You must be a Terrorist!");
                PrintToConsole(client, "You must be a Terrorist!");
            }
        }
    }
    return Plugin_Continue;
}


TCount(){
    new iTotalRed;
    
    for(new client = 1; client <= MaxClients; client++)
    {
        if(!IsClientInGame(client) || !IsPlayerAlive(client))
            continue;
        switch(GetClientTeam(client))
        {
            case CS_TEAM_T:
            iTotalRed++;
            
            case CS_TEAM_CT:{}
        }
    }
    return iTotalRed;
}

But you will now have to use full name of the target.
PS: I'm also new to coding, so if this does not work then I ask somebody else has a go. Cheers.