[Powerlord]

Requirements:
Team Fortress 2 or CS:GO (CS:GO support broken since March 2013)
SourceMod 1.5.0 or newer
NativeVotes 0.60 or newer, 0.8.0 or newer recommended

Description:
This is, literally, a drop-in replacement for the SourceMod MapChooser, with the Menu-related code replaced with NativeVotes vote-related code. It even uses the standard MapChooser's mapchooser.cfg. Note: It does not remove mapchooser, you need to do that yourself.

If NativeVotes is not available, falls back to the SourceMod vote system.

The major difference from MapChooser is that NativeVotes MapChooser uses the F1-F5 keys for voting instead of 1-6 (or 4-8 for MapChooser Extended).
And the vote finished without me choosing anything, so it chose for me.

Changelog

• 1.6.0
  • Version number has been increased to 1.6.0 to show that it is synced with SourceMod 1.6.x
  • Synced with MapChooser 1.6.x
    • MapChooser now checks if we've run out of votes before trying to add the first vote item. This prevents unhelpful errors when we run out of maps.
    • MapChooser now has a number of checks in place for votes that have no items in them and will refuse to start such a vote.
    • MapChooser will no longer randomly choose Extend or Don't Change if no one votes.
  • Separated out vote logic for normal and NativeVotes votes. This means that a vote now knows if it was a standard or NativeVotes vote and will no longer attempt (and fail) to switch vote styles mid-vote if NativeVotes is loaded/unloaded.
  • If NativeVotes is being used, increased the time between a vote ending and a runoff vote starting. This prevents an issue where runoff votes would sometimes fail to display to users. This new value is 3 seconds (old value was 2 seconds), which matches the amount of time NativeVotes uses internally for /revote .
• 1.5.4
  • Ported the SourceMod 1.5.3 double-nomination bugfix to NativeVotes MapChooser.
  • Ported the removal of g_NominateCount from SourceMod 1.5.3, should fix nomination count being off.
  • Better detection of SourceMod's MapChooser, since this can't run at the same time as it.
  • No longer tries using NativeVotes votes on games that don't support multiple choice votes (although why are you using this MapChooser on a non-supported game?)
• 1.5.3 (minor fix)
  • Fix version cvar not being marked as notify and don't record.
• 1.5.3
  • Fixed a bug with displaying menu items, specifically translating Extend and Don't Change.
• 1.5.2
  • Updated to support NativeVotes 0.8.0 or newer.
• 1.5.1
  • The plugin now sends a "not enough votes" failure message between the first vote and a runoff vote. This fixes the issue where runoff votes wouldn't work until you did a !revote
  • There is a two second delay between the first vote and the runoff vote to give time for the previously mentioned failure message to appear. This is because the fail screen has a 1 second delay on it and it would otherwise block the runoff vote from appearing.
  • NativeVotes max allowed vote options should now be taken into account (via the NativeVotes_GetMaxItems call, rather than hard-coding 5).
  • The number of maps in the vote will have 1 subtracted if NativeVotes is in use and extend is used (due to the 5-map hard limit).
  • Synchronized with SourceMod Mapchooser changes, specifically the increase of all map-name fields from 32/33/64/65 to PLATFORM_MAX_PATH.
• 1.5.0: Initial Public Release, based on MapChooser 1.5.0

Known Bugs:
See: NativeVotes Known Bugs.

NativeVotes has five vote-related cvars for displaying ongoing votes:

• nativevotes_vote_delay
• nativevotes_progress_hintbox
• nativevotes_progress_chat
• nativevotes_progress_console
• nativevotes_progress_client_console

Get Plugin does not work because this requires nativevotes.inc to compile.

[Custo]

Just started using this version, and the extended map option doesn't seem to show up after changing the sm_mapvote_extend command to 2.

After a little playing with, changing sm_mapvote_include from 5 to 4, it shows the extend option.

Should it be doing that?

EDIT: Also found out the runoff votes are buggy. Each time a runoff vote starts, no one can pick anything unless they do !revote first.

[Powerlord]

Originally Posted by Custo Just started using this version, and the extended map option doesn't seem to show up after changing the sm_mapvote_extend command to 2. After a little playing with, changing sm_mapvote_include from 5 to 4, it shows the extend option. Should it be doing that?

I probably forgot to adjust the map count (which is what I do on MapChooser Extended) when there are extends left.

Originally Posted by Custo EDIT: Also found out the runoff votes are buggy. Each time a runoff vote starts, no one can pick anything unless they do !revote first.

That's... strange. Do you see a vote pass or fail message between the two votes? The fail message has to happen or users can't cast a new vote.

Edit: I checked the code and it doesn't. That's an oversight on my part. Will fix soon.

[Powerlord]

OK, so I posted version 1.5.1 just before I left for lunch earlier.

Here's what changed:

• The plugin now sends a "not enough votes" failure message between the first vote and a runoff vote. This fixes the issue where runoff votes wouldn't work until you did a !revote
• There is a two second delay between the first vote and the runoff vote to give time for the previously mentioned failure message to appear. This is because the fail screen has a 1 second delay on it and it would otherwise block the runoff vote from appearing.
• NativeVotes max allowed vote options should now be taken into account (via the NativeVotes_GetMaxItems call, rather than hard-coding 5).
• The number of maps in the vote will have 1 subtracted if NativeVotes is in use and extend is used (due to the 5-map hard limit).
• Synchronized with SourceMod Mapchooser changes, specifically the increase of all map-name fields from 32/33/64/65 to PLATFORM_MAX_PATH.

Note: I'm at work and can't actually test this right now.

[Powerlord]

Here's version 1.5.2 that requires NativeVotes 0.8.0 and takes advantage of some of the new features.

[Powerlord]

There's a bug in yesterday's version that shouldn't affect anything (as I already implemented the missing actions), but I'll fix and re-post the code when I have an editor and compiler handy.

[Powerlord]

OK, here's a new build of 1.5.2 which should fix any potential issues with MenuAction_Display.

[reji]

Originally Posted by Powerlord OK, here's a new build of 1.5.2 which should fix any potential issues with MenuAction_Display.

Looks like it requires latest NativeVotes from git:

nativevotes_mapchooser.sp(1096) : error 017: undefined symbol "NativeVotes_RedrawVoteItem"

Later: Oh... ok, sorry for my inattention.

[Powerlord]

Originally Posted by reji Looks like it requires latest NativeVotes from git:

Yes, just like the build before it did... I thought it was implied that the new one would too.

[reji]

Trying current versions of NV and NV Mapchooser from git. There is no problem in-game (voting for a map works), but I see this on a server console:

Spoiler

L 09/19/2013 - 16:41:41: [SM] Native "GetMenuItemCount" reported: Menu handle 1805035e is invalid (error 2)
L 09/19/2013 - 16:41:41: [SM] Displaying call stack trace for plugin "nativevotes_mapchooser.smx":
L 09/19/2013 - 16:41:41: [SM]   [0]  Line 1078, nativevotes_mapchooser.sp::Handler_MapVoteMenu()
L 09/19/2013 - 16:41:41: [SM] Native "GetMenuItemCount" reported: Menu handle 1805035e is invalid (error 2)
L 09/19/2013 - 16:41:41: [SM] Displaying call stack trace for plugin "nativevotes_mapchooser.smx":
L 09/19/2013 - 16:41:41: [SM]   [0]  Line 1078, nativevotes_mapchooser.sp::Handler_MapVoteMenu()
L 09/19/2013 - 16:41:41: [SM] Native "GetMenuItemCount" reported: Menu handle 1805035e is invalid (error 2)
L 09/19/2013 - 16:41:41: [SM] Displaying call stack trace for plugin "nativevotes_mapchooser.smx":
L 09/19/2013 - 16:41:41: [SM]   [0]  Line 1078, nativevotes_mapchooser.sp::Handler_MapVoteMenu()
L 09/19/2013 - 16:41:41: [SM] Native "GetMenuItemCount" reported: Menu handle 1805035e is invalid (error 2)
L 09/19/2013 - 16:41:41: [SM] Displaying call stack trace for plugin "nativevotes_mapchooser.smx":
L 09/19/2013 - 16:41:41: [SM]   [0]  Line 1078, nativevotes_mapchooser.sp::Handler_MapVoteMenu()
L 09/19/2013 - 16:41:41: [SM] Native "GetMenuItemCount" reported: Menu handle 1805035e is invalid (error 2)
L 09/19/2013 - 16:41:41: [SM] Displaying call stack trace for plugin "nativevotes_mapchooser.smx":
L 09/19/2013 - 16:41:41: [SM]   [0]  Line 1078, nativevotes_mapchooser.sp::Handler_MapVoteMenu()
L 09/19/2013 - 16:41:41: [nativevotes_mapchooser.smx] Voting for next map has started.
...
[NV] xxx voted for pl_badwater
L 09/19/2013 - 16:41:53: server_cvar: "sm_nextmap" "pl_badwater"
L 09/19/2013 - 16:41:53: [nativevotes_mapchooser.smx] Voting for next map has finished. Nextmap: pl_badwater.

Same with NV 0.8.0 and NV Mapchooser 1.5.1. No errors with 0.7.9/1.5.1.
SourceMod version is 1.5.1.
Installed SourceMod plugins:

Spoiler

[SM] Listing 42 plugins:
  01 "Anti-Flood" (1.5.1) by AlliedModders LLC
  02 "SMAC Eye Angle Test" (0.8.4.1) by SMAC Development Team
  03 "Disable Auto-Kick" (0.3) by The-Killer
  04 "Basic Ban Commands" (1.5.1) by AlliedModders LLC
  05 "SMAC Client Protection" (0.8.4.1) by SMAC Development Team
  06 "Nextmap" (1.5.1) by AlliedModders LLC
  07 "Basic Votes" (1.5.1) by AlliedModders LLC
  08 "Win panel for losing team" (1.4) by Reflex
  09 "Fun Commands" (1.5.1) by AlliedModders LLC
  10 "SMAC AutoTrigger Detector" (0.8.4.1) by SMAC Development Team
  11 "SMAC Anti-Speedhack" (0.8.4.1) by SMAC Development Team
  12 "Admin Help" (1.5.1) by AlliedModders LLC
  13 "Basic Info Triggers" (1.5.1) by AlliedModders LLC
  14 "SourceMod Anti-Cheat" (0.8.4.1) by SMAC Development Team
  15 "SMAC Spinhack Detector" (0.8.4.1) by SMAC Development Team
  16 "Sound Commands" (1.5.1) by AlliedModders LLC
  17 "TF Max Players" (4.8) by Nican132,cadavor,JameLess,Thraka
  18 "SMAC Aimbot Detector" (0.8.4.1) by SMAC Development Team
  19 "SMAC Command Monitor" (0.8.4.1) by SMAC Development Team
  20 "GB.CritVote" (1.3.5) by FlyveHest
  21 "Basic Chat" (1.5.1) by AlliedModders LLC
  22 "Players Votes Redux" (1.1.2) by ReFlexPoison
  23 "Basic Commands" (1.5.1) by AlliedModders LLC
  24 "Player Commands" (1.5.1) by AlliedModders LLC
  25 "High Ping Kicker - Lite Edition" (1.0.0.1) by Liam
  26 "SMAC ConVar Checker" (0.8.4.1) by SMAC Development Team
  27 "Admin File Reader" (1.5.1) by AlliedModders LLC
  28 "SMAC Rcon Locker" (0.8.4.1) by SMAC Development Team
  29 "Client Preferences" (1.5.1) by AlliedModders LLC
  30 "[TF2] Better Vote Scramble" (1.2.0) by Dr. McKay
  31 "Outdated do?" (1.1) by KK
  32 "Fun Votes" (1.5.1) by AlliedModders LLC
  33 "Basic Comm Control" (1.5.1) by AlliedModders LLC
  34 "Reserved Slots" (1.5.1) by AlliedModders LLC
  35 "Admin Menu" (1.5.1) by AlliedModders LLC
  36 "Spray Tracer No Menu" (v5.8b) by Nican132, CptMoore, Lebson506th
  37 "NativeVotes" (0.8.1) by Powerlord
  38 "NativeVotes Basic Commands" (1.0) by Powerlord and AlliedModders LLC
  39 "Rock The Vote" (1.5.1) by AlliedModders LLC
  40 "NativeVotes Vote Tester" (1.0) by Powerlord
  41 "NativeVotes MapChooser" (1.5.2) by AlliedModders LLC and Powerlord
  42 "Map Nominations" (1.5.1) by AlliedModders LLC

P.S. Sorry for poor English.