Raised This Month: $182 Target: $400
 45% 

[CS:S] Bunnyhop Commands (Redux) [1.5 19 February 2013]


Post New Thread Reply   
 
Thread Tools Display Modes
Author
shavit
AlliedModders Donor
Join Date: Dec 2011
Location: Israel
Plugin ID:
3446
Plugin Version:
1.5
Plugin Category:
Gameplay
Plugin Game:
Counter-Strike: Source
Plugin Dependencies:
    Servers with this Plugin:
    1 
    Plugin Description:
    This plugin features many useful features for bunnyhop servers aka AIO bhop server plugin.
    Old 01-03-2013 , 09:19   [CS:S] Bunnyhop Commands (Redux) [1.5 19 February 2013]
    Reply With Quote #1

    This is a redux of my old plugin Bunnyhop Commands.


    1. Commands:
    • sm_bhop/sm_commands - Show the menu of available commands.
    • sm_guns/sm_weapons - Show the menu of the available weapons.
    • sm_aj/sm_autojump - Change your autojump status. Usage: sm_autojump <1/0>
    • sm_grav/sm_gravity - Show the menu of the gravity changes.

    2. Console Variables:
    • sm_bhopredux_version - Plugin version.
    • sm_bhopredux_enabled - Bunnyhop Commands (Redux) is enabled? [1]
    • sm_bhopredux_autojump - Enable auto jumping? [1]
    • sm_bhopredux_weapons - Allow weapon spawning? [1]
    • sm_bhopredux_gravity - Allow gravity changing? [1]
    • sm_bhopredux_falldamage - Disable damaged caused by falling? [1]
    • sm_bhopredux_noti - Notificate the players each time a cvar has been changed? [1]

    3. Config:
    Config will be auto created/executed in cfg/sourcemod/bhopcommands_redux.cfg.

    4. Requirements:
    • The SDKTools extension. (Comes with SourceMod)

    5. Planned:
    Nothing, request what do you want, but you shouldn't expect it 100% to be added.

    6. Feedback:
    You can post any feedback in the thread.

    7. Bug Reports:
    You can report any problem with the plugin via PM or the thread attaching error logs.

    8. Update:
    Delete the cfg/sourcemod/bhopcommands_redux.cfg file and follow Installation.

    9. Installation
    Copy bhopcommands.smx to addons/sourcemod/plugins and load the plugin manually, change map or restart the server.

    10. Changelog:
    1.5 / 19 February 2013 -
    Fixed everything that is listed here.

    1.4 / 19 February 2013 -

    Fixed that the "back" button in menus didn't worked.

    1.3 / 19 February 2013 -
    Fixed everything that is listed here.

    1.2 / 3 January 2013 -
    Fixed everything that is here.

    1.1 / 3 January 2013 -
    Changed plugin status to "Ready for review".
    Fixed an possible error.

    1.0 / 3 January 2013 - Initial release.
    Attached Files
    File Type: sp Get Plugin or Get Source (bhopcommands.sp - 509 views - 12.2 KB)
    File Type: smx bhopcommands.smx (15.4 KB, 819 views)
    __________________
    My Plugins
    Not taking private requests, too busy.

    Last edited by shavit; 02-19-2013 at 15:46.
    shavit is offline
    shavit
    AlliedModders Donor
    Join Date: Dec 2011
    Location: Israel
    Old 01-03-2013 , 10:19   Re: [CS:S] Bunnyhop Commands (Redux) [1.1 3 Jan 2013]
    Reply With Quote #2

    Quote:
    1.1 / 3 January 2013 -
    Changed plugin status to "Ready for review".
    Fixed an possible error.
    __________________
    My Plugins
    Not taking private requests, too busy.
    shavit is offline
    xNos
    SourceMod Donor
    Join Date: Dec 2012
    Location: Israel
    Old 01-03-2013 , 11:58   Re: [CS:S] Bunnyhop Commands (Redux) [1.1 3 Jan 2013]
    Reply With Quote #3

    wow man that is so makeover for the plugin.
    xNos is offline
    Send a message via Skype™ to xNos
    Impact123
    AlliedModders Donor
    Join Date: Oct 2011
    Location: Germany
    Old 01-03-2013 , 13:38   Re: [CS:S] Bunnyhop Commands (Redux) [1.1 3 Jan 2013]
    Reply With Quote #4

    I have found several bugs while quickly looking over the half of your code.

    • AutoExecConfig should be after you have created the convars
    • You re set the convarvariables after AutoExecConfig is done, see next point
    • You should grab the convarvalues after AutoExecConfig is done
    • You should fetch bool convars with GetConvarBool and not with StringToInt and such
    • The notifications when some part is enabled or not should be able to deactivate
    • If you change an byref valie in an Callback you should return Plugin_Changed not Handled
    • You should use sizeof if you can instead of the numerical size of a variable
    • You print out an full timestamp instead of remaining waitingtime in the weaponmenuhandler
    Have you tested your code?

    Yours sincerely
    Impact
    __________________

    Last edited by Impact123; 01-03-2013 at 14:08.
    Impact123 is offline
    shavit
    AlliedModders Donor
    Join Date: Dec 2011
    Location: Israel
    Old 01-03-2013 , 13:52   Re: [CS:S] Bunnyhop Commands (Redux) [1.1 3 Jan 2013]
    Reply With Quote #5

    About the "dissabled"/"ensabled" it's "\x04%sabled" with an %s and not just an s.
    Fixed the cvar stuff, and I will continue using the StringToInt.
    Changed the handled return to changed.
    I don't like using sizeof unless it's a part that is hard to reach/find from the current function that I'm looking at.
    Added sm_bhopredux_noti.
    And for the best part - fully tested!
    __________________
    My Plugins
    Not taking private requests, too busy.

    Last edited by shavit; 01-03-2013 at 15:34.
    shavit is offline
    shavit
    AlliedModders Donor
    Join Date: Dec 2011
    Location: Israel
    Old 01-03-2013 , 13:55   Re: [CS:S] Bunnyhop Commands (Redux) [1.2 3 Jan 2013]
    Reply With Quote #6

    Quote:
    1.2 / 3 January 2013 -
    Details here
    __________________
    My Plugins
    Not taking private requests, too busy.
    shavit is offline
    shavit
    AlliedModders Donor
    Join Date: Dec 2011
    Location: Israel
    Old 01-03-2013 , 14:18   Re: [CS:S] Bunnyhop Commands (Redux) [1.2 3 Jan 2013]
    Reply With Quote #7

    There is an OnCvarChanged public.
    The cvar change is called before AutoExecConfig, means that an hook will appear, and a config will be executed.
    __________________
    My Plugins
    Not taking private requests, too busy.

    Last edited by shavit; 01-03-2013 at 15:34.
    shavit is offline
    Root_
    Veteran Member
    Join Date: Jan 2012
    Location: ryssland
    Old 01-04-2013 , 12:47   Re: [CS:S] Bunnyhop Commands (Redux) [1.2 3 Jan 2013]
    Reply With Quote #8

    I hate centered text
    __________________


    dodsplugins.com - Plugins and Resources for Day of Defeat
    http://twitch.tv/zadroot
    Root_ is offline
    shavit
    AlliedModders Donor
    Join Date: Dec 2011
    Location: Israel
    Old 01-04-2013 , 13:31   Re: [CS:S] Bunnyhop Commands (Redux) [1.2 3 Jan 2013]
    Reply With Quote #9

    Quote:
    Originally Posted by Root_ View Post
    I hate centered text
    Centered texts hate you.
    __________________
    My Plugins
    Not taking private requests, too busy.
    shavit is offline
    alongub
    Veteran Member
    Join Date: Aug 2009
    Location: Israel
    Old 02-19-2013 , 14:44   Re: [CS:S] Bunnyhop Commands (Redux) [1.2 3 Jan 2013]
    Reply With Quote #10

    Code:
    for(new i; i <= MaxClients; i++)
    Initialize i = 1.

    Code:
    if(!IsValidClient(client, true) || !gB_Enabled || !gB_AutojumpCVar || !gB_Autojump[client] || Client_IsOnLadder(client) || Client_GetWaterLevel(client) > Water_Level:WATER_LEVEL_FEET_IN_WATER)
    Make sure that the client is valid before calling Client_IsOnLadder and Client_GetWaterLevel.
    __________________

    Last edited by alongub; 02-19-2013 at 14:44.
    alongub is offline
    Reply


    Thread Tools
    Display Modes

    Posting Rules
    You may not post new threads
    You may not post replies
    You may not post attachments
    You may not edit your posts

    BB code is On
    Smilies are On
    [IMG] code is On
    HTML code is Off

    Forum Jump


    All times are GMT -4. The time now is 14:39.


    Powered by vBulletin®
    Copyright ©2000 - 2017, vBulletin Solutions, Inc.
    Theme made by Freecode