[Bitl]

This changes all players to be a specific class. This force-kills all players when the round starts.

ConVars:
sm_fcc_class 1/9
-Forces all users to change to a class.
1 - Scout
2 - Soldier
3 - Pyro
4 - Demoman
5 - Heavy
6 - Engineer
7 - Medic
8 - Sniper
9 - Spy

Patches:

1.2
- Removed round_start and player_changeclass
- Documents all the class numbers when sm_fcc_class returns no values

1.1
- Removed the original 9 cvars and replaced them with sm_fcc_class (Thanks Dr. McKay!)

1.0:
-Release

[Dr. McKay]

Why couldn't you just use Class Restrictions and set the limit for everything except the one class to zero?

[Bitl]

Originally Posted by Dr. McKay Why couldn't you just use Class Restrictions and set the limit for everything except the one class to zero?

It just makes it easier.

[Dr. McKay]

Originally Posted by Bitl It just makes it easier.

Unfortunately, making the behavior of an existing plugin easier is still duplication and is ineligible to be approved. If you add something that another plugin doesn't do already, it'll be reviewable, but it's not in its current state.

That being said, using nine individual cvars is not the best way to approach this. The best method would be to use a single cvar and assign a number to each class (1 = scout, 2 = soldier, etc).

Then you could just change the cvar to the class that you want to force.

I'm unapproving this for now, but PM me or another approver if you add something that sets this plugin apart from those that already exist.

[Bitl]

Originally Posted by Dr. McKay Unfortunately, making the behavior of an existing plugin easier is still duplication and is ineligible to be approved. If you add something that another plugin doesn't do already, it'll be reviewable, but it's not in its current state. That being said, using nine individual cvars is not the best way to approach this. The best method would be to use a single cvar and assign a number to each class (1 = scout, 2 = soldier, etc). Then you could just change the cvar to the class that you want to force. I'm unapproving this for now, but PM me or another approver if you add something that sets this plugin apart from those that already exist.

I was going to add a single cvar, but I didn't know how I would implement it with the numbers, so that's why I added 9 cvars.

[Dr. McKay]

You could do something like this:

PHP Code:

switch(GetConVarInt(myCvar)) {
    case 1: TF2_SetPlayerClass(client, TFClass_Scout);
    case 2: TF2_SetPlayerClass(client, TFClass_Soldier);
    case 3: TF2_SetPlayerClass(client, TFClass_Pyro);
    // etc etc
} 


[Bitl]

Originally Posted by Dr. McKay You could do something like this: PHP Code: switch(GetConVarInt(myCvar)) {     case 1: TF2_SetPlayerClass(client, TFClass_Scout);     case 2: TF2_SetPlayerClass(client, TFClass_Soldier);     case 3: TF2_SetPlayerClass(client, TFClass_Pyro);     // etc etc }

Thanks!

On it.

[Dr. McKay]

• The round_start event doesn't have a userid property (and I don't think it is even called in TF2?)
• You should document what numbers correspond to what class
• Hooking player_changeclass is superfluous since you're already hooking player_spawn and forcing the class there

I'd recommend just removing everything except for the player_spawn hook and forcing the class there. Once that's done, I'd say this is approvable.

[Bitl]

Done all of those changes now!

[Dr. McKay]

Looks good to me, good job.