Originally Posted by 11530
Looking good, I'll update tonight. Thanks for the redux!
Instead of defining TF2COLORS, maybe you could just check the game in OnPluginStart and set a bool? That way, people don't need to manually set/compile it themselves.
Also, would it be better to use #tryinclude for things like SteamTools/Updater instead of using more defines there too?
Do we need to do anything with the .gitattributes and .gitignore files in the zip file?
The problem here is that we're including 2 libraries that have stocks with similar, or completely alike names, therefore I have to use the define and #if defined to let the compiler know not to include if it is not compiling the TF2 version.
I don't know how #tryinclude works, but from what I know, using #undef REQUIRE_PLUGINS and #unded REQUIRE_EXTENSIONS makes sure the files are included but when it comes to running the plugin, it doesn't require the extensions, whereas if I didn't have that line it would stop the plugin saying a requirement has not been matched, and also speaking of requirements, I forgot to #undef REQUIRE_PLUGIN on #include <updater>, so I would recommend updating your plugin to the newest version as I have done this in the newest commit. This will not be necessary if you're already running Updater. (Commit Info)
I didn't increment the version just because of this change as there probably will be some major bugs that I'll need to fix which I will in the next versions.
The .gitattributes and .gitignore files are just for GitHub (The SVN), it doesn't make a difference as they don't do anything for the plugin; they're just the git's config, meaning no, you won't need them and it's recommended that you don't upload them at all.
Also, make sure you only upload 1 version of the plugin smx file.