Raised This Month: $182 Target: $400
 45% 

[ND] Squad Management


Post New Thread Reply   
 
Thread Tools Display Modes
Author
Player 1
Member
Join Date: Apr 2012
Plugin ID:
2964
Plugin Version:
1.1.1
Plugin Category:
Admin Commands
Plugin Game:
Nuclear Dawn
Plugin Dependencies:
    Servers with this Plugin:
    1 
    Plugin Description:
    Allows admins to remove players from a squad
    Old 05-22-2012 , 12:12   [ND] Squad Management
    Reply With Quote #1

    Description:
    Gives admins the ability to remove players from a squad. Kicking a player will ban them from that squad until the map changes or an admin removes the ban. May be useful for admins who want to group up with their friends without random people joining.

    Admin Commands:
    sm_squadkick <player> | "Kicks and temporarily bans the target from current squad."
    sm_squadunban <player> | "Removes a player's squad ban."

    ChangeLog:
    13 July 2012 (v1.1.1)
    * Small bug fix

    22 May 2012 (v1.1)
    * Now uses FindTarget
    * Removed some unnecessary PrintToChat lines



    Please let me know of any related functionality you wish to see included.
    Attached Files
    File Type: sp Get Plugin or Get Source (nd_squad_management.sp - 221 views - 3.4 KB)

    Last edited by Player 1; 07-13-2012 at 19:11. Reason: updated to v1.1.1
    Player 1 is offline
    databomb
    Veteran Member
    Join Date: Jun 2009
    Location: Boston, MA
    Old 05-22-2012 , 17:23   Re: [ND] Squad Management
    Reply With Quote #2

    Good work, nice to see others making ND plugins . I have a few general comments on it:

    - Since you're using target_list[0] from ProcessTargetString instead of FindTarget, I would suggest throwing an error if more than one person matched the expression.

    - If you make bitmasks for the four squads then you could allow for temporary banning from more than just 1 squad.

    - Have you considered using ShowActivity* instead of PrintToChat for the admin activity chats?

    - Why hard-code [33] for SquadBans instead of MAXPLAYERS+1?
    __________________
    Public Plugins | Please: No new private requests.
    databomb is offline
    Player 1
    Member
    Join Date: Apr 2012
    Old 05-22-2012 , 22:18   Re: [ND] Squad Management
    Reply With Quote #3

    Quote:
    - Since you're using target_list[0] from ProcessTargetString instead of FindTarget, I would suggest throwing an error if more than one person matched the expression.
    Done. Switch to FindTarget

    Quote:
    If you make bitmasks for the four squads then you could allow for temporary banning from more than just 1 squad.
    Honestly, that sounds like overkill, but I'll look into it.

    Quote:
    Have you considered using ShowActivity* instead of PrintToChat for the admin activity chats?
    I have, but I don't believe it's necessary to inform everyone of this activity. I think a message to the target and conformation to the admin is enough.

    Quote:
    Why hard-code [33] for SquadBans instead of MAXPLAYERS+1?
    Isn't Nuclear Dawn already hard coded to 32 max players? (ConCmd "maxplayers")?


    Thanks for the quick response, btw.
    Player 1 is offline
    Gallomimia
    Junior Member
    Join Date: Jun 2012
    Old 06-16-2012 , 00:38   Re: [ND] Squad Management
    Reply With Quote #4

    This just happened while I was watching the console on cha0s primary:


    L 06/15/2012 - 2331: [SM] Plugin encountered error 15: Array index is out of bounds
    L 06/15/2012 - 2331: [SM] Displaying call stack trace for plugin "nd_squad_management.smx":
    L 06/15/2012 - 2331: [SM] [0] Line 100, /home/groups/alliedmodders/forums/files/1/7/9/3/9/7/104119.attach::CMD_JoinSquad()
    L 06/15/2012 - 233:46: [SM] Plugin encountered error 15: Array index is out of bounds
    L 06/15/2012 - 233:46: [SM] Displaying call stack trace for plugin "nd_squad_management.smx":
    L 06/15/2012 - 233:46: [SM] [0] Line 100, /home/groups/alliedmodders/forums/files/1/7/9/3/9/7/104119.attach::CMD_JoinSquad()

    It happened just after a reserved slot kick.
    Gallomimia is offline
    Player 1
    Member
    Join Date: Apr 2012
    Old 07-13-2012 , 19:06   Re: [ND] Squad Management
    Reply With Quote #5

    Ah, its probably the 33rd player messing up the temp ban array. But shouldn't cause any problems other than spam the logs.

    I've uploaded a new version to fix this.
    Player 1 is offline
    Peace-Maker
    SourceMod Plugin Approver
    Join Date: Aug 2008
    Location: Germany
    Old 10-06-2012 , 21:20   Re: [ND] Squad Management
    Reply With Quote #6

    Awesome idea. I'd like a feature where the commander is allowed to manage the squads like that, maybe with optional banning, so he can put someone into a squad and remove him too.

    Banning from multiple squads or forcing a player into a squad would be a step further
    __________________
    Peace-Maker is offline
    Player 1
    Member
    Join Date: Apr 2012
    Old 10-23-2012 , 10:13   Re: [ND] Squad Management
    Reply With Quote #7

    Quote:
    Originally Posted by Peace-Maker View Post
    Awesome idea. I'd like a feature where the commander is allowed to manage the squads like that, maybe with optional banning, so he can put someone into a squad and remove him too.
    That's interesting, but since you can't use SourceMod menus while commanding I can't imagine how the commander would access that feature. Do you have any suggestions?
    Player 1 is offline
    Peace-Maker
    SourceMod Plugin Approver
    Join Date: Aug 2008
    Location: Germany
    Old 10-23-2012 , 18:56   Re: [ND] Squad Management
    Reply With Quote #8

    Poke psychonic to fix the menus!
    __________________
    Peace-Maker is offline
    Reply


    Thread Tools
    Display Modes

    Posting Rules
    You may not post new threads
    You may not post replies
    You may not post attachments
    You may not edit your posts

    BB code is On
    Smilies are On
    [IMG] code is On
    HTML code is Off

    Forum Jump


    All times are GMT -4. The time now is 18:41.


    Powered by vBulletin®
    Copyright ©2000 - 2017, vBulletin Solutions, Inc.
    Theme made by Freecode