[drekes]

Description:
Enables / disables damage done by a player.


Commands:
- amx_blockdamage <name/steamid/userid> <0/1> "Block / Unblock damage done by a player."
- amx_blockdamage_list "List all the currently connected no-damage players"


Credits:
- Pan1c: Came up with the idea as a request here: http://forums.alliedmods.net/showthread.php?t=149978

Changelog:
v1.0.0: Created plugin
v1.0.1: Removed Trie
v1.0.2: Optimized code

[gtpunkt]

Cool plugin,I use it on my server for the evil player

[ConnorMcLeod]

I don't see the point on using both a trie and nvault, trie would be usefull if you would store steamids in a file to load all steamids at map start.

In fact, you never retrieve data from the trie :

	Line 37: new Trie: g_tBlockedIds;
	Line 56: 	g_tBlockedIds = TrieCreate();
	Line 60: 	if(g_tBlockedIds == Invalid_Trie)
	Line 78: 		TrieSetCell(g_tBlockedIds, szAuthId, 1);
	Line 116: 			TrieSetCell(g_tBlockedIds, szPlayerAuth, 1);
	Line 126: 			TrieDeleteKey(g_tBlockedIds, szPlayerAuth);

[drekes]

I worked with a seperate file first, and then changed it to nvault.
Guess i forgot to remove the trie.

EDIT: Removed trie

[Xalus]

Maybe:

PHP Code:

        if(iNum)
        {
            nvault_set(g_Vault, szPlayerAuth, "1");
            
            g_bNoDamage[iPlayer] = true;
            bNoDamage = true;
        }
        
        else
        {
            nvault_remove(g_Vault, szPlayerAuth);
            
            g_bNoDamage[iPlayer] = false;
            bNoDamage = false;
        } 


To

PHP Code:

if(iNum){
            nvault_set(g_Vault, szPlayerAuth, "1");
        } else {
            nvault_remove(g_Vault, szPlayerAuth);
        }
        g_bNoDamage[iPlayer] = !g_bNoDamage[iPlayer]
        bNoDamage = !bNoDamage; 


[drekes]

I don't think that will really matter, i have to make the if and else anyways.
And i like my way more. It's easier to see the value i just set

[Xalus]

Its extra code for nothing.

[drekes]

Imo it's more readable then yours.
If an approver tells me to change it due performance or something, i will.
If not, i'd like to keep it like it is.

EDIT: Wrecked told me that yours is less efficient because it has to retrieve the
current value first, and then change it to the opposite.

[ConnorMcLeod]

        new bool:bNoDamage = g_bNoDamage[iPlayer] = !(szNum[0] == 0);
        
        if( bNoDamage )
        {
            nvault_set(g_Vault, szPlayerAuth, "1");
        }
        else
        {
            nvault_remove(g_Vault, szPlayerAuth);
        }

Also, you can lower names and authids arrays to 32 cells

[drekes]

Done