[rrduna]

Map Announcer v1.0
Copyright © 2010 by Duna. All rights reserved.

Last Update: 24/06/2010
Visit: www.csduna.blogspot.com


Description:

At the beginning of each round, the plugin displays a message in the chat showing the name of the map being played.



I apologize for my bad english.
The issue is that I use translator.
Thanks!
.

[s33k]

Again?

Already made.

[rrduna]

not, again :/

[claudiuhks]

public map_announcer(id) {
    new map[32]
    get_mapname(map,31)
    
    client_printc(id, "^4[AMXX] ^1You are playing in map: ^4%s",map)
    return;
}

=>>>>

new roundnumber;

public map_announcer() {
    roundnumber++;
    new map[64];
    new players;
    new maxplayers;
    new timeleft;
    get_mapname(map, 63);
    players = get_playersnum(1);
    maxplayers = get_maxplayers();
    timeleft = (get_timeleft() / 60);
    for (new id = 1; id <= get_maxplayers(); id++) {
        if (!is_user_connected(id)) {
            continue;
        }
        client_printc(id, "^4[AMXX] ^1You are playing on map: ^4%s", map);
        client_printc(id, "^4[AMXX] ^1Number of players: ^4%i/%i", players, maxplayers);
        client_printc(id, "^4[AMXX] ^1Round number: ^4%i", roundnumber);
        client_printc(id, "^4[AMXX] ^1Timeleft: ^4%i", timeleft);
    }
}

--Edited!
--Edited again!

[rrduna]

thanks!

[drekes]

I think it would be better to cache the mapname in a global variable in plugin_init()

[rrduna]

how so?

[drekes]

PHP Code:

new g_Mapname[35];

public plugin_init()
    get_mapname(g_MapName, charsmax(g_MapName));

public MapAnouncer()
    show_hudmessage(0, "You are playing on %s", g_MapName); 


So you don't have to check it every round.

[rrduna]

Understood.
Thank you for expressing opinions.
Next version comes complete;)

[ConnorMcLeod]

* Save mapname into a global var
* Don't pass any id in a global event
* Don't use a private function when used only once, integrate it in the calling function
* Don't make checks on id when you know it always be 0
* Don't stupidly use a stock, your plugin has no ML, so you can send one brodcast message instead of looping through all players, also you never send any !g nor !t nor !n so you don't need to try to replace them.


Also this plugin is useless and has no configuration possibilities, Unapproved.