Raised This Month: $ Target: $400
 0% 

Gladiator Mod v1.3


Post New Thread Reply   
 
Thread Tools Display Modes
xLeoNNN
Veteran Member
Join Date: Sep 2010
Location: de_dust2
Old 11-14-2010 , 14:53   Re: Gladiator Mod v1.1
Reply With Quote #41

Do not I you understand very well, that you want that it changes?
__________________
xLeoNNN is offline
Send a message via MSN to xLeoNNN
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 11-14-2010 , 15:14   Re: Gladiator Mod v1.1
Reply With Quote #42

PHP Code:
if(g_GP[id] >= get_pcvar_num(cvar_*cost))
{
    
// ...
}
else if(
g_GP[id] < get_pcvar_num(cvar_*cost))
{
    
// other ...
    
return PLUGIN_HANDLED;



PHP Code:
if(g_GP[id] >= get_pcvar_num(cvar_*cost))
{
    
// ...
}
else
{
    
// other ...

Also, you can't have multiple tasks with the same id.
__________________

Last edited by fysiks; 11-14-2010 at 15:30.
fysiks is offline
Jacob
Senior Member
Join Date: Oct 2010
Old 11-14-2010 , 19:37   Re: Gladiator Mod v1.1
Reply With Quote #43

good plugin,thX!
Jacob is offline
Jacob
Senior Member
Join Date: Oct 2010
Old 11-14-2010 , 20:44   Re: Gladiator Mod v1.1
Reply With Quote #44

BUG:if the spe mod is free look.name is server name.
Jacob is offline
Xellath
Veteran Member
Join Date: Dec 2007
Location: Sweden
Old 11-15-2010 , 17:03   Re: Gladiator Mod v1.1
Reply With Quote #45

Didn't bother to read the code throughly, but I noticed some things:
  • Don't use fm_util stocks - they're generally slower to execute.
  • Why are you de-tagging weak tags; such as bool, float?
  • Cache get_user_msgid() ang get_maxplayers() values.
  • Your if and switch statements are redundant.
  • You coding-style is very inconsistent, keep to one style.
__________________
Achievements API - a simple way for you to create your OWN custom achievements!
Xellath is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 11-15-2010 , 18:54   Re: Gladiator Mod v1.1
Reply With Quote #46

Quote:
Originally Posted by Xellath View Post
  • Your if and switch statements are redundant.
What are you refering to? Tell us which line numbers to which you are refering.
__________________
fysiks is offline
Exolent[jNr]
Veteran Member
Join Date: Feb 2007
Location: Tennessee
Old 11-15-2010 , 19:09   Re: Gladiator Mod v1.1
Reply With Quote #47

Quote:
Originally Posted by fysiks View Post
What are you refering to? Tell us which line numbers to which you are refering.
All of the menu handlers (old and new style).
__________________
No private work or selling mods.
Quote:
Originally Posted by xPaw View Post
I love you exolent!
Exolent[jNr] is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 11-15-2010 , 19:45   Re: Gladiator Mod v1.1
Reply With Quote #48

Quote:
Originally Posted by Exolent[jNr] View Post
All of the menu handlers (old and new style).
I still fail to see where a switch statement makes an if statement redundant or vice versa. OR, I'm interpreting that wrong, maybe he means and there is an if statement that is redunant and a switch statement that is redundant. The former of which I've already pointed out.

However, I did find a few places of this:

PHP Code:
var = true
if( var )
{
 
}
else if( var )
{


1501, 1589, and 1676, these need to have the else if() changed to else (not really redundant but code is unreachable).
__________________

Last edited by fysiks; 11-15-2010 at 19:50.
fysiks is offline
Godzi
Junior Member
Join Date: Oct 2010
Old 11-21-2010 , 13:45   Re: Gladiator Mod v1.1
Reply With Quote #49

AWESOME!

but you can add classes whit others models, and health, speed, grav.
anyway AWESOME ;D
Godzi is offline
Spammer2011go
BANNED
Join Date: Nov 2010
Old 11-27-2010 , 16:48   Re: Gladiator Mod v1.1
Reply With Quote #50

go unnaproved because suckz
Spammer2011go is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 20:08.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode