[harbu]

The callfunc_push_str seems to have a bug with returning the string back to when it has been edited in the function pointed out by callfunc_begin()

Example:

Main Plugin File

public bugff(id)
{
    new string[64]
    
    if( callfunc_begin( "buggie", "other_plugin.amxx" ) )
    {
        callfunc_push_str( string )
        callfunc_end( )
    }
    client_print( 0 , print_chat, "%s", string )
    return PLUGIN_HANDLED
}

The other_plugin.amxx file

public buggie( string[] )
{
    format( string, 63, "OMG!!" )
}

Now when it returns the string it only returns the first character of the edited string.

[BAILOPAN]

It's not a bug. Notice that the function is prototyped as "const".

If you want a callfunc_push_strrf (push string reference), I'll ask PM whether it's possible (he made the callfunc natives).

[Twilight Suzuka]

Strings were not passed by reference? I thought all strings in SMALL were passed by reference?
Thats why it wouldn't work then....

[BAILOPAN]

Strings are passed by reference, my example was misleading. The actual data in the string, however, is not handled by reference - it's copied into the heap.

There would need to be an optional second parameter called "copyback" which instructed callfunc_end to save the old address and copy the data into it.

PM's busy now so I won't bother him, I'll consider adding this myself for the next release.

[harbu]

Originally Posted by BAILOPAN It's not a bug. Notice that the function is prototyped as "const". If you want a callfunc_push_strrf (push string reference), I'll ask PM whether it's possible (he made the callfunc natives).

If this would be possible it would really rock..

[PM]

I will look into this!

[BAILOPAN]

I was unable to reproduce this and it seems the issue is resolved.