Raised This Month: $ Target: $400
 0% 

[INC] GeoCity (Get Players City From IP)


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
p3tsin
Senior Member
Join Date: Sep 2005
Location: Finland
Old 04-15-2010 , 10:01   Re: [INC] GeoCity (Get Players City From IP)
Reply With Quote #1

Although this has been done before, yours uses databases which is a great improvement (lag-wise at least). A couple of suggestions however
  1. all global variables and internal functions people arent supposed to directly access, make them "static stock" (it doesnt say in the article that you can use static for functions, or that you can use stock for variables, but it applies to them too)
  2. declare large local array variables (or small too!) with decl
  3. it seems the code is leaking memory by reconnecting to the database each time, discarding the potential existing database handle
  4. can you add support for threaded queries? dont remove the non-threaded stuff though, its nice to be able to choose

Good job implementing this on databases
__________________
plop
p3tsin is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 18:16.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode