[WebNoob]

SO...after having this functionality for 8+ years, it appears the "Smissmass 2016" update that changed the autobalance functionality has also broken the "swapteam" function our supporters have been able to use for years.

Specifically, the game no longer kills the player when they swapteams, it simply (and instantly) changes their team, which means people can create havoc by swapping teams in spawn, etc.

My question is - is this going to require an alteration to the underlying plugin/extension, or is this something that will be fixed in Sourcemod itself?

[psychonic]

From what I recall seeing on IRC recently, just calling ChangeClientTeam on TF2 is no longer enough to change a client's team. TF2_RespawnPlayer must be called afterward. This would be best fixed in the SM plugins that do this.

[friagram]

Originally Posted by psychonic From what I recall seeing on IRC recently, just calling ChangeClientTeam on TF2 is no longer enough to change a client's team. TF2_RespawnPlayer must be called afterward. This would be best fixed in the SM plugins that do this.

calling respawn when changeteam happens doesn't do it. Mabye a frame or 2 later will
Looks like you actually have to kill them.

[Fearts]

@psychonic

Is there no other way then editing every plugin? Like a very large number of plugins use ChangeClientTeam.

[friagram]

PHP Code:

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>
#include <tf2>
#include <sdkhooks>

public Plugin:myinfo =  {
    name = "Change Team Fix", 
    author = "Friagram", 
    description = "burp", 
    version = "1.0", 
    url = "http://steamcommunity.com/groups/poniponiponi"
};

public OnPluginStart()
{
    HookEvent("player_team", Event_PlayerTeam);
}

public Event_PlayerTeam(Handle:hEvent, const String:name[], bool:dontBroadcast)
{
    if(GetEventInt(hEvent, "team") == 1)
    {
        new userid = GetEventInt(hEvent, "userid");
        new client = GetClientOfUserId(userid);
        if(client && IsClientInGame(client))
        {        
            FakeClientCommand(client, "kill");
            SDKHooks_TakeDamage(client, client, client, 9999.0);
    
            RequestFrame(frame_respawn, userid);
        }
    }
}

public frame_respawn(any:userid)
{
    new client = GetClientOfUserId(userid);
    if(client && IsClientInGame(client) && IsPlayerAlive(client) && GetClientTeam(client) == 1)
    {
        TF2_RespawnPlayer(client);
    }
} 


[Stropy]

Got your plugin on 3 servers, if i switch player to spectate, it works as always, thanks to your plugin, but when i switch someone from red/blu to red/blu, they just change the team and don't die.

[friagram]

Originally Posted by Stropy Got your plugin on 3 servers, if i switch player to spectate, it works as always, thanks to your plugin, but when i switch someone from red/blu to red/blu, they just change the team and don't die.

right, the problem is, the game used to kill on team change. doing that in a plugin here may interfere with stuff like ff2. You can just always kill/respawn them, removing the team checks I added if you like.

[Stropy]

Oh, right, tbh i know nothing about coding, could you please remove the team checks for me? Sorry for being stupid..

[Benoist3012]

Originally Posted by Stropy Oh, right, tbh i know nothing about coding, could you please remove the team checks for me? Sorry for being stupid..

You don't have to be sorry, the simple fact you used that plugin and gave feedbacks does not make you stupid

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>
#include <tf2>
#include <sdkhooks>

public Plugin:myinfo =  {
    name = "Change Team Fix", 
    author = "Friagram", 
    description = "burp", 
    version = "1.0", 
    url = "http://steamcommunity.com/groups/poniponiponi"
};

public OnPluginStart()
{
    HookEvent("player_team", Event_PlayerTeam);
}

public Event_PlayerTeam(Handle:hEvent, const String:name[], bool:dontBroadcast)
{
    new userid = GetEventInt(hEvent, "userid");
    new client = GetClientOfUserId(userid);
    if(client && IsClientInGame(client))
    {        
         FakeClientCommand(client, "kill");
         SDKHooks_TakeDamage(client, client, client, 9999.0);
     
         RequestFrame(frame_respawn, userid);
    }
}

public frame_respawn(any:userid)
{
    new client = GetClientOfUserId(userid);
    if(client && IsClientInGame(client) && IsPlayerAlive(client))
    {
        TF2_RespawnPlayer(client);
    }
}

Edited friagram's code, I'm kinda surprised respawning a spectator does not cause a crash.
I remember it being a problem with my tf2 respawn api code (https://github.com/Benoist3012/-TF2--Respawn-System-API)

[YoNer]

Originally Posted by Benoist3012 You don't have to be sorry, the simple fact you used that plugin and gave feedbacks does not make you stupid #pragma semicolon 1 #include <sourcemod> #include <sdktools> #include <tf2> #include <sdkhooks> public Plugin:myinfo =  {     name = "Change Team Fix",     author = "Friagram",     description = "burp",     version = "1.0",     url = "http://steamcommunity.com/groups/poniponiponi" }; public OnPluginStart() {     HookEvent("player_team", Event_PlayerTeam); } public Event_PlayerTeam(Handle:hEvent, const String:name[], bool:dontBroadcast) {     new userid = GetEventInt(hEvent, "userid");     new client = GetClientOfUserId(userid);     if(client && IsClientInGame(client))     {                  FakeClientCommand(client, "kill");          SDKHooks_TakeDamage(client, client, client, 9999.0);                RequestFrame(frame_respawn, userid);     } } public frame_respawn(any:userid) {     new client = GetClientOfUserId(userid);     if(client && IsClientInGame(client) && IsPlayerAlive(client))     {         TF2_RespawnPlayer(client);     } } Edited friagram's code, I'm kinda surprised respawning a spectator does not cause a crash. I remember it being a problem with my tf2 respawn api code (https://github.com/Benoist3012/-TF2--Respawn-System-API)

There is still one issue with this approach, if you launch a missile and or pipe bomb and join spec they are not destroyed and keep hurting other players. Couldnt this be fixed by killing all child entities as well?