[Gemeni]

Hiyas ...
Seems like one of my plugin has started to leak memory ... even though I havnt change the code in quite some time ...

The following shows up in cstrike/sourcemod_fatal.log

L 09/19/2008 - 11:57:27: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "gem_damage_report.smx")
L 09/19/2008 - 11:57:27: [SM] Reloading plugin to free 15784 handles.
L 09/19/2008 - 11:57:27: [SM] Contact the author(s) of this plugin to correct this error.

What can cause this? Valve update? SourceMod update?

Is there a good way to trace this? I cant see anything regarding this in the sourcemod logfiles.

Thanks for any advice

[bl4nk]

Sounds like you're not closing handles properly, causing them to leak. It's most likely been a problem for a long time, it just got really bad that once to where it actually gave you an error.

[DiscoBBQ]

Make sure you use CloseHandle(Handle:Whatever); on any handles you open.

[Antithasys]

Most handles you do not have to close, as they handle themselves... BUT... anytime you "create" or "new Handle:" a handle in a stock function you have to make sure that you close it properly.

Check this article for more information. Click Me!

[BAILOPAN]

Link to the plugin, I can take a look.

[Gemeni]

Thanks Bailopan

https://forums.alliedmods.net/showthread.php?t=64661

[BAILOPAN]

Big leak in Event_PlayerSpawn

  // Temp fix menu
  if (g_MenuCleared[client] == 0) {
    new Handle:TempPanel = CreatePanel();
    DrawPanelText(TempPanel, "DR Fix");
    SendPanelToClient(TempPanel, client, Handler_MyPanel, 1);
    g_MenuCleared[client] = 1;
  }

Methinks SM should GC at some point. Or as a quick fix, attach line numbers to handles so they can be tracked down easier.

[Gemeni]

Attach line numbers?!

[BAILOPAN]

FYI there is a command, sm_dump_handles

It will help you track down leaks in the future.

[Gemeni]

Thanks ...
The ironic in this is that the temp menu fix is not needed anymore. It was fixed in a SM release about a year ago ;)

But ... a question regarding closing pack Handles

In DisplayDamageReport I declare a new Handle:pack

It's used in a CreateDataTimer and as a "parameter variable" in DisplayDamageReportMenu

If I close the pack handle in DisplayDamageReport, I get handle errors from DisplayDamageReportMenu saying that pack handle is non existing.

So, is there any way I can close the pack handle? Should I do it in DisplayDamageReportMenu? Or is it closed by default when that procedure finishes?